PMD Results

The following document contains the results of PMD 5.3.5.

Files

org/opentrafficsim/graphs/DataSampler.java

Violation Line
Avoid unused private fields such as 'lanes'. 30
Avoid empty if statements 68–70

org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.perception.LanePerception' 32
Useless parentheses. 257
Useless parentheses. 257
Useless parentheses. 258
Useless parentheses. 258
These nested if statements could be combined 328–348
These nested if statements could be combined 389–409

org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java

Violation Line
Avoid unused constructor parameters such as 'network'. 108
Avoid modifiers which are implied by the context 327–328

org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java

Violation Line
Avoid unused constructor parameters such as 'direction'. 102
Avoid unused constructor parameters such as 'position'. 102

org/opentrafficsim/road/gtu/generator/SpaceChecker.java

Violation Line
Avoid modifiers which are implied by the context 24

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Violation Line
Useless parentheses. 279
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 635
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 651
Avoid empty catch blocks 886–889

org/opentrafficsim/road/gtu/lane/object/LaneBlock.java

Violation Line
Avoid empty if statements 57–59

org/opentrafficsim/road/gtu/lane/object/LaneBlockOnOff.java

Violation Line
Avoid empty if statements 59–61

org/opentrafficsim/road/gtu/lane/object/OldTrafficLight.java

Violation Line
Avoid unused constructor parameters such as 'id'. 34

org/opentrafficsim/road/gtu/lane/object/animation/TrafficLightAnimation.java

Violation Line
Avoid unused private fields such as 'POINT_000'. 36

org/opentrafficsim/road/gtu/lane/perception/AbstractLanePerception.java

Violation Line
Avoid unused local variables such as 'down'. 66
Avoid unused local variables such as 'upMerge'. 72
Avoid empty if statements 74–77
Avoid empty if statements 79–82

org/opentrafficsim/road/gtu/lane/perception/LaneStructure.java

Violation Line
Useless parentheses. 241
Useless parentheses. 242
Useless parentheses. 265
Useless parentheses. 266

org/opentrafficsim/road/gtu/lane/perception/categories/DefaultAlexander.java

Violation Line
These nested if statements could be combined 882–900
Useless parentheses. 957
Useless parentheses. 957
Useless parentheses. 958
Useless parentheses. 958

org/opentrafficsim/road/gtu/lane/perception/categories/InfrastructurePerception.java

Violation Line
Do not use if statements that are always true or always false 101
Do not use if statements that are always true or always false 308

org/opentrafficsim/road/gtu/lane/perception/categories/NeighborsPerception.java

Violation Line
Do not use if statements that are always true or always false 122
Do not use if statements that are always true or always false 162
Do not use if statements that are always true or always false 199
Do not use if statements that are always true or always false 360
Do not use if statements that are always true or always false 447
These nested if statements could be combined 968–986

org/opentrafficsim/road/gtu/lane/perception/headway/AbstractHeadwayGTU.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.Throw' 8

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayGTUReal.java

Violation Line
Avoid unused imports such as 'org.djunits.value.vdouble.scalar.Acceleration' 3
Avoid unused imports such as 'org.djunits.value.vdouble.scalar.Speed' 5

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Violation Line
Overriding method merely calls super 35–38

org/opentrafficsim/road/gtu/lane/perceptionold/AbstractLanePerception.java

Violation Line
These nested if statements could be combined 543–560
Useless parentheses. 616
Useless parentheses. 616
Useless parentheses. 617
Useless parentheses. 617

org/opentrafficsim/road/gtu/lane/perceptionold/LanePerceptionNone.java

Violation Line
Avoid unused imports such as 'java.util.Collection' 3
Avoid unused imports such as 'java.util.HashSet' 4
Avoid unused imports such as 'org.opentrafficsim.core.gtu.perception.TimeStampedObject' 8
Avoid unused imports such as 'org.opentrafficsim.core.perception.PerceivedObject' 10

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Violation Line
Avoid unused local variables such as 'fromFirst'. 388
Avoid unused local variables such as 'toFirst'. 389

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Violation Line
Avoid unused local variables such as 'maximumReverseHeadway'. 127
Avoid unused local variables such as 'currentLaneFine'. 148
Useless parentheses. 212–213
Useless parentheses. 214–215
These nested if statements could be combined 527–532
Useless parentheses. 527
Useless parentheses. 528
Avoid unused method parameters such as 'gtu'. 561

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingChange0TacticalPlanner.java

Violation Line
These nested if statements could be combined 145–160
Avoid unused method parameters such as 'lanePathInfo'. 381

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingLaneChangeTacticalPlanner.java

Violation Line
These nested if statements could be combined 154–168
Useless parentheses. 453–454
Avoid unused private methods such as 'interpolateLinear(OTSLine3D,OTSLine3D,double)'. 544

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Violation Line
Useless parentheses. 156
Useless parentheses. 157–160

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Violation Line
Useless parentheses. 488
Useless parentheses. 489

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.gtu.GTU' 8
Useless parentheses. 166
Useless parentheses. 167
Useless parentheses. 181
Useless parentheses. 182

org/opentrafficsim/road/network/factory/XMLParser.java

Violation Line
These nested if statements could be combined 40–43

org/opentrafficsim/road/network/factory/xml/ArcTag.java

Violation Line
Useless parentheses. 88

org/opentrafficsim/road/network/factory/xml/FillTag.java

Violation Line
Avoid unused local variables such as 'lane'. 215
Avoid unused local variables such as 'gtuClass'. 216
Avoid unused local variables such as 'rg'. 222

org/opentrafficsim/road/network/factory/xml/Links.java

Violation Line
Useless parentheses. 428
These nested if statements could be combined 643–646
Avoid unused local variables such as 'trafficLight'. 709
These nested if statements could be combined 781–782
These nested if statements could be combined 805–806

org/opentrafficsim/road/network/lane/Lane.java

Violation Line
Useless parentheses. 400
Useless parentheses. 403
Useless parentheses. 414
Useless parentheses. 416
These nested if statements could be combined 419–423
These nested if statements could be combined 456–460
Useless parentheses. 565

org/opentrafficsim/road/network/lane/changing/OvertakingConditions.java

Violation Line
Avoid modifiers which are implied by the context 66–83
Avoid modifiers which are implied by the context 97–114
Avoid modifiers which are implied by the context 126–143
Avoid modifiers which are implied by the context 155–172
Avoid modifiers which are implied by the context 184–215
Avoid modifiers which are implied by the context 227–258
Avoid modifiers which are implied by the context 275–321
Useless parentheses. 306–308
Avoid modifiers which are implied by the context 338–384
Useless parentheses. 369–371
Avoid modifiers which are implied by the context 401–458
Useless parentheses. 440–442
Useless parentheses. 440–442
Avoid modifiers which are implied by the context 475–532
Useless parentheses. 514–516
Useless parentheses. 514–516

org/opentrafficsim/road/test/TestGMParser.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.gtu.behavioralcharacteristics.BehavioralCharacteristics' 47
Avoid unused imports such as 'org.opentrafficsim.core.gtu.plan.tactical.TacticalPlanner' 48
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingTacticalPlanner' 54
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.tactical.following.GTUFollowingModelOld' 56
Avoid unused imports such as 'org.opentrafficsim.road.gtu.strategical.route.LaneBasedStrategicalRoutePlanner' 60
Useless parentheses. 379

org/opentrafficsim/road/test/TestNetwork2.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.Throw' 22

org/opentrafficsim/road/test/TestXMLParserXStream.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.simulationengine.WrappableAnimation' 40