The following document contains the results of Checkstyle 6.2 with development/dsol-checks.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | AvoidNestedBlocks
|
2 |  Warning |
| EmptyBlock | 9 | Warning | |
| NeedBraces | 8 | Warning | |
| coding | HiddenField
|
2 | Warning |
| design | DesignForExtension | 51 | Warning |
| HideUtilityClassConstructor | 1 | Warning | |
| VisibilityModifier | 8 | Warning | |
| imports | UnusedImports | 5 | Warning |
| javadoc | JavadocMethod | 1 | Warning |
| JavadocVariable | 2 | Warning | |
| misc | FinalParameters | 23 | Warning |
NewlineAtEndOfFile
|
7 | Warning | |
| TodoComment | 6 | Warning | |
| modifier | RedundantModifier | 2 | Warning |
| sizes | LineLength
|
17 |  Info |
| MethodLength | 4 | Info | |
| ParameterNumber | 7 | Info | |
| whitespace | MethodParamPad | 1 | Warning |
| NoWhitespaceBefore | 1 | Warning |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'getRelativeBin' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Warning |
design | DesignForExtension | Method 'adjustMaximumValue' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Warning |
design | DesignForExtension | Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 95 |
| Warning |
design | DesignForExtension | Method 'getAggregatedBinCount' is not designed for extension - needs to be abstract, final or empty. | 103 |
| Warning |
design | DesignForExtension | Method 'getBinCount' is not designed for extension - needs to be abstract, final or empty. | 112 |
| Warning |
design | DesignForExtension | Method 'getCurrentGranularity' is not designed for extension - needs to be abstract, final or empty. | 121 |
| Warning |
design | DesignForExtension | Method 'setCurrentGranularity' is not designed for extension - needs to be abstract, final or empty. | 131 |
| Warning |
design | DesignForExtension | Method 'getMaximumValue' is not designed for extension - needs to be abstract, final or empty. | 148 |
| Warning |
design | DesignForExtension | Method 'setMaximumValue' is not designed for extension - needs to be abstract, final or empty. | 158 |
| Warning |
design | DesignForExtension | Method 'getMinimumValue' is not designed for extension - needs to be abstract, final or empty. | 171 |
| Warning |
design | DesignForExtension | Method 'getFormat' is not designed for extension - needs to be abstract, final or empty. | 189 |
| Warning |
design | DesignForExtension | Method 'getShortName' is not designed for extension - needs to be abstract, final or empty. | 198 |
| Warning |
design | DesignForExtension | Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 207 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 123 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 202 |
| Warning |
design | DesignForExtension | Method 'createChart' is not designed for extension - needs to be abstract, final or empty. | 267 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 71 |
| Warning |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Warning |
whitespace | NoWhitespaceBefore | ';' is preceded with whitespace. | 84 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'flow' must be private and have accessor methods. | 139 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'sample' is not designed for extension - needs to be abstract, final or empty. | 182 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 256 |
| Warning |
design | DesignForExtension | Method 'createChart' is not designed for extension - needs to be abstract, final or empty. | 291 |
| Warning |
misc | FinalParameters | Parameter gtu should be final. | 595 |
| Warning |
misc | FinalParameters | Parameter lane should be final. | 595 |
| Warning |
misc | FinalParameters | Parameter position should be final. | 595 |
| Warning |
misc | FinalParameters | Parameter item should be final. | 634 |
| Warning |
misc | FinalParameters | Parameter item should be final. | 641 |
| Warning |
misc | FinalParameters | Parameter item should be final. | 653 |
| Warning |
design | VisibilityModifier | Variable 'distance' must be private and have accessor methods. | 676 |
| Warning |
design | VisibilityModifier | Variable 'time' must be private and have accessor methods. | 679 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opentrafficsim.road.gtu.lane.perception.LanePerception. | 32 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 309 |
| Warning |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 337 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 370 |
| Warning |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 398 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'checkEnoughSpace' is not designed for extension - needs to be abstract, final or empty. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'reTryInterval' must be private and have accessor methods. | 76 |
| Warning |
design | VisibilityModifier | Variable 'initialLongitudinalPositions' must be private and have accessor methods. | 79 |
| Warning |
design | VisibilityModifier | Variable 'roomChecker' must be private and have accessor methods. | 82 |
| Warning |
design | VisibilityModifier | Variable 'gtuColorer' must be private and have accessor methods. | 85 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 105 |
| Warning |
misc | FinalParameters | Parameter id should be final. | 105 |
| Warning |
misc | FinalParameters | Parameter roomChecker should be final. | 108 |
| Warning |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 253 |
| Warning |
design | DesignForExtension | Method 'getGeneratedGTUs' is not designed for extension - needs to be abstract, final or empty. | 261 |
| Warning |
design | DesignForExtension | Method 'setGeneratedGTUs' is not designed for extension - needs to be abstract, final or empty. | 269 |
| Warning |
misc | FinalParameters | Parameter generatedGTUs should be final. | 269 |
| Warning |
design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 278 |
| Warning |
design | DesignForExtension | Method 'getEndTime' is not designed for extension - needs to be abstract, final or empty. | 287 |
| Warning |
design | DesignForExtension | Method 'getMaxGTUs' is not designed for extension - needs to be abstract, final or empty. | 296 |
| Warning |
design | DesignForExtension | Method 'getGtuColorer' is not designed for extension - needs to be abstract, final or empty. | 305 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 327 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 11). | 101 |
| Warning |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 191 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 24 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | MethodLength | Method length is 156 lines (max allowed is 150). | 501 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 858 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 873 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opentrafficsim.road.gtu.strategical.LaneBasedStrategicalPlanner. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 490 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 135). | 75 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 103 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opentrafficsim.road.network.speed.SpeedLimitProspect. | 10 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter operationalPlanSegmentList should be final. | 53 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 137). | 69 |
| Warning |
design | DesignForExtension | Method 'isLaneChange' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - javax.management.RuntimeErrorException. | 8 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 85 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 199 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 764 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 207 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 318 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 353 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 371 |
| Info |
sizes | MethodLength | Method length is 165 lines (max allowed is 150). | 414 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 629 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 135). | 27 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'generateOperationalPlan' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 58 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
whitespace | MethodParamPad | '(' is preceded with whitespace. | 77 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 44 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'duration' must be private and have accessor methods. | 33 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | HiddenField | 'stepSize' hides a field. | 107 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | HiddenField | 'stepSize' hides a field. | 114 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 15 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opentrafficsim.core.gtu.behavioralcharacteristics.ParameterTypes. | 13 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | MethodLength | Method length is 214 lines (max allowed is 150). | 91 |
| Info |
sizes | MethodLength | Method length is 175 lines (max allowed is 150). | 319 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 842 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 865 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 950 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 28 |
| Warning |
misc | FinalParameters | Parameter args should be final. | 35 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 552 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 716 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 171 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'generateTacticalPlanner' is not designed for extension - needs to be abstract, final or empty. | 42 |
| Warning |
design | DesignForExtension | Method 'nextNode' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Warning |
misc | FinalParameters | Parameter link should be final. | 50 |
| Warning |
misc | FinalParameters | Parameter direction should be final. | 50 |
| Warning |
misc | FinalParameters | Parameter gtuType should be final. | 50 |
| Warning |
design | DesignForExtension | Method 'nextLinkDirection' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Warning |
misc | FinalParameters | Parameter link should be final. | 57 |
| Warning |
misc | FinalParameters | Parameter direction should be final. | 57 |
| Warning |
misc | FinalParameters | Parameter gtuType should be final. | 57 |
| Warning |
design | DesignForExtension | Method 'nextNode' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Warning |
misc | FinalParameters | Parameter node should be final. | 65 |
| Warning |
misc | FinalParameters | Parameter previousLink should be final. | 65 |
| Warning |
misc | FinalParameters | Parameter gtuType should be final. | 65 |
| Warning |
design | DesignForExtension | Method 'nextLinkDirection' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Warning |
misc | FinalParameters | Parameter node should be final. | 72 |
| Warning |
misc | FinalParameters | Parameter previousLink should be final. | 72 |
| Warning |
misc | FinalParameters | Parameter gtuType should be final. | 72 |
| Warning |
design | DesignForExtension | Method 'getRoute' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 134). | 57 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
javadoc | JavadocMethod | Missing a Javadoc comment. | 490 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 587 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'generateTacticalPlanner' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Warning |
design | DesignForExtension | Method 'nextNode' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Warning |
design | DesignForExtension | Method 'nextLinkDirection' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Warning |
design | DesignForExtension | Method 'nextNode' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Warning |
design | DesignForExtension | Method 'nextLinkDirection' is not designed for extension - needs to be abstract, final or empty. | 114 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 141). | 86 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 179 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'getLocation' is not designed for extension - needs to be abstract, final or empty. | 90 |
| Warning |
design | DesignForExtension | Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 105 |
| Warning |
design | DesignForExtension | Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 120 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 122 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 124 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 127 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 131 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 134 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 138 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 141 |
| Warning |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 147 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'addDirectionality' is not designed for extension - needs to be abstract, final or empty. | 1358 |
| Warning |
design | DesignForExtension | Method 'removeDirectionality' is not designed for extension - needs to be abstract, final or empty. | 1371 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'clone' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 130 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 139 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 91 |
| Warning |
design | DesignForExtension | Method 'clone' is not designed for extension - needs to be abstract, final or empty. | 98 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 421 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 335 |
Errors