PMD Results

The following document contains the results of PMD 5.3.5.

Files

org/opentrafficsim/graphs/ContourPlot.java

Violation Line
Avoid empty catch blocks 201–204

org/opentrafficsim/graphs/DataSampler.java

Violation Line
Avoid empty if statements 71–73

org/opentrafficsim/graphs/TrajectoryPlot.java

Violation Line
Avoid empty catch blocks 255–258

org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java

Violation Line
Useless parentheses. 262
Useless parentheses. 262
Useless parentheses. 263
Useless parentheses. 263
These nested if statements could be combined 331–351
These nested if statements could be combined 391–411

org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java

Violation Line
Avoid unused constructor parameters such as 'network'. 113
Avoid modifiers which are implied by the context 360–361

org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java

Violation Line
Avoid unused constructor parameters such as 'direction'. 102
Avoid unused constructor parameters such as 'position'. 102

org/opentrafficsim/road/gtu/generator/SpaceChecker.java

Violation Line
Avoid modifiers which are implied by the context 24

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 731
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 747
Avoid empty catch blocks 959–962
Avoid empty catch blocks 974–977

org/opentrafficsim/road/gtu/lane/LaneBasedGTUCharacteristics.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.network.route.RouteGenerator' 8

org/opentrafficsim/road/gtu/lane/LaneBasedTemplateGTUType.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.simulationengine.SimpleSimulator' 18

org/opentrafficsim/road/gtu/lane/perception/LaneStructure.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.road.network.lane.Lane' 19
Useless parentheses. 219
Useless parentheses. 220
Useless parentheses. 286
Useless parentheses. 287
Useless parentheses. 332
Useless parentheses. 333
Useless parentheses. 362
Useless parentheses. 363

org/opentrafficsim/road/gtu/lane/perception/LaneStructureRecord.java

Violation Line
Useless parentheses. 277
Useless parentheses. 277–278
Useless parentheses. 278

org/opentrafficsim/road/gtu/lane/perception/categories/DefaultSimplePerception.java

Violation Line
These nested if statements could be combined 868–871
These nested if statements could be combined 1000–1018
Useless parentheses. 1074
Useless parentheses. 1074
Useless parentheses. 1075
Useless parentheses. 1075

org/opentrafficsim/road/gtu/lane/perception/categories/InfrastructurePerception.java

Violation Line
Useless parentheses. 324
Useless parentheses. 324

org/opentrafficsim/road/gtu/lane/perception/categories/NeighborsPerception.java

Violation Line
These nested if statements could be combined 356–359
Useless parentheses. 674–675
Useless parentheses. 676–677
Avoid unused private methods such as 'forwardHeadway(Length)'. 741
Avoid unused private methods such as 'backwardHeadway(Length)'. 859
These nested if statements could be combined 918–935

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Violation Line
Overriding method merely calls super 35–38

org/opentrafficsim/road/gtu/lane/plan/operational/LaneBasedOperationalPlan.java

Violation Line
Avoid unused imports such as 'org.djunits.value.vdouble.scalar.Length' 7

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Violation Line
Avoid unused local variables such as 'fromFirst'. 389
Avoid unused local variables such as 'toFirst'. 390
Avoid unused local variables such as 't'. 401

org/opentrafficsim/road/gtu/lane/tactical/AbstractLaneBasedTacticalPlanner.java

Violation Line
Avoid unused imports such as 'org.djunits.unit.LengthUnit' 11
Useless parentheses. 299
Useless parentheses. 300
Do not use if statements that are always true or always false 659
Useless parentheses. 710
Useless parentheses. 711

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Violation Line
Avoid unused local variables such as 'maximumReverseHeadway'. 125
Avoid unused local variables such as 'now'. 126
Avoid unused local variables such as 'currentLaneFine'. 148

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Violation Line
Useless parentheses. 219
These nested if statements could be combined 221–228
Useless parentheses. 249
Useless parentheses. 251–252
Avoid unused method parameters such as 'lanePathInfo'. 489
Useless parentheses. 612

org/opentrafficsim/road/gtu/lane/tactical/lmrs/LMRS.java

Violation Line
Avoid unused local variables such as 'q'. 133

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Violation Line
Useless parentheses. 155
Useless parentheses. 156–159

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Violation Line
These nested if statements could be combined 387–403

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Violation Line
Useless parentheses. 521
Useless parentheses. 522
Useless parentheses. 557
Useless parentheses. 558

org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalPlannerFactory.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.gtu.behavioralcharacteristics.BehavioralCharacteristics' 4

org/opentrafficsim/road/gtu/strategical/od/ODMatrix.java

Violation Line
Avoid unused local variables such as 'e'. 510

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Violation Line
Useless parentheses. 162
Useless parentheses. 163
Useless parentheses. 177
Useless parentheses. 178

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Violation Line
Avoid unused constructor parameters such as 'newSimulator'. 169
Avoid unused constructor parameters such as 'animation'. 170

org/opentrafficsim/road/network/lane/Lane.java

Violation Line
Useless parentheses. 488
Useless parentheses. 491
Useless parentheses. 502
Useless parentheses. 504
These nested if statements could be combined 507–511
These nested if statements could be combined 544–548
Useless parentheses. 646
Useless parentheses. 1290
Useless parentheses. 1291
Useless parentheses. 1327
Useless parentheses. 1328

org/opentrafficsim/road/network/lane/changing/OvertakingConditions.java

Violation Line
Avoid modifiers which are implied by the context 66–83
Avoid modifiers which are implied by the context 97–114
Avoid modifiers which are implied by the context 126–143
Avoid modifiers which are implied by the context 155–172
Avoid modifiers which are implied by the context 184–201
Avoid modifiers which are implied by the context 213–230
Avoid modifiers which are implied by the context 242–259
Avoid modifiers which are implied by the context 271–301
Avoid modifiers which are implied by the context 313–343
Avoid modifiers which are implied by the context 360–405
Useless parentheses. 391–392
Avoid modifiers which are implied by the context 422–467
Useless parentheses. 453–454
Avoid modifiers which are implied by the context 484–539
Useless parentheses. 522–523
Useless parentheses. 522–523
Avoid modifiers which are implied by the context 556–611
Useless parentheses. 594–595
Useless parentheses. 594–595

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Violation Line
Avoid unused imports such as 'org.djunits.unit.LengthUnit' 8
Useless parentheses. 118

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Violation Line
Useless parentheses. 393
Useless parentheses. 394
Useless parentheses. 519
Useless parentheses. 519
Useless parentheses. 527
Useless parentheses. 527

org/opentrafficsim/road/network/lane/object/AbstractLaneBasedObject.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.gtu.GTUDirectionality' 6

org/opentrafficsim/road/network/lane/object/sensor/SinkSensor.java

Violation Line
Avoid unused constructor parameters such as 'dummy1'. 63
Avoid unused constructor parameters such as 'dummy2'. 63

org/opentrafficsim/road/network/sampling/RoadSampler.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.gtu.behavioralcharacteristics.ParameterTypes' 19

org/opentrafficsim/road/network/sampling/SpeedLimit.java

Violation Line
Avoid unused imports such as 'org.djunits.unit.SpeedUnit' 3

org/opentrafficsim/road/network/sampling/indicator/TotalDelayReference.java

Violation Line
Avoid unused imports such as 'org.djunits.value.ValueException' 8
Avoid unused imports such as 'org.djunits.value.vfloat.vector.FloatLengthVector' 12