Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
52 9 56 0

Files

File  I  W  E
org/opentrafficsim/ahfe/AHFEUtil.java 2 2 0
org/opentrafficsim/demo/CircularLaneModel.java 0 5 0
org/opentrafficsim/demo/CircularLaneSwing.java 0 1 0
org/opentrafficsim/demo/CircularRoadModel.java 0 5 0
org/opentrafficsim/demo/CircularRoadSwing.java 0 1 0
org/opentrafficsim/demo/CrossingTrafficLightsModel.java 0 1 0
org/opentrafficsim/demo/FundamentalDiagrams.java 0 1 0
org/opentrafficsim/demo/NetworksModel.java 0 3 0
org/opentrafficsim/demo/NetworksSwing.java 0 3 0
org/opentrafficsim/demo/SequentialLanes.java 0 1 0
org/opentrafficsim/demo/ShortMerge.java 1 2 0
org/opentrafficsim/demo/StraightModel.java 0 3 0
org/opentrafficsim/demo/StraightSwing.java 0 1 0
org/opentrafficsim/demo/carFollowing/OpenStreetMap.java 0 1 0
org/opentrafficsim/demo/conflict/BusStreetDemo.java 0 1 0
org/opentrafficsim/demo/conflictAndControl/DemoTrafcodAndTurbo.java 1 1 0
org/opentrafficsim/demo/geometry/TestGeometry.java 1 0 0
org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java 1 0 0
org/opentrafficsim/demo/lanechange/LaneChangeGraph.java 1 5 0
org/opentrafficsim/demo/sdm/SdmSimulation.java 0 4 0
org/opentrafficsim/demo/sdm/SdmStrategicalPlannerFactory.java 0 1 0
org/opentrafficsim/demo/steering/SteeringSimulation.java 1 5 0
org/opentrafficsim/demo/trafficcontrol/TrafCODDemo.java 0 1 0
org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2.java 0 1 0
strategies/LmrsStrategies.java 1 3 0
strategies/StrategiesDemo.java 0 4 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 1  Warning
design DesignForExtension 47  Warning
javadoc JavadocMethod 1  Warning
JavadocPackage 3  Info
misc TodoComment 4  Warning
modifier RedundantModifier 2  Warning
naming ConstantName 1  Warning
sizes MethodLength 3  Info
ParameterNumber 3  Info

Details

org/opentrafficsim/ahfe/AHFEUtil.java

Severity Category Rule Message Line
 Info sizes MethodLength Method length is 162 lines (max allowed is 150). 146
 Info sizes ParameterNumber More than 7 parameters (found 14). 354
 Warning modifier RedundantModifier Redundant 'public' modifier. 583
 Warning modifier RedundantModifier Redundant 'public' modifier. 595

org/opentrafficsim/demo/CircularLaneModel.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'makeInputParameterMap' is not designed for extension - needs to be abstract, final or empty. 118
 Warning design DesignForExtension Method 'constructModel' is not designed for extension - needs to be abstract, final or empty. 141
 Warning design DesignForExtension Method 'getPath' is not designed for extension - needs to be abstract, final or empty. 263
 Warning design DesignForExtension Method 'getNetwork' is not designed for extension - needs to be abstract, final or empty. 269
 Warning design DesignForExtension Method 'stopSimulator' is not designed for extension - needs to be abstract, final or empty. 288

org/opentrafficsim/demo/CircularLaneSwing.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 67

org/opentrafficsim/demo/CircularRoadModel.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'makeInputParameterMap' is not designed for extension - needs to be abstract, final or empty. 109
 Warning design DesignForExtension Method 'getPath' is not designed for extension - needs to be abstract, final or empty. 145
 Warning design DesignForExtension Method 'constructModel' is not designed for extension - needs to be abstract, final or empty. 151
 Warning design DesignForExtension Method 'getNetwork' is not designed for extension - needs to be abstract, final or empty. 272
 Warning design DesignForExtension Method 'stopSimulator' is not designed for extension - needs to be abstract, final or empty. 291

org/opentrafficsim/demo/CircularRoadSwing.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 76

org/opentrafficsim/demo/CrossingTrafficLightsModel.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getNetwork' is not designed for extension - needs to be abstract, final or empty. 264

org/opentrafficsim/demo/FundamentalDiagrams.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 99

org/opentrafficsim/demo/NetworksModel.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'makeTemplate' is not designed for extension - needs to be abstract, final or empty. 422
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 488
 Warning design DesignForExtension Method 'getNetwork' is not designed for extension - needs to be abstract, final or empty. 505

org/opentrafficsim/demo/NetworksSwing.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 76
 Warning design DesignForExtension Method 'getParameter' is not designed for extension - needs to be abstract, final or empty. 268
 Warning design DesignForExtension Method 'getValue' is not designed for extension - needs to be abstract, final or empty. 276

org/opentrafficsim/demo/SequentialLanes.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 105

org/opentrafficsim/demo/ShortMerge.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'setAnimationToggles' is not designed for extension - needs to be abstract, final or empty. 162
 Warning blocks EmptyBlock Must have at least one statement. 296
 Info sizes ParameterNumber More than 7 parameters (found 12). 439

org/opentrafficsim/demo/StraightModel.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getPath' is not designed for extension - needs to be abstract, final or empty. 239
 Warning design DesignForExtension Method 'getNetwork' is not designed for extension - needs to be abstract, final or empty. 245
 Warning design DesignForExtension Method 'getLane' is not designed for extension - needs to be abstract, final or empty. 270

org/opentrafficsim/demo/StraightSwing.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 67

org/opentrafficsim/demo/carFollowing/OpenStreetMap.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'setAnimationToggles' is not designed for extension - needs to be abstract, final or empty. 75

org/opentrafficsim/demo/conflict/BusStreetDemo.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'draw' is not designed for extension - needs to be abstract, final or empty. 421

org/opentrafficsim/demo/conflictAndControl/DemoTrafcodAndTurbo.java

Severity Category Rule Message Line
 Info javadoc JavadocPackage Missing package-info.java file.
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 114

org/opentrafficsim/demo/geometry/TestGeometry.java

Severity Category Rule Message Line
 Info javadoc JavadocPackage Missing package-info.java file.

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Severity Category Rule Message Line
 Info javadoc JavadocPackage Missing package-info.java file.

org/opentrafficsim/demo/lanechange/LaneChangeGraph.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 8). 372
 Warning design DesignForExtension Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. 458
 Warning design DesignForExtension Method 'getInputParameterMap' is not designed for extension - needs to be abstract, final or empty. 465
 Warning design DesignForExtension Method 'getOutputStatistics' is not designed for extension - needs to be abstract, final or empty. 472
 Warning design DesignForExtension Method 'getShortName' is not designed for extension - needs to be abstract, final or empty. 479
 Warning design DesignForExtension Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. 486

org/opentrafficsim/demo/sdm/SdmSimulation.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'setDefaultProperties' is not designed for extension - needs to be abstract, final or empty. 136
 Warning design DesignForExtension Method 'setupSimulation' is not designed for extension - needs to be abstract, final or empty. 185
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 293
 Warning design DesignForExtension Method 'onSimulationEnd' is not designed for extension - needs to be abstract, final or empty. 385

org/opentrafficsim/demo/sdm/SdmStrategicalPlannerFactory.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getFactory' is not designed for extension - needs to be abstract, final or empty. 123

org/opentrafficsim/demo/steering/SteeringSimulation.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 86
 Warning design DesignForExtension Method 'setupSimulation' is not designed for extension - needs to be abstract, final or empty. 117
 Info sizes MethodLength Method length is 153 lines (max allowed is 150). 117
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 218
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 238
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 244

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 106

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addTabs' is not designed for extension - needs to be abstract, final or empty. 106

strategies/LmrsStrategies.java

Severity Category Rule Message Line
 Warning naming ConstantName Name 'colorer' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 260
 Info sizes MethodLength Method length is 170 lines (max allowed is 150). 277
 Warning javadoc JavadocMethod Expected @throws tag for 'OTSDrawingException'. 498
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 920

strategies/StrategiesDemo.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'setDefaultProperties' is not designed for extension - needs to be abstract, final or empty. 193
 Warning design DesignForExtension Method 'setupDemo' is not designed for extension - needs to be abstract, final or empty. 200
 Warning design DesignForExtension Method 'setupSimulation' is not designed for extension - needs to be abstract, final or empty. 489
 Warning design DesignForExtension Method 'createGtu' is not designed for extension - needs to be abstract, final or empty. 613