Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
49 11 100 0

Files

File  I  W  E
org/opentrafficsim/road/network/factory/xml/XmlParserException.java 0 4 0
org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java 0 2 0
org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java 0 11 0
org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java 1 10 0
org/opentrafficsim/road/network/factory/xml/network/ControlParser.java 0 1 0
org/opentrafficsim/road/network/factory/xml/network/LinkParser.java 1 40 0
org/opentrafficsim/road/network/factory/xml/network/NodeParser.java 0 2 0
org/opentrafficsim/road/network/factory/xml/network/Transformer.java 0 2 0
org/opentrafficsim/road/network/factory/xml/network/XmlNetworkLaneParser.java 1 1 0
org/opentrafficsim/road/network/factory/xml/old/ConnectorTag.java 0 5 0
org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java 0 3 0
org/opentrafficsim/road/network/factory/xml/old/GTUColorerTag.java 0 5 0
org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java 1 1 0
org/opentrafficsim/road/network/factory/xml/old/LaneTypeTag.java 1 0 0
org/opentrafficsim/road/network/factory/xml/old/LinkTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/old/Links.java 0 3 0
org/opentrafficsim/road/network/factory/xml/old/PolyLineTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/old/RoadLayoutTag.java 2 0 0
org/opentrafficsim/road/network/factory/xml/old/RoadTypeTag.java 2 0 0
org/opentrafficsim/road/network/factory/xml/old/RouteMixTag.java 1 0 0
org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java 1 8 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 2  Warning
NeedBraces 15  Warning
coding InnerAssignment 2  Warning
design DesignForExtension 6  Warning
HideUtilityClassConstructor 3  Warning
VisibilityModifier 27  Warning
javadoc JavadocStyle
  • checkHtml: "false"
 1  Warning
misc FinalParameters 13  Warning
TodoComment 29  Warning
modifier ModifierOrder 2  Warning
sizes LineLength
  • max: "128"
 8  Info
MethodLength 3  Info

Details

org/opentrafficsim/road/network/factory/xml/XmlParserException.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter message should be final. 33
 Warning misc FinalParameters Parameter cause should be final. 33
 Warning misc FinalParameters Parameter message should be final. 41
 Warning misc FinalParameters Parameter cause should be final. 49

org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'factor' must be private and have accessor methods. 47
 Warning design DesignForExtension Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. 173

org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 44
 Warning design VisibilityModifier Variable 'origin' must be private and have accessor methods. 47
 Warning design VisibilityModifier Variable 'destination' must be private and have accessor methods. 50
 Warning design VisibilityModifier Variable 'interpolation' must be private and have accessor methods. 53
 Warning design VisibilityModifier Variable 'category' must be private and have accessor methods. 56
 Warning design VisibilityModifier Variable 'categoryName' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'demandType' must be private and have accessor methods. 62
 Warning design VisibilityModifier Variable 'timeVector' must be private and have accessor methods. 65
 Warning design VisibilityModifier Variable 'demandVector' must be private and have accessor methods. 68
 Warning design VisibilityModifier Variable 'factor' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'factors' must be private and have accessor methods. 74

org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'network' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'categorization' must be private and have accessor methods. 77
 Warning design VisibilityModifier Variable 'categories' must be private and have accessor methods. 80
 Warning design VisibilityModifier Variable 'globalTime' must be private and have accessor methods. 83
 Warning design VisibilityModifier Variable 'globalInterpolation' must be private and have accessor methods. 86
 Warning design VisibilityModifier Variable 'demand' must be private and have accessor methods. 89
 Warning design DesignForExtension Method 'getGTUType' is not designed for extension - needs to be abstract, final or empty. 116
 Warning design DesignForExtension Method 'apply' is not designed for extension - needs to be abstract, final or empty. 138
 Warning design DesignForExtension Method 'apply' is not designed for extension - needs to be abstract, final or empty. 187
 Info sizes MethodLength Method length is 172 lines (max allowed is 150). 255
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 435

org/opentrafficsim/road/network/factory/xml/network/ControlParser.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 61

org/opentrafficsim/road/network/factory/xml/network/LinkParser.java

Severity Category Rule Message Line
 Warning design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 69
 Info sizes MethodLength Method length is 159 lines (max allowed is 150). 86
 Warning misc FinalParameters Parameter nodeDirections should be final. 86
 Warning misc FinalParameters Parameter simulator should be final. 87
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 174
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 208
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 215
 Warning blocks EmptyBlock Must have at least one statement. 219
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 220
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 221
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 232
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 243
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 244
 Warning misc FinalParameters Parameter simulator should be final. 257
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 265
 Warning misc FinalParameters Parameter t should be final. 274
 Warning blocks NeedBraces 'if' construct must use '{}'s. 284
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 298
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 299
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 305
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 311
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 318
 Warning blocks NeedBraces 'if' construct must use '{}'s. 325
 Warning blocks NeedBraces 'if' construct must use '{}'s. 336
 Warning blocks NeedBraces 'if' construct must use '{}'s. 359
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 364
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 367
 Warning blocks NeedBraces 'if' construct must use '{}'s. 372
 Warning blocks NeedBraces 'if' construct must use '{}'s. 398
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 403
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 429
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 430
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 436
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 437
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 444
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 445
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 452
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 453
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 459
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 460
 Warning misc FinalParameters Parameter ocStr should be final. 474

org/opentrafficsim/road/network/factory/xml/network/NodeParser.java

Severity Category Rule Message Line
 Warning design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 25
 Warning blocks NeedBraces 'for' construct must use '{}'s. 41

org/opentrafficsim/road/network/factory/xml/network/Transformer.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'if' construct must use '{}'s. 34
 Warning blocks NeedBraces 'else' construct must use '{}'s. 36

org/opentrafficsim/road/network/factory/xml/network/XmlNetworkLaneParser.java

Severity Category Rule Message Line
 Warning design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 44
 Info sizes LineLength Line is longer than 128 characters (found 131). 89

org/opentrafficsim/road/network/factory/xml/old/ConnectorTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'nodeStartTag' must be private and have accessor methods. 33
 Warning design VisibilityModifier Variable 'nodeEndTag' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'demandWeight' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'connector' must be private and have accessor methods. 42

org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'if' construct must use '{}'s. 482
 Warning blocks NeedBraces 'if' construct must use '{}'s. 485
 Warning blocks NeedBraces 'if' construct must use '{}'s. 488

org/opentrafficsim/road/network/factory/xml/old/GTUColorerTag.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 31
 Warning design VisibilityModifier Variable 'defaultColorer' must be private and have accessor methods. 33
 Warning blocks NeedBraces 'if' construct must use '{}'s. 69
 Warning blocks NeedBraces 'if' construct must use '{}'s. 84
 Warning blocks NeedBraces 'if' construct must use '{}'s. 97

org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'gtuDirection' must be private and have accessor methods. 77
 Info sizes LineLength Line is longer than 128 characters (found 130). 294

org/opentrafficsim/road/network/factory/xml/old/LaneTypeTag.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 80

org/opentrafficsim/road/network/factory/xml/old/LinkTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'priority' must be private and have accessor methods. 127

org/opentrafficsim/road/network/factory/xml/old/Links.java

Severity Category Rule Message Line
 Warning coding InnerAssignment Inner assignments should be avoided. 188
 Warning coding InnerAssignment Inner assignments should be avoided. 192
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 253

org/opentrafficsim/road/network/factory/xml/old/PolyLineTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'coordinates' must be private and have accessor methods. 33

org/opentrafficsim/road/network/factory/xml/old/RoadLayoutTag.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 150
 Info sizes LineLength Line is longer than 128 characters (found 131). 168

org/opentrafficsim/road/network/factory/xml/old/RoadTypeTag.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 87
 Info sizes LineLength Line is longer than 128 characters (found 129). 105

org/opentrafficsim/road/network/factory/xml/old/RouteMixTag.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 130). 47

org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'xmlComments' must be private and have accessor methods. 152
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 195
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 219
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 244
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 269
 Warning blocks EmptyBlock Must have at least one statement. 360
 Info sizes MethodLength Method length is 161 lines (max allowed is 150). 406
 Warning design DesignForExtension Method 'getXMLComments' is not designed for extension - needs to be abstract, final or empty. 618
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 632