FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
55 20 0 0

Files

Class Bugs
org.opentrafficsim.road.network.factory.xml.demand.XmlOdParser 1
org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser 8
org.opentrafficsim.road.network.factory.xml.old.FillTag 3
org.opentrafficsim.road.network.factory.xml.old.GeneratorTag 1
org.opentrafficsim.road.network.factory.xml.old.LinkTag 1
org.opentrafficsim.road.network.factory.xml.old.Links 2
org.opentrafficsim.road.network.factory.xml.old.ListGeneratorTag 1
org.opentrafficsim.road.network.factory.xml.old.XmlNetworkLaneParserOld 3

org.opentrafficsim.road.network.factory.xml.demand.XmlOdParser

Bug Category Details Line Priority
Class org.opentrafficsim.road.network.factory.xml.demand.XmlOdParser defines non-transient non-serializable instance field demand BAD_PRACTICE SE_BAD_FIELD Not available High

org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser

Bug Category Details Line Priority
Dead store to animation in org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser.build(InputStream, OTSNetwork, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 104 Medium
Dead store to controls in org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser.build(InputStream, OTSNetwork, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 100 Medium
Dead store to definitions in org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser.build(InputStream, OTSNetwork, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 97 Medium
Dead store to demands in org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser.build(InputStream, OTSNetwork, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 99 Medium
Dead store to modelParameters in org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser.build(InputStream, OTSNetwork, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 101 Medium
Dead store to run in org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser.build(InputStream, OTSNetwork, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 103 Medium
Dead store to scenario in org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser.build(InputStream, OTSNetwork, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 102 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.xml.network.XmlNetworkLaneParser.main(String[]) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 123 Medium

org.opentrafficsim.road.network.factory.xml.old.FillTag

Bug Category Details Line Priority
Dead store to rg in org.opentrafficsim.road.network.factory.xml.old.FillTag.makeFill(FillTag, XmlNetworkLaneParserOld, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) STYLE DLS_DEAD_LOCAL_STORE 222 High
Dead store to lane in org.opentrafficsim.road.network.factory.xml.old.FillTag.makeFill(FillTag, XmlNetworkLaneParserOld, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) STYLE DLS_DEAD_LOCAL_STORE 215 Medium
Dead store of org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU.class in org.opentrafficsim.road.network.factory.xml.old.FillTag.makeFill(FillTag, XmlNetworkLaneParserOld, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) CORRECTNESS DLS_DEAD_STORE_OF_CLASS_LITERAL 216 Medium

org.opentrafficsim.road.network.factory.xml.old.GeneratorTag

Bug Category Details Line Priority
Dead store to generator in org.opentrafficsim.road.network.factory.xml.old.GeneratorTag.makeGenerator(GeneratorTag, XmlNetworkLaneParserOld, LinkTag, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 362 High

org.opentrafficsim.road.network.factory.xml.old.LinkTag

Bug Category Details Line Priority
Class org.opentrafficsim.road.network.factory.xml.old.LinkTag defines non-transient non-serializable instance field bezierTag BAD_PRACTICE SE_BAD_FIELD Not available High

org.opentrafficsim.road.network.factory.xml.old.Links

Bug Category Details Line Priority
Useless object stored in variable cseList of method org.opentrafficsim.road.network.factory.xml.old.Links.applyRoadTypeToLink(LinkTag, XmlNetworkLaneParserOld, OTSSimulatorInterface) STYLE UC_USELESS_OBJECT 284 Medium
Useless object stored in variable lanes of method org.opentrafficsim.road.network.factory.xml.old.Links.applyRoadTypeToLink(LinkTag, XmlNetworkLaneParserOld, OTSSimulatorInterface) STYLE UC_USELESS_OBJECT 285 Medium

org.opentrafficsim.road.network.factory.xml.old.ListGeneratorTag

Bug Category Details Line Priority
Unwritten field: org.opentrafficsim.road.network.factory.xml.old.ListGeneratorTag.gtuColorer CORRECTNESS UWF_UNWRITTEN_FIELD 143 Medium

org.opentrafficsim.road.network.factory.xml.old.XmlNetworkLaneParserOld

Bug Category Details Line Priority
Write to static field org.opentrafficsim.road.network.factory.xml.old.GTUColorerTag.defaultColorer from instance method new org.opentrafficsim.road.network.factory.xml.old.XmlNetworkLaneParserOld(OTSSimulatorInterface, GTUColorer) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 172 High
Useless object stored in variable templates of method org.opentrafficsim.road.network.factory.xml.old.XmlNetworkLaneParserOld.fixOD(OTSNetwork) STYLE UC_USELESS_OBJECT 561 Medium
org.opentrafficsim.road.network.factory.xml.old.XmlNetworkLaneParserOld.build(InputStream, OTSNetwork, boolean) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 370 Medium