Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
56 11 147 0

Files

File  I  W  E
org/opentrafficsim/road/network/factory/xml/XmlParserException.java 0 4 0
org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java 0 2 0
org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java 0 11 0
org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java 1 10 0
org/opentrafficsim/road/network/factory/xml/old/ConnectorTag.java 0 5 0
org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java 0 3 0
org/opentrafficsim/road/network/factory/xml/old/GTUColorerTag.java 0 5 0
org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/old/LinkTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/old/Links.java 0 3 0
org/opentrafficsim/road/network/factory/xml/old/PolyLineTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java 1 8 0
org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java 0 7 0
org/opentrafficsim/road/network/factory/xml/parser/DemandParser.java 2 13 0
org/opentrafficsim/road/network/factory/xml/parser/GeneratorSinkParser.java 1 11 0
org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java 4 4 0
org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java 1 24 0
org/opentrafficsim/road/network/factory/xml/parser/RunParser.java 0 1 0
org/opentrafficsim/road/network/factory/xml/parser/ScenarioParser.java 0 2 0
org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java 1 9 0
org/opentrafficsim/road/network/factory/xml/utils/Cloner.java 0 2 0
org/opentrafficsim/road/network/factory/xml/utils/Generators.java 0 12 0
org/opentrafficsim/road/network/factory/xml/utils/ParseDistribution.java 0 5 0
org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java 0 1 0
org/opentrafficsim/road/network/factory/xml/utils/Transformer.java 0 2 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 5  Warning
NeedBraces 24  Warning
coding InnerAssignment 2  Warning
design DesignForExtension 7  Warning
FinalClass 3  Warning
HideUtilityClassConstructor 1  Warning
VisibilityModifier 27  Warning
imports UnusedImports 8  Warning
javadoc JavadocMethod 2  Warning
JavadocStyle
  • checkHtml: "false"
 6  Warning
misc FinalParameters 38  Warning
TodoComment 18  Warning
modifier ModifierOrder 4  Warning
RedundantModifier 2  Warning
sizes LineLength
  • max: "128"
 4  Info
MethodLength 7  Info

Details

org/opentrafficsim/road/network/factory/xml/XmlParserException.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter message should be final. 33
 Warning misc FinalParameters Parameter cause should be final. 33
 Warning misc FinalParameters Parameter message should be final. 41
 Warning misc FinalParameters Parameter cause should be final. 49

org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'factor' must be private and have accessor methods. 47
 Warning design DesignForExtension Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. 173

org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 44
 Warning design VisibilityModifier Variable 'origin' must be private and have accessor methods. 47
 Warning design VisibilityModifier Variable 'destination' must be private and have accessor methods. 50
 Warning design VisibilityModifier Variable 'interpolation' must be private and have accessor methods. 53
 Warning design VisibilityModifier Variable 'category' must be private and have accessor methods. 56
 Warning design VisibilityModifier Variable 'categoryName' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'demandType' must be private and have accessor methods. 62
 Warning design VisibilityModifier Variable 'timeVector' must be private and have accessor methods. 65
 Warning design VisibilityModifier Variable 'demandVector' must be private and have accessor methods. 68
 Warning design VisibilityModifier Variable 'factor' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'factors' must be private and have accessor methods. 74

org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'network' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'categorization' must be private and have accessor methods. 77
 Warning design VisibilityModifier Variable 'categories' must be private and have accessor methods. 80
 Warning design VisibilityModifier Variable 'globalTime' must be private and have accessor methods. 83
 Warning design VisibilityModifier Variable 'globalInterpolation' must be private and have accessor methods. 86
 Warning design VisibilityModifier Variable 'demand' must be private and have accessor methods. 89
 Warning design DesignForExtension Method 'getGTUType' is not designed for extension - needs to be abstract, final or empty. 116
 Warning design DesignForExtension Method 'apply' is not designed for extension - needs to be abstract, final or empty. 138
 Warning design DesignForExtension Method 'apply' is not designed for extension - needs to be abstract, final or empty. 187
 Info sizes MethodLength Method length is 172 lines (max allowed is 150). 255
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 435

org/opentrafficsim/road/network/factory/xml/old/ConnectorTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'nodeStartTag' must be private and have accessor methods. 33
 Warning design VisibilityModifier Variable 'nodeEndTag' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'demandWeight' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'connector' must be private and have accessor methods. 42

org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'if' construct must use '{}'s. 482
 Warning blocks NeedBraces 'if' construct must use '{}'s. 485
 Warning blocks NeedBraces 'if' construct must use '{}'s. 488

org/opentrafficsim/road/network/factory/xml/old/GTUColorerTag.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 31
 Warning design VisibilityModifier Variable 'defaultColorer' must be private and have accessor methods. 33
 Warning blocks NeedBraces 'if' construct must use '{}'s. 69
 Warning blocks NeedBraces 'if' construct must use '{}'s. 84
 Warning blocks NeedBraces 'if' construct must use '{}'s. 97

org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'gtuDirection' must be private and have accessor methods. 77

org/opentrafficsim/road/network/factory/xml/old/LinkTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'priority' must be private and have accessor methods. 127

org/opentrafficsim/road/network/factory/xml/old/Links.java

Severity Category Rule Message Line
 Warning coding InnerAssignment Inner assignments should be avoided. 189
 Warning coding InnerAssignment Inner assignments should be avoided. 193
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 254

org/opentrafficsim/road/network/factory/xml/old/PolyLineTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'coordinates' must be private and have accessor methods. 33

org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'xmlComments' must be private and have accessor methods. 152
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 195
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 219
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 244
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 269
 Warning blocks EmptyBlock Must have at least one statement. 360
 Info sizes MethodLength Method length is 162 lines (max allowed is 150). 406
 Warning design DesignForExtension Method 'getXMLComments' is not designed for extension - needs to be abstract, final or empty. 619
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 633

org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter streamMap should be final. 63
 Warning misc FinalParameters Parameter linkTypeSpeedLimitMap should be final. 64
 Warning blocks NeedBraces 'else' construct must use '{}'s. 108
 Warning blocks NeedBraces 'else' construct must use '{}'s. 152
 Warning blocks NeedBraces 'else' construct must use '{}'s. 213
 Warning misc FinalParameters Parameter gtuTemplates should be final. 229
 Warning misc FinalParameters Parameter streamMap should be final. 229

org/opentrafficsim/road/network/factory/xml/parser/DemandParser.java

Severity Category Rule Message Line
 Warning design FinalClass Class DemandParser should be declared as final. 96
 Info sizes MethodLength Method length is 500 lines (max allowed is 150). 116
 Warning misc FinalParameters Parameter factories should be final. 118
 Warning blocks EmptyBlock Must have at least one statement. 132
 Warning blocks EmptyBlock Must have at least one statement. 159
 Warning blocks EmptyBlock Must have at least one statement. 164
 Info sizes LineLength Line is longer than 128 characters (found 136). 398
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 464
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 512
 Warning misc FinalParameters Parameter factor should be final. 628
 Warning modifier RedundantModifier Redundant 'final' modifier. 668
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 668
 Warning javadoc JavadocMethod Expected @throws tag for 'XmlParserException'. 668
 Warning modifier RedundantModifier Redundant 'final' modifier. 686
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 686

org/opentrafficsim/road/network/factory/xml/parser/GeneratorSinkParser.java

Severity Category Rule Message Line
 Warning design FinalClass Class GeneratorSinkParser should be declared as final. 64
 Warning misc FinalParameters Parameter gtuTemplates should be final. 84
 Warning misc FinalParameters Parameter streamMap should be final. 85
 Warning blocks NeedBraces 'if' construct must use '{}'s. 103
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 109
 Warning blocks NeedBraces 'if' construct must use '{}'s. 136
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 142
 Warning blocks NeedBraces 'if' construct must use '{}'s. 162
 Warning blocks NeedBraces 'if' construct must use '{}'s. 166
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 179
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 194
 Info sizes LineLength Line is longer than 128 characters (found 136). 195

org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java

Severity Category Rule Message Line
 Warning design FinalClass Class ModelParser should be declared as final. 148
 Info sizes MethodLength Method length is 165 lines (max allowed is 150). 169
 Info sizes LineLength Line is longer than 128 characters (found 144). 354
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 395
 Warning javadoc JavadocMethod Missing a Javadoc comment. 408
 Info sizes MethodLength Method length is 199 lines (max allowed is 150). 472
 Info sizes MethodLength Method length is 241 lines (max allowed is 150). 894
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 1086

org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'for' construct must use '{}'s. 92
 Warning misc FinalParameters Parameter nodeDirections should be final. 153
 Warning misc FinalParameters Parameter simulator should be final. 154
 Warning blocks EmptyBlock Must have at least one statement. 275
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 278
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 289
 Warning misc FinalParameters Parameter simulator should be final. 316
 Warning misc FinalParameters Parameter roadLayoutMap should be final. 317
 Warning misc FinalParameters Parameter linkTypeSpeedLimitMap should be final. 317
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 395
 Warning blocks NeedBraces 'if' construct must use '{}'s. 398
 Warning blocks NeedBraces 'if' construct must use '{}'s. 441
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 458
 Info sizes MethodLength Method length is 196 lines (max allowed is 150). 473
 Warning misc FinalParameters Parameter roadLayoutTag should be final. 473
 Warning misc FinalParameters Parameter xmlLink should be final. 473
 Warning misc FinalParameters Parameter cseDataList should be final. 473
 Warning misc FinalParameters Parameter cseTagMap should be final. 474
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 751
 Warning blocks NeedBraces 'if' construct must use '{}'s. 771
 Warning blocks NeedBraces 'if' construct must use '{}'s. 776
 Warning blocks NeedBraces 'if' construct must use '{}'s. 796
 Warning blocks NeedBraces 'if' construct must use '{}'s. 800
 Warning blocks NeedBraces 'if' construct must use '{}'s. 804
 Warning blocks NeedBraces 'if' construct must use '{}'s. 811

org/opentrafficsim/road/network/factory/xml/parser/RunParser.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 102

org/opentrafficsim/road/network/factory/xml/parser/ScenarioParser.java

Severity Category Rule Message Line
 Warning design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 22
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 34

org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - java.rmi.RemoteException. 9
 Warning imports UnusedImports Unused import - org.opentrafficsim.base.parameters.ParameterException. 29
 Warning imports UnusedImports Unused import - org.opentrafficsim.draw.lane.LaneStructureAnimation. 40
 Warning imports UnusedImports Unused import - org.opentrafficsim.road.gtu.lane.LaneBasedGTU. 42
 Warning imports UnusedImports Unused import - org.opentrafficsim.road.gtu.lane.perception.RollingLaneStructure. 43
 Warning imports UnusedImports Unused import - nl.tudelft.simulation.dsol.logger.SimLogger. 64
 Warning imports UnusedImports Unused import - nl.tudelft.simulation.event.EventInterface. 66
 Warning imports UnusedImports Unused import - nl.tudelft.simulation.event.EventListenerInterface. 67
 Info sizes LineLength Line is longer than 128 characters (found 129). 195
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 209

org/opentrafficsim/road/network/factory/xml/utils/Cloner.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter object should be final. 41
 Warning misc FinalParameters Parameter in should be final. 63

org/opentrafficsim/road/network/factory/xml/utils/Generators.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 47
 Warning misc FinalParameters Parameter streamMap should be final. 54
 Warning javadoc JavadocStyle First sentence should end with a period. 84
 Warning misc FinalParameters Parameter streamMap should be final. 91
 Warning javadoc JavadocStyle First sentence should end with a period. 121
 Warning misc FinalParameters Parameter streamMap should be final. 128
 Warning javadoc JavadocStyle First sentence should end with a period. 158
 Warning misc FinalParameters Parameter streamMap should be final. 165
 Warning javadoc JavadocStyle First sentence should end with a period. 195
 Warning misc FinalParameters Parameter streamMap should be final. 202
 Warning misc FinalParameters Parameter streamMap should be final. 239
 Warning misc FinalParameters Parameter streamMap should be final. 276

org/opentrafficsim/road/network/factory/xml/utils/ParseDistribution.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 155
 Warning misc FinalParameters Parameter streamMap should be final. 357
 Warning misc FinalParameters Parameter frequencyDist should be final. 357
 Warning misc FinalParameters Parameter streamMap should be final. 379
 Warning misc FinalParameters Parameter linearDensityDist should be final. 379

org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 38

org/opentrafficsim/road/network/factory/xml/utils/Transformer.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'if' construct must use '{}'s. 45
 Warning blocks NeedBraces 'else' construct must use '{}'s. 47