PMD Results

The following document contains the results of PMD 6.4.0.

Files

org/opentrafficsim/road/network/factory/xml/demand/XMLParser.java

Violation Priority Line
These nested if statements could be combined 3 4346

org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java

Violation Priority Line
Useless parentheses. 4 376
Useless parentheses. 4 379

org/opentrafficsim/road/network/factory/xml/old/ArcTag.java

Violation Priority Line
Useless parentheses. 4 87

org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java

Violation Priority Line
Useless parentheses. 4 491
Useless parentheses. 4 492

org/opentrafficsim/road/network/factory/xml/old/FillTag.java

Violation Priority Line
Avoid unused local variables such as 'gtuClass'. 3 217
Avoid unused local variables such as 'rg'. 3 223

org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java

Violation Priority Line
Avoid unused local variables such as 'generator'. 3 362

org/opentrafficsim/road/network/factory/xml/old/Links.java

Violation Priority Line
Useless parentheses. 4 190
Useless parentheses. 4 198
Useless parentheses. 4 203
Useless parentheses. 4 206
Avoid unused local variables such as 'overtakingConditions'. 3 354
These nested if statements could be combined 3 375378
These nested if statements could be combined 3 495496
These nested if statements could be combined 3 519520

org/opentrafficsim/road/network/factory/xml/old/XMLParser.java

Violation Priority Line
These nested if statements could be combined 3 4346

org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java

Violation Priority Line
Avoid empty if statements 3 360362
Avoid unused private methods such as 'fixOD(OTSRoadNetwork)'. 3 406
Useless parentheses. 4 466

org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java

Violation Priority Line
Useless parentheses. 4 88
Useless parentheses. 4 89
Useless parentheses. 4 132
Useless parentheses. 4 133
Useless parentheses. 4 181
Useless parentheses. 4 182

org/opentrafficsim/road/network/factory/xml/parser/DemandParser.java

Violation Priority Line
Avoid unused local variables such as 'gtuMix'. 3 131
Avoid unused local variables such as 'id'. 3 141
Avoid unused local variables such as 'interarrivelTimeGenerator'. 3 142
Avoid unused local variables such as 'roomChecker'. 3 143
Avoid unused local variables such as 'laneBasedGTUCharacteristicsGenerator'. 3 144
Avoid unused local variables such as 'positions'. 3 151
Avoid unused local variables such as 'generator'. 3 158
Avoid unused local variables such as 'sink'. 3 163
Useless parentheses. 4 234
Useless parentheses. 4 235
Useless parentheses. 4 238
Useless parentheses. 4 239
Useless parentheses. 4 242
Useless parentheses. 4 243
Useless parentheses. 4 343344
Useless parentheses. 4 350
Useless parentheses. 4 459
Avoid modifiers which are implied by the context 3 668678
Avoid modifiers which are implied by the context 3 686696

org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java

Violation Priority Line
Avoid unused private methods such as 'getParameterType(String,Class)'. 3 409
Avoid unused private methods such as 'getParameterTypeNumeric(String,Class)'. 3 434

org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java

Violation Priority Line
Useless parentheses. 4 216
Useless parentheses. 4 224
Useless parentheses. 4 229
Useless parentheses. 4 238
Avoid empty if statements 3 275279
These nested if statements could be combined 3 361365
Avoid unused local variables such as 'direction'. 3 393

org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java

Violation Priority Line
Avoid unused imports such as 'java.rmi.RemoteException' 4 9
Avoid unused imports such as 'org.opentrafficsim.base.parameters.ParameterException' 4 29
Avoid unused imports such as 'org.opentrafficsim.draw.lane.LaneStructureAnimation' 4 40
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.LaneBasedGTU' 4 42
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.perception.RollingLaneStructure' 4 43
Avoid unused imports such as 'nl.tudelft.simulation.dsol.logger.SimLogger' 4 64
Avoid unused imports such as 'nl.tudelft.simulation.event.EventInterface' 4 66
Avoid unused imports such as 'nl.tudelft.simulation.event.EventListenerInterface' 4 67
Avoid unused local variables such as 'generators'. 3 179
Avoid unused local variables such as 'generators'. 3 240
Avoid unused local variables such as 'modelParameters'. 3 269
Avoid unused local variables such as 'scenario'. 3 270
Avoid unused local variables such as 'animation'. 3 271

org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java

Violation Priority Line
Avoid unused private fields such as 'seedMap'. 3 22