The following document contains the results of Checkstyle 8.26 with development/dsol-checks.xml ruleset.
Files | ![]() |
![]() |
![]() |
---|---|---|---|
56 | 10 | 75 | 0 |
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | EmptyBlock | 2 | ![]() |
NeedBraces | 11 | ![]() | |
coding | InnerAssignment | 2 | ![]() |
design | FinalClass | 1 | ![]() |
HideUtilityClassConstructor | 1 | ![]() | |
VisibilityModifier | 27 | ![]() | |
imports | UnusedImports | 2 | ![]() |
javadoc | JavadocStyle
|
1 | ![]() |
misc | FinalParameters | 6 | ![]() |
TodoComment | 20 | ![]() | |
modifier | ModifierOrder | 2 | ![]() |
sizes | LineLength
|
4 | ![]() |
MethodLength | 6 | ![]() |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'factor' must be private and have accessor methods. | 47 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 45 |
![]() |
design | VisibilityModifier | Variable 'origin' must be private and have accessor methods. | 48 |
![]() |
design | VisibilityModifier | Variable 'destination' must be private and have accessor methods. | 51 |
![]() |
design | VisibilityModifier | Variable 'interpolation' must be private and have accessor methods. | 54 |
![]() |
design | VisibilityModifier | Variable 'category' must be private and have accessor methods. | 57 |
![]() |
design | VisibilityModifier | Variable 'categoryName' must be private and have accessor methods. | 60 |
![]() |
design | VisibilityModifier | Variable 'demandType' must be private and have accessor methods. | 63 |
![]() |
design | VisibilityModifier | Variable 'timeVector' must be private and have accessor methods. | 66 |
![]() |
design | VisibilityModifier | Variable 'demandVector' must be private and have accessor methods. | 69 |
![]() |
design | VisibilityModifier | Variable 'factor' must be private and have accessor methods. | 72 |
![]() |
design | VisibilityModifier | Variable 'factors' must be private and have accessor methods. | 75 |
![]() |
sizes | LineLength | Line is longer than 128 characters (found 141). | 180 |
![]() |
sizes | LineLength | Line is longer than 128 characters (found 130). | 191 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'network' must be private and have accessor methods. | 71 |
![]() |
design | VisibilityModifier | Variable 'categorization' must be private and have accessor methods. | 77 |
![]() |
design | VisibilityModifier | Variable 'categories' must be private and have accessor methods. | 80 |
![]() |
design | VisibilityModifier | Variable 'globalTime' must be private and have accessor methods. | 83 |
![]() |
design | VisibilityModifier | Variable 'globalInterpolation' must be private and have accessor methods. | 86 |
![]() |
design | VisibilityModifier | Variable 'demand' must be private and have accessor methods. | 89 |
![]() |
sizes | MethodLength | Method length is 172 lines (max allowed is 150). | 255 |
![]() |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 435 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'name' must be private and have accessor methods. | 30 |
![]() |
design | VisibilityModifier | Variable 'nodeStartTag' must be private and have accessor methods. | 33 |
![]() |
design | VisibilityModifier | Variable 'nodeEndTag' must be private and have accessor methods. | 36 |
![]() |
design | VisibilityModifier | Variable 'demandWeight' must be private and have accessor methods. | 39 |
![]() |
design | VisibilityModifier | Variable 'connector' must be private and have accessor methods. | 42 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
blocks | NeedBraces | 'if' construct must use '{}'s. | 482 |
![]() |
blocks | NeedBraces | 'if' construct must use '{}'s. | 485 |
![]() |
blocks | NeedBraces | 'if' construct must use '{}'s. | 488 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 31 |
![]() |
design | VisibilityModifier | Variable 'defaultColorer' must be private and have accessor methods. | 33 |
![]() |
blocks | NeedBraces | 'if' construct must use '{}'s. | 69 |
![]() |
blocks | NeedBraces | 'if' construct must use '{}'s. | 84 |
![]() |
blocks | NeedBraces | 'if' construct must use '{}'s. | 97 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'gtuDirection' must be private and have accessor methods. | 77 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'priority' must be private and have accessor methods. | 127 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
coding | InnerAssignment | Inner assignments should be avoided. | 190 |
![]() |
coding | InnerAssignment | Inner assignments should be avoided. | 194 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 255 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'coordinates' must be private and have accessor methods. | 33 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'xmlComments' must be private and have accessor methods. | 153 |
![]() |
sizes | LineLength | Line is longer than 128 characters (found 132). | 270 |
![]() |
blocks | EmptyBlock | Must have at least one statement. | 361 |
![]() |
sizes | MethodLength | Method length is 162 lines (max allowed is 150). | 407 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | FinalParameters | Parameter streamMap should be final. | 63 |
![]() |
misc | FinalParameters | Parameter linkTypeSpeedLimitMap should be final. | 64 |
![]() |
blocks | NeedBraces | 'else' construct must use '{}'s. | 108 |
![]() |
blocks | NeedBraces | 'else' construct must use '{}'s. | 152 |
![]() |
blocks | NeedBraces | 'else' construct must use '{}'s. | 213 |
![]() |
misc | FinalParameters | Parameter gtuTemplates should be final. | 229 |
![]() |
misc | FinalParameters | Parameter streamMap should be final. | 229 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 138 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 332 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 347 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | FinalClass | Class ModelParser should be declared as final. | 149 |
![]() |
sizes | MethodLength | Method length is 165 lines (max allowed is 150). | 170 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 397 |
![]() |
sizes | MethodLength | Method length is 199 lines (max allowed is 150). | 474 |
![]() |
sizes | MethodLength | Method length is 240 lines (max allowed is 150). | 895 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1086 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | UnusedImports | Unused import - org.djutils.logger.CategoryLogger. | 18 |
![]() |
imports | UnusedImports | Unused import - org.opentrafficsim.base.logger.Cat. | 20 |
![]() |
sizes | MethodLength | Method length is 155 lines (max allowed is 150). | 158 |
![]() |
blocks | EmptyBlock | Must have at least one statement. | 288 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 291 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 302 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 410 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 477 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 151 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 165 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 325 |
![]() |
sizes | LineLength | Line is longer than 128 characters (found 136). | 375 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 443 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 491 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 102 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 22 |
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 34 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 250 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | FinalParameters | Parameter object should be final. | 41 |
![]() |
misc | FinalParameters | Parameter in should be final. | 63 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 154 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 38 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
blocks | NeedBraces | 'if' construct must use '{}'s. | 45 |
![]() |
blocks | NeedBraces | 'else' construct must use '{}'s. | 47 |