Checkstyle Results

The following document contains the results of Checkstyle 8.26 with development/dsol-checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
56 10 75 0

Files

File
 I
 W
 E
org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java 2 11 0
org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java 1 7 0
org/opentrafficsim/road/network/factory/xml/old/ConnectorTag.java 0 5 0
org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java 0 3 0
org/opentrafficsim/road/network/factory/xml/old/GTUColorerTag.java 0 5 0
org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/old/LinkTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/old/Links.java 0 3 0
org/opentrafficsim/road/network/factory/xml/old/PolyLineTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java 2 2 0
org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java 0 7 0
org/opentrafficsim/road/network/factory/xml/parser/GeneratorSinkParser.java 0 3 0
org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java 3 3 0
org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java 1 7 0
org/opentrafficsim/road/network/factory/xml/parser/ODParser.java 1 5 0
org/opentrafficsim/road/network/factory/xml/parser/RunParser.java 0 1 0
org/opentrafficsim/road/network/factory/xml/parser/ScenarioParser.java 0 2 0
org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java 0 1 0
org/opentrafficsim/road/network/factory/xml/utils/Cloner.java 0 2 0
org/opentrafficsim/road/network/factory/xml/utils/ParseDistribution.java 0 1 0
org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java 0 1 0
org/opentrafficsim/road/network/factory/xml/utils/Transformer.java 0 2 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 2
 Warning
NeedBraces 11
 Warning
coding InnerAssignment 2
 Warning
design FinalClass 1
 Warning
HideUtilityClassConstructor 1
 Warning
VisibilityModifier 27
 Warning
imports UnusedImports 2
 Warning
javadoc JavadocStyle
  • checkHtml: "false"
1
 Warning
misc FinalParameters 6
 Warning
TodoComment 20
 Warning
modifier ModifierOrder 2
 Warning
sizes LineLength
  • max: "128"
4
 Info
MethodLength 6
 Info

Details

org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'factor' must be private and have accessor methods. 47

org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java

Severity Category Rule Message Line
 Warning
modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 45
 Warning
design VisibilityModifier Variable 'origin' must be private and have accessor methods. 48
 Warning
design VisibilityModifier Variable 'destination' must be private and have accessor methods. 51
 Warning
design VisibilityModifier Variable 'interpolation' must be private and have accessor methods. 54
 Warning
design VisibilityModifier Variable 'category' must be private and have accessor methods. 57
 Warning
design VisibilityModifier Variable 'categoryName' must be private and have accessor methods. 60
 Warning
design VisibilityModifier Variable 'demandType' must be private and have accessor methods. 63
 Warning
design VisibilityModifier Variable 'timeVector' must be private and have accessor methods. 66
 Warning
design VisibilityModifier Variable 'demandVector' must be private and have accessor methods. 69
 Warning
design VisibilityModifier Variable 'factor' must be private and have accessor methods. 72
 Warning
design VisibilityModifier Variable 'factors' must be private and have accessor methods. 75
 Info
sizes LineLength Line is longer than 128 characters (found 141). 180
 Info
sizes LineLength Line is longer than 128 characters (found 130). 191

org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'network' must be private and have accessor methods. 71
 Warning
design VisibilityModifier Variable 'categorization' must be private and have accessor methods. 77
 Warning
design VisibilityModifier Variable 'categories' must be private and have accessor methods. 80
 Warning
design VisibilityModifier Variable 'globalTime' must be private and have accessor methods. 83
 Warning
design VisibilityModifier Variable 'globalInterpolation' must be private and have accessor methods. 86
 Warning
design VisibilityModifier Variable 'demand' must be private and have accessor methods. 89
 Info
sizes MethodLength Method length is 172 lines (max allowed is 150). 255
 Warning
modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 435

org/opentrafficsim/road/network/factory/xml/old/ConnectorTag.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'name' must be private and have accessor methods. 30
 Warning
design VisibilityModifier Variable 'nodeStartTag' must be private and have accessor methods. 33
 Warning
design VisibilityModifier Variable 'nodeEndTag' must be private and have accessor methods. 36
 Warning
design VisibilityModifier Variable 'demandWeight' must be private and have accessor methods. 39
 Warning
design VisibilityModifier Variable 'connector' must be private and have accessor methods. 42

org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java

Severity Category Rule Message Line
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 482
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 485
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 488

org/opentrafficsim/road/network/factory/xml/old/GTUColorerTag.java

Severity Category Rule Message Line
 Warning
javadoc JavadocStyle First sentence should end with a period. 31
 Warning
design VisibilityModifier Variable 'defaultColorer' must be private and have accessor methods. 33
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 69
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 84
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 97

org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'gtuDirection' must be private and have accessor methods. 77

org/opentrafficsim/road/network/factory/xml/old/LinkTag.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'priority' must be private and have accessor methods. 127

org/opentrafficsim/road/network/factory/xml/old/Links.java

Severity Category Rule Message Line
 Warning
coding InnerAssignment Inner assignments should be avoided. 190
 Warning
coding InnerAssignment Inner assignments should be avoided. 194
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 255

org/opentrafficsim/road/network/factory/xml/old/PolyLineTag.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'coordinates' must be private and have accessor methods. 33

org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'xmlComments' must be private and have accessor methods. 153
 Info
sizes LineLength Line is longer than 128 characters (found 132). 270
 Warning
blocks EmptyBlock Must have at least one statement. 361
 Info
sizes MethodLength Method length is 162 lines (max allowed is 150). 407

org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java

Severity Category Rule Message Line
 Warning
misc FinalParameters Parameter streamMap should be final. 63
 Warning
misc FinalParameters Parameter linkTypeSpeedLimitMap should be final. 64
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 108
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 152
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 213
 Warning
misc FinalParameters Parameter gtuTemplates should be final. 229
 Warning
misc FinalParameters Parameter streamMap should be final. 229

org/opentrafficsim/road/network/factory/xml/parser/GeneratorSinkParser.java

Severity Category Rule Message Line
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 138
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 332
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 347

org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java

Severity Category Rule Message Line
 Warning
design FinalClass Class ModelParser should be declared as final. 149
 Info
sizes MethodLength Method length is 165 lines (max allowed is 150). 170
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 397
 Info
sizes MethodLength Method length is 199 lines (max allowed is 150). 474
 Info
sizes MethodLength Method length is 240 lines (max allowed is 150). 895
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 1086

org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java

Severity Category Rule Message Line
 Warning
imports UnusedImports Unused import - org.djutils.logger.CategoryLogger. 18
 Warning
imports UnusedImports Unused import - org.opentrafficsim.base.logger.Cat. 20
 Info
sizes MethodLength Method length is 155 lines (max allowed is 150). 158
 Warning
blocks EmptyBlock Must have at least one statement. 288
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 291
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 302
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 410
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 477

org/opentrafficsim/road/network/factory/xml/parser/ODParser.java

Severity Category Rule Message Line
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 151
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 165
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 325
 Info
sizes LineLength Line is longer than 128 characters (found 136). 375
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 443
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 491

org/opentrafficsim/road/network/factory/xml/parser/RunParser.java

Severity Category Rule Message Line
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 102

org/opentrafficsim/road/network/factory/xml/parser/ScenarioParser.java

Severity Category Rule Message Line
 Warning
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 22
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 34

org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java

Severity Category Rule Message Line
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 250

org/opentrafficsim/road/network/factory/xml/utils/Cloner.java

Severity Category Rule Message Line
 Warning
misc FinalParameters Parameter object should be final. 41
 Warning
misc FinalParameters Parameter in should be final. 63

org/opentrafficsim/road/network/factory/xml/utils/ParseDistribution.java

Severity Category Rule Message Line
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 154

org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java

Severity Category Rule Message Line
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 38

org/opentrafficsim/road/network/factory/xml/utils/Transformer.java

Severity Category Rule Message Line
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 45
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 47