PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 3

org/opentrafficsim/road/network/factory/xml/demand/XMLParser.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 4346

org/opentrafficsim/road/network/factory/xml/old/FillTag.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'gtuClass'. 217
UnusedLocalVariable Avoid unused local variables such as 'rg'. 223

org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'generator'. 362

org/opentrafficsim/road/network/factory/xml/old/Links.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'overtakingConditions'. 355
CollapsibleIfStatements These nested if statements could be combined 376379
CollapsibleIfStatements These nested if statements could be combined 496497
CollapsibleIfStatements These nested if statements could be combined 520521

org/opentrafficsim/road/network/factory/xml/old/XMLParser.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 4346

org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 361363
UnusedPrivateMethod Avoid unused private methods such as 'fixOD(OTSRoadNetwork)'. 407

org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'getParameterType(String,Class)'. 411
UnusedPrivateMethod Avoid unused private methods such as 'getParameterTypeNumeric(String,Class)'. 436

org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 288292
CollapsibleIfStatements These nested if statements could be combined 374378
UnusedLocalVariable Avoid unused local variables such as 'direction'. 408

org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'generators'. 243
UnusedLocalVariable Avoid unused local variables such as 'generators'. 283
UnusedLocalVariable Avoid unused local variables such as 'modelParameters'. 317
UnusedLocalVariable Avoid unused local variables such as 'scenario'. 318
UnusedLocalVariable Avoid unused local variables such as 'animation'. 319

org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'seedMap'. 22

Priority 4

org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 376
UselessParentheses Useless parentheses. 379

org/opentrafficsim/road/network/factory/xml/old/ArcTag.java

Rule Violation Line
UselessParentheses Useless parentheses. 87

org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java

Rule Violation Line
UselessParentheses Useless parentheses. 491
UselessParentheses Useless parentheses. 492

org/opentrafficsim/road/network/factory/xml/old/Links.java

Rule Violation Line
UselessParentheses Useless parentheses. 191
UselessParentheses Useless parentheses. 199
UselessParentheses Useless parentheses. 204
UselessParentheses Useless parentheses. 207

org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java

Rule Violation Line
UselessParentheses Useless parentheses. 467

org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 88
UselessParentheses Useless parentheses. 89
UselessParentheses Useless parentheses. 132
UselessParentheses Useless parentheses. 133
UselessParentheses Useless parentheses. 181
UselessParentheses Useless parentheses. 182

org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.djutils.logger.CategoryLogger' 18
UnusedImports Avoid unused imports such as 'org.opentrafficsim.base.logger.Cat' 20
UselessParentheses Useless parentheses. 221
UselessParentheses Useless parentheses. 229
UselessParentheses Useless parentheses. 234
UselessParentheses Useless parentheses. 243

org/opentrafficsim/road/network/factory/xml/parser/ODParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 209
UselessParentheses Useless parentheses. 210
UselessParentheses Useless parentheses. 213
UselessParentheses Useless parentheses. 214
UselessParentheses Useless parentheses. 217
UselessParentheses Useless parentheses. 218
UselessParentheses Useless parentheses. 319320
UselessParentheses Useless parentheses. 327
UselessParentheses Useless parentheses. 438

Files

org/opentrafficsim/road/network/factory/xml/demand/XMLParser.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 4346

org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 376
UselessParentheses Useless parentheses. 4 379

org/opentrafficsim/road/network/factory/xml/old/ArcTag.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 87

org/opentrafficsim/road/network/factory/xml/old/CrossSectionElementTag.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 491
UselessParentheses Useless parentheses. 4 492

org/opentrafficsim/road/network/factory/xml/old/FillTag.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'gtuClass'. 3 217
UnusedLocalVariable Avoid unused local variables such as 'rg'. 3 223

org/opentrafficsim/road/network/factory/xml/old/GeneratorTag.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'generator'. 3 362

org/opentrafficsim/road/network/factory/xml/old/Links.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 191
UselessParentheses Useless parentheses. 4 199
UselessParentheses Useless parentheses. 4 204
UselessParentheses Useless parentheses. 4 207
UnusedLocalVariable Avoid unused local variables such as 'overtakingConditions'. 3 355
CollapsibleIfStatements These nested if statements could be combined 3 376379
CollapsibleIfStatements These nested if statements could be combined 3 496497
CollapsibleIfStatements These nested if statements could be combined 3 520521

org/opentrafficsim/road/network/factory/xml/old/XMLParser.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 4346

org/opentrafficsim/road/network/factory/xml/old/XmlNetworkLaneParserOld.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 361363
UnusedPrivateMethod Avoid unused private methods such as 'fixOD(OTSRoadNetwork)'. 3 407
UselessParentheses Useless parentheses. 4 467

org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 88
UselessParentheses Useless parentheses. 4 89
UselessParentheses Useless parentheses. 4 132
UselessParentheses Useless parentheses. 4 133
UselessParentheses Useless parentheses. 4 181
UselessParentheses Useless parentheses. 4 182

org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'getParameterType(String,Class)'. 3 411
UnusedPrivateMethod Avoid unused private methods such as 'getParameterTypeNumeric(String,Class)'. 3 436

org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.djutils.logger.CategoryLogger' 4 18
UnusedImports Avoid unused imports such as 'org.opentrafficsim.base.logger.Cat' 4 20
UselessParentheses Useless parentheses. 4 221
UselessParentheses Useless parentheses. 4 229
UselessParentheses Useless parentheses. 4 234
UselessParentheses Useless parentheses. 4 243
EmptyIfStmt Avoid empty if statements 3 288292
CollapsibleIfStatements These nested if statements could be combined 3 374378
UnusedLocalVariable Avoid unused local variables such as 'direction'. 3 408

org/opentrafficsim/road/network/factory/xml/parser/ODParser.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 209
UselessParentheses Useless parentheses. 4 210
UselessParentheses Useless parentheses. 4 213
UselessParentheses Useless parentheses. 4 214
UselessParentheses Useless parentheses. 4 217
UselessParentheses Useless parentheses. 4 218
UselessParentheses Useless parentheses. 4 319320
UselessParentheses Useless parentheses. 4 327
UselessParentheses Useless parentheses. 4 438

org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'generators'. 3 243
UnusedLocalVariable Avoid unused local variables such as 'generators'. 3 283
UnusedLocalVariable Avoid unused local variables such as 'modelParameters'. 3 317
UnusedLocalVariable Avoid unused local variables such as 'scenario'. 3 318
UnusedLocalVariable Avoid unused local variables such as 'animation'. 3 319

org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'seedMap'. 3 22