PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 2

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 325

Priority 3

loadfromxml/LoadXML.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 198201

org/opentrafficsim/ahfe/AHFEAnimation.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 86

org/opentrafficsim/ahfe/AHFEUtil.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'generationSpeed'. 354
UnusedFormalParameter Avoid unused method parameters such as 'gtuColorer'. 357
UnusedFormalParameter Avoid unused method parameters such as 'bcFactory'. 357
UnusedFormalParameter Avoid unused method parameters such as 'simulationTime'. 358
UnusedFormalParameter Avoid unused method parameters such as 'tacticalFactory'. 358

org/opentrafficsim/ahfe/DelayedNeighborsPerception.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'perc'. 271
EmptyCatchBlock Avoid empty catch blocks 314317
EmptyCatchBlock Avoid empty catch blocks 351354
UnusedFormalParameter Avoid unused method parameters such as 'egoSpeed'. 423

org/opentrafficsim/demo/CircularLaneSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 60

org/opentrafficsim/demo/CircularRoadSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 68

org/opentrafficsim/demo/CrossingTrafficLightsSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 43

org/opentrafficsim/demo/FundamentalDiagrams.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 92

org/opentrafficsim/demo/NetworksSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 68

org/opentrafficsim/demo/RampMeteringDemo.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'part'. 230
UnusedLocalVariable Avoid unused local variables such as 'lanesBC'. 283
UnusedLocalVariable Avoid unused local variables such as 'lanesFB'. 290

org/opentrafficsim/demo/SequentialLanes.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 100

org/opentrafficsim/demo/ShortMerge.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 154
EmptyIfStmt Avoid empty if statements 293295
UnusedFormalParameter Avoid unused method parameters such as 'generationSpeed'. 440
UnusedFormalParameter Avoid unused method parameters such as 'gtuColorer'. 442
UnusedFormalParameter Avoid unused method parameters such as 'bcFactory'. 442
UnusedFormalParameter Avoid unused method parameters such as 'simulationTime'. 443
UnusedFormalParameter Avoid unused method parameters such as 'tacticalFactory'. 443

org/opentrafficsim/demo/StraightSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 61

org/opentrafficsim/demo/conflictAndControl/DemoTrafcodAndTurbo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 75

org/opentrafficsim/demo/conflict/BusStreetDemo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 111

org/opentrafficsim/demo/conflict/TJunctionDemo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 59
EmptyStatementBlock Avoid empty block statements. 185187

org/opentrafficsim/demo/conflict/TestNetworkDemo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 55

org/opentrafficsim/demo/conflict/TurboRoundaboutDemo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 58
EmptyStatementBlock Avoid empty block statements. 200202

org/opentrafficsim/demo/geometry/TestModel.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 199202

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'line'. 223
UnusedLocalVariable Avoid unused local variables such as 'length'. 230
UnusedLocalVariable Avoid unused local variables such as 'linkTag'. 235
UnusedLocalVariable Avoid unused local variables such as 'wegtype'. 236
UnusedLocalVariable Avoid unused local variables such as 'typeWeg'. 238
UnusedLocalVariable Avoid unused local variables such as 'speed'. 240
UnusedLocalVariable Avoid unused local variables such as 'capacity'. 242
UnusedLocalVariable Avoid unused local variables such as 'dir'. 440
EmptyCatchBlock Avoid empty catch blocks 474477
UnusedLocalVariable Avoid unused local variables such as 'dir'. 506
EmptyCatchBlock Avoid empty catch blocks 542545

org/opentrafficsim/demo/lanechange/LaneChangeGraph.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'speed'. 418

org/opentrafficsim/demo/network/xml/Grid10X10.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'defaultAnimationFactory'. 212

org/opentrafficsim/demo/network/xml/N201ODfactory.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'colorer'. 155

org/opentrafficsim/demo/network/xml/TestXMLParserAmsterdam.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'defaultAnimationFactory'. 74

org/opentrafficsim/demo/sdm/SdmSimulation.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 471
UselessQualifiedThis Useless qualified this usage in the same class. 475
UselessQualifiedThis Useless qualified this usage in the same class. 480
UselessQualifiedThis Useless qualified this usage in the same class. 480

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo1.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 76
UnusedFormalParameter Avoid unused constructor parameters such as 'shortName'. 171
UnusedFormalParameter Avoid unused constructor parameters such as 'description'. 171

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 70

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2_Generators.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 59

org/opentrafficsim/demo/web/OTSDemoServer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 193196
EmptyCatchBlock Avoid empty catch blocks 202205
CollapsibleIfStatements These nested if statements could be combined 264268
EmptyIfStmt Avoid empty if statements 590592
EmptyIfStmt Avoid empty if statements 594596
EmptyIfStmt Avoid empty if statements 598600
EmptyIfStmt Avoid empty if statements 602604

org/opentrafficsim/demo/web/OTSFederatedDemoServer.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 470472
EmptyIfStmt Avoid empty if statements 474476
EmptyIfStmt Avoid empty if statements 478480
EmptyIfStmt Avoid empty if statements 482484

org/opentrafficsim/demo/web/SimpleLoadBalancer.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'lbSocket'. 45
UnusedPrivateField Avoid unused private fields such as 'lbContext'. 48
UnusedPrivateField Avoid unused private fields such as 'messageCount'. 51

org/opentrafficsim/demo/web/SuperDemoWebApplication.java

Rule Violation Line
EmptyTryBlock Avoid empty try blocks 363389
EmptyTryBlock Avoid empty try blocks 458481

strategies/LmrsStrategies.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 983
UselessQualifiedThis Useless qualified this usage in the same class. 985
UselessQualifiedThis Useless qualified this usage in the same class. 989
UselessQualifiedThis Useless qualified this usage in the same class. 1018
UselessQualifiedThis Useless qualified this usage in the same class. 1020
UselessQualifiedThis Useless qualified this usage in the same class. 1020
UselessQualifiedThis Useless qualified this usage in the same class. 1023
UselessQualifiedThis Useless qualified this usage in the same class. 1023

strategies/StrategiesDemo.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 345

Priority 4

org/opentrafficsim/demo/RampMeteringDemo.java

Rule Violation Line
UselessParentheses Useless parentheses. 639
UselessParentheses Useless parentheses. 640

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 441
UselessParentheses Useless parentheses. 507

org/opentrafficsim/demo/network/xml/TestXMLParserAmsterdam.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.djunits.unit.LengthUnit' 15
UnusedImports Avoid unused imports such as 'org.djunits.value.vdouble.scalar.Length' 17
UnusedImports Avoid unused imports such as 'org.opentrafficsim.core.gtu.GTUType' 26
UnusedImports Avoid unused imports such as 'org.opentrafficsim.road.network.lane.conflict.ConflictBuilder' 35

org/opentrafficsim/demo/steering/SteeringSimulation.java

Rule Violation Line
UselessParentheses Useless parentheses. 177

strategies/LmrsStrategies.java

Rule Violation Line
UselessParentheses Useless parentheses. 367

Files

loadfromxml/LoadXML.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 198201

org/opentrafficsim/ahfe/AHFEAnimation.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 86

org/opentrafficsim/ahfe/AHFEUtil.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'generationSpeed'. 3 354
UnusedFormalParameter Avoid unused method parameters such as 'gtuColorer'. 3 357
UnusedFormalParameter Avoid unused method parameters such as 'bcFactory'. 3 357
UnusedFormalParameter Avoid unused method parameters such as 'simulationTime'. 3 358
UnusedFormalParameter Avoid unused method parameters such as 'tacticalFactory'. 3 358

org/opentrafficsim/ahfe/DelayedNeighborsPerception.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'perc'. 3 271
EmptyCatchBlock Avoid empty catch blocks 3 314317
EmptyCatchBlock Avoid empty catch blocks 3 351354
UnusedFormalParameter Avoid unused method parameters such as 'egoSpeed'. 3 423

org/opentrafficsim/demo/CircularLaneSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 60

org/opentrafficsim/demo/CircularRoadSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 68

org/opentrafficsim/demo/CrossingTrafficLightsSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 43

org/opentrafficsim/demo/FundamentalDiagrams.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 92

org/opentrafficsim/demo/NetworksSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 68

org/opentrafficsim/demo/RampMeteringDemo.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'part'. 3 230
UnusedLocalVariable Avoid unused local variables such as 'lanesBC'. 3 283
UnusedLocalVariable Avoid unused local variables such as 'lanesFB'. 3 290
UselessParentheses Useless parentheses. 4 639
UselessParentheses Useless parentheses. 4 640

org/opentrafficsim/demo/SequentialLanes.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 100

org/opentrafficsim/demo/ShortMerge.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 154
EmptyIfStmt Avoid empty if statements 3 293295
UnusedFormalParameter Avoid unused method parameters such as 'generationSpeed'. 3 440
UnusedFormalParameter Avoid unused method parameters such as 'gtuColorer'. 3 442
UnusedFormalParameter Avoid unused method parameters such as 'bcFactory'. 3 442
UnusedFormalParameter Avoid unused method parameters such as 'simulationTime'. 3 443
UnusedFormalParameter Avoid unused method parameters such as 'tacticalFactory'. 3 443

org/opentrafficsim/demo/StraightSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 61

org/opentrafficsim/demo/conflictAndControl/DemoTrafcodAndTurbo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 75

org/opentrafficsim/demo/conflict/BusStreetDemo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 111

org/opentrafficsim/demo/conflict/TJunctionDemo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 59
EmptyStatementBlock Avoid empty block statements. 3 185187

org/opentrafficsim/demo/conflict/TestNetworkDemo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 55

org/opentrafficsim/demo/conflict/TurboRoundaboutDemo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 58
EmptyStatementBlock Avoid empty block statements. 3 200202

org/opentrafficsim/demo/geometry/TestModel.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 199202

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'line'. 3 223
UnusedLocalVariable Avoid unused local variables such as 'length'. 3 230
UnusedLocalVariable Avoid unused local variables such as 'linkTag'. 3 235
UnusedLocalVariable Avoid unused local variables such as 'wegtype'. 3 236
UnusedLocalVariable Avoid unused local variables such as 'typeWeg'. 3 238
UnusedLocalVariable Avoid unused local variables such as 'speed'. 3 240
UnusedLocalVariable Avoid unused local variables such as 'capacity'. 3 242
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 325
UnusedLocalVariable Avoid unused local variables such as 'dir'. 3 440
UselessParentheses Useless parentheses. 4 441
EmptyCatchBlock Avoid empty catch blocks 3 474477
UnusedLocalVariable Avoid unused local variables such as 'dir'. 3 506
UselessParentheses Useless parentheses. 4 507
EmptyCatchBlock Avoid empty catch blocks 3 542545

org/opentrafficsim/demo/lanechange/LaneChangeGraph.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'speed'. 3 418

org/opentrafficsim/demo/network/xml/Grid10X10.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'defaultAnimationFactory'. 3 212

org/opentrafficsim/demo/network/xml/N201ODfactory.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'colorer'. 3 155

org/opentrafficsim/demo/network/xml/TestXMLParserAmsterdam.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.djunits.unit.LengthUnit' 4 15
UnusedImports Avoid unused imports such as 'org.djunits.value.vdouble.scalar.Length' 4 17
UnusedImports Avoid unused imports such as 'org.opentrafficsim.core.gtu.GTUType' 4 26
UnusedImports Avoid unused imports such as 'org.opentrafficsim.road.network.lane.conflict.ConflictBuilder' 4 35
UnusedPrivateField Avoid unused private fields such as 'defaultAnimationFactory'. 3 74

org/opentrafficsim/demo/sdm/SdmSimulation.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 471
UselessQualifiedThis Useless qualified this usage in the same class. 3 475
UselessQualifiedThis Useless qualified this usage in the same class. 3 480
UselessQualifiedThis Useless qualified this usage in the same class. 3 480

org/opentrafficsim/demo/steering/SteeringSimulation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 177

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo1.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 76
UnusedFormalParameter Avoid unused constructor parameters such as 'shortName'. 3 171
UnusedFormalParameter Avoid unused constructor parameters such as 'description'. 3 171

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 70

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2_Generators.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 59

org/opentrafficsim/demo/web/OTSDemoServer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 193196
EmptyCatchBlock Avoid empty catch blocks 3 202205
CollapsibleIfStatements These nested if statements could be combined 3 264268
EmptyIfStmt Avoid empty if statements 3 590592
EmptyIfStmt Avoid empty if statements 3 594596
EmptyIfStmt Avoid empty if statements 3 598600
EmptyIfStmt Avoid empty if statements 3 602604

org/opentrafficsim/demo/web/OTSFederatedDemoServer.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 470472
EmptyIfStmt Avoid empty if statements 3 474476
EmptyIfStmt Avoid empty if statements 3 478480
EmptyIfStmt Avoid empty if statements 3 482484

org/opentrafficsim/demo/web/SimpleLoadBalancer.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'lbSocket'. 3 45
UnusedPrivateField Avoid unused private fields such as 'lbContext'. 3 48
UnusedPrivateField Avoid unused private fields such as 'messageCount'. 3 51

org/opentrafficsim/demo/web/SuperDemoWebApplication.java

Rule Violation Priority Line
EmptyTryBlock Avoid empty try blocks 3 363389
EmptyTryBlock Avoid empty try blocks 3 458481

strategies/LmrsStrategies.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 367
UselessQualifiedThis Useless qualified this usage in the same class. 3 983
UselessQualifiedThis Useless qualified this usage in the same class. 3 985
UselessQualifiedThis Useless qualified this usage in the same class. 3 989
UselessQualifiedThis Useless qualified this usage in the same class. 3 1018
UselessQualifiedThis Useless qualified this usage in the same class. 3 1020
UselessQualifiedThis Useless qualified this usage in the same class. 3 1020
UselessQualifiedThis Useless qualified this usage in the same class. 3 1023
UselessQualifiedThis Useless qualified this usage in the same class. 3 1023

strategies/StrategiesDemo.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 345