PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 2

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Rule Violation Line
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 1462
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 1471

Priority 3

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 358378
CollapsibleIfStatements These nested if statements could be combined 418438

org/opentrafficsim/road/gtu/generator/CFRoomChecker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 5457

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 300303
UnnecessaryModifier Unnecessary modifier 'public' on class 'ByValue': members of interface types are implicitly public 10321092
UnnecessaryModifier Unnecessary modifier 'public' on class 'BySpeed': members of interface types are implicitly public 11061191

org/opentrafficsim/road/gtu/generator/od/StrategicalPlannerFactorySupplierOD.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'TacticalPlannerFactorySupplierOD': members of interface types are implicitly public 106118

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 15701573
EmptyCatchBlock Avoid empty catch blocks 15861589

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU2.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 12461249

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedIndividualGTU.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 96

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 125
UselessQualifiedThis Useless qualified this usage in the same class. 127
UselessQualifiedThis Useless qualified this usage in the same class. 128
UselessQualifiedThis Useless qualified this usage in the same class. 132
UselessQualifiedThis Useless qualified this usage in the same class. 133
UselessQualifiedThis Useless qualified this usage in the same class. 316

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 120124

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionCollector': members of interface types are implicitly public 7695
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionAccumulator': members of interface types are implicitly public 111121
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionFinalizer': members of interface types are implicitly public 137145

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 344350

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 749752
CollapsibleIfStatements These nested if statements could be combined 883900

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'context'. 126

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 3740

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'planDistance'. 711
UnusedFormalParameter Avoid unused method parameters such as 'from'. 712
UnusedFormalParameter Avoid unused method parameters such as 'width'. 712
UnusedFormalParameter Avoid unused method parameters such as 'startPosition'. 712
UnusedFormalParameter Avoid unused method parameters such as 'toLine'. 713
UnusedFormalParameter Avoid unused method parameters such as 'fromLine'. 713
UnusedLocalVariable Avoid unused local variables such as 'f'. 725
UnusedLocalVariable Avoid unused local variables such as 'cumulLcLength'. 729

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'startSpeed'. 470

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'currentLaneFine'. 151

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 238245
UnusedFormalParameter Avoid unused method parameters such as 'lanePathInfo'. 508
UnusedFormalParameter Avoid unused method parameters such as 'perception'. 508

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 7584

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'gtu'. 716

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 188200
CollapsibleIfStatements These nested if statements could be combined 498514

org/opentrafficsim/road/gtu/lane/tactical/util/Steering.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'speed'. 94
UnusedLocalVariable Avoid unused local variables such as 'realPlan'. 128

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'b'. 85
SimplifiedTernary Ternary operators that can be simplified with || or && 93

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 110

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 186203
UnusedPrivateMethod Avoid unused private methods such as 'quickIntersectionScan(Parameters,SpeedLimitInfo,CarFollowingModel,Speed,LateralDirectionality,IntersectionPerception)'. 593595

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 1836
SimplifiedTernary Ternary operators that can be simplified with || or && 397398
SimplifiedTernary Ternary operators that can be simplified with || or && 414415
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type 499511

org/opentrafficsim/road/network/factory/LaneFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'simulator'. 388

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'newSimulator'. 355

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 534538
CollapsibleIfStatements These nested if statements could be combined 574578

org/opentrafficsim/road/network/lane/LaneType.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inverted'. 144

org/opentrafficsim/road/network/lane/NoTrafficLane.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'directionalityNone(RoadNetwork)'. 35

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 417437
CollapsibleIfStatements These nested if statements could be combined 846865

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 289292

org/opentrafficsim/road/network/lane/object/BusStop.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 62

org/opentrafficsim/road/network/lane/object/Distraction.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 41

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 62

Priority 4

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Line
UselessParentheses Useless parentheses. 289
UselessParentheses Useless parentheses. 289
UselessParentheses Useless parentheses. 290
UselessParentheses Useless parentheses. 290

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Line
UselessParentheses Useless parentheses. 926
UselessParentheses Useless parentheses. 1135

org/opentrafficsim/road/gtu/generator/od/ODApplier.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'nl.tudelft.simulation.dsol.logger.SimLogger' 55
UselessParentheses Useless parentheses. 301

org/opentrafficsim/road/gtu/lane/VehicleModel.java

Rule Violation Line
UselessParentheses Useless parentheses. 44

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Line
UselessParentheses Useless parentheses. 102

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructure.java

Rule Violation Line
UselessParentheses Useless parentheses. 481
UselessParentheses Useless parentheses. 13331334
UselessParentheses Useless parentheses. 13341335
UselessParentheses Useless parentheses. 14201421
UselessParentheses Useless parentheses. 14211422
UselessParentheses Useless parentheses. 15031504
UselessParentheses Useless parentheses. 1504
UselessParentheses Useless parentheses. 15321533
UselessParentheses Useless parentheses. 1533

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Line
UselessParentheses Useless parentheses. 344345
UselessParentheses Useless parentheses. 346347

org/opentrafficsim/road/gtu/lane/perception/UpstreamNeighborsIterable.java

Rule Violation Line
UselessParentheses Useless parentheses. 75

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 952
UselessParentheses Useless parentheses. 952
UselessParentheses Useless parentheses. 953
UselessParentheses Useless parentheses. 953

org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 412
UselessParentheses Useless parentheses. 412
UselessParentheses Useless parentheses. 427
UselessParentheses Useless parentheses. 427
UselessParentheses Useless parentheses. 440
UselessParentheses Useless parentheses. 440
UselessParentheses Useless parentheses. 444
UselessParentheses Useless parentheses. 444
UselessParentheses Useless parentheses. 455
UselessParentheses Useless parentheses. 455
UselessParentheses Useless parentheses. 654
UselessParentheses Useless parentheses. 655

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 273274
UselessParentheses Useless parentheses. 275276

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java

Rule Violation Line
UselessParentheses Useless parentheses. 211

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Rule Violation Line
UselessParentheses Useless parentheses. 81

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Rule Violation Line
UselessParentheses Useless parentheses. 46

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Rule Violation Line
UselessParentheses Useless parentheses. 88

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Rule Violation Line
UselessParentheses Useless parentheses. 41

org/opentrafficsim/road/gtu/lane/perception/mental/Fuller.java

Rule Violation Line
UselessParentheses Useless parentheses. 180

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Rule Violation Line
UselessParentheses Useless parentheses. 56

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Line
UselessParentheses Useless parentheses. 640
UselessParentheses Useless parentheses. 826

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 410

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 236
UselessParentheses Useless parentheses. 266
UselessParentheses Useless parentheses. 629

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveGetInLane.java

Rule Violation Line
UselessParentheses Useless parentheses. 90

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Line
UselessParentheses Useless parentheses. 162
UselessParentheses Useless parentheses. 163164

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Line
UselessParentheses Useless parentheses. 849850

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Line
UselessParentheses Useless parentheses. 43
UselessParentheses Useless parentheses. 44
UselessParentheses Useless parentheses. 79
UselessParentheses Useless parentheses. 80
UselessParentheses Useless parentheses. 124
UselessParentheses Useless parentheses. 125

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Line
UselessParentheses Useless parentheses. 350
UselessParentheses Useless parentheses. 401402
UselessParentheses Useless parentheses. 426
UselessParentheses Useless parentheses. 736
UselessParentheses Useless parentheses. 736

org/opentrafficsim/road/gtu/strategical/od/SplitFraction.java

Rule Violation Line
UselessParentheses Useless parentheses. 199
UselessParentheses Useless parentheses. 200

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 222
UselessParentheses Useless parentheses. 223
UselessParentheses Useless parentheses. 238239
UselessParentheses Useless parentheses. 240241

org/opentrafficsim/road/network/control/rampmetering/AlineaSwitch.java

Rule Violation Line
UselessParentheses Useless parentheses. 60

org/opentrafficsim/road/network/control/rampmetering/RwsSwitch.java

Rule Violation Line
UselessParentheses Useless parentheses. 63

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Line
UselessParentheses Useless parentheses. 271
UselessParentheses Useless parentheses. 272
UselessParentheses Useless parentheses. 272

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Line
UselessParentheses Useless parentheses. 529530
UselessParentheses Useless parentheses. 531532
UselessParentheses Useless parentheses. 569570
UselessParentheses Useless parentheses. 571572
UselessParentheses Useless parentheses. 1508
UselessParentheses Useless parentheses. 1509
UselessParentheses Useless parentheses. 1537
UselessParentheses Useless parentheses. 1538

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Line
UselessParentheses Useless parentheses. 187
UselessParentheses Useless parentheses. 188

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 464
UselessParentheses Useless parentheses. 465
UselessParentheses Useless parentheses. 614
UselessParentheses Useless parentheses. 614
UselessParentheses Useless parentheses. 622
UselessParentheses Useless parentheses. 622

org/opentrafficsim/road/network/lane/conflict/ConflictBuilderParallel.java

Rule Violation Line
UselessParentheses Useless parentheses. 726
UselessParentheses Useless parentheses. 727
UselessParentheses Useless parentheses. 876
UselessParentheses Useless parentheses. 876
UselessParentheses Useless parentheses. 884
UselessParentheses Useless parentheses. 884

org/opentrafficsim/road/network/lane/conflict/DefaultConflictRule.java

Rule Violation Line
UselessParentheses Useless parentheses. 111
UselessParentheses Useless parentheses. 112

Files

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 289
UselessParentheses Useless parentheses. 4 289
UselessParentheses Useless parentheses. 4 290
UselessParentheses Useless parentheses. 4 290
CollapsibleIfStatements These nested if statements could be combined 3 358378
CollapsibleIfStatements These nested if statements could be combined 3 418438

org/opentrafficsim/road/gtu/generator/CFRoomChecker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 5457

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 300303
UselessParentheses Useless parentheses. 4 926
UnnecessaryModifier Unnecessary modifier 'public' on class 'ByValue': members of interface types are implicitly public 3 10321092
UnnecessaryModifier Unnecessary modifier 'public' on class 'BySpeed': members of interface types are implicitly public 3 11061191
UselessParentheses Useless parentheses. 4 1135

org/opentrafficsim/road/gtu/generator/od/ODApplier.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'nl.tudelft.simulation.dsol.logger.SimLogger' 4 55
UselessParentheses Useless parentheses. 4 301

org/opentrafficsim/road/gtu/generator/od/StrategicalPlannerFactorySupplierOD.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'TacticalPlannerFactorySupplierOD': members of interface types are implicitly public 3 106118

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Rule Violation Priority Line
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 1462
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 1471
EmptyCatchBlock Avoid empty catch blocks 3 15701573
EmptyCatchBlock Avoid empty catch blocks 3 15861589

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU2.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 12461249

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedIndividualGTU.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 96

org/opentrafficsim/road/gtu/lane/VehicleModel.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 44

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 125
UselessQualifiedThis Useless qualified this usage in the same class. 3 127
UselessQualifiedThis Useless qualified this usage in the same class. 3 128
UselessQualifiedThis Useless qualified this usage in the same class. 3 132
UselessQualifiedThis Useless qualified this usage in the same class. 3 133
UselessQualifiedThis Useless qualified this usage in the same class. 3 316

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 102
CollapsibleIfStatements These nested if statements could be combined 3 120124

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionCollector': members of interface types are implicitly public 3 7695
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionAccumulator': members of interface types are implicitly public 3 111121
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionFinalizer': members of interface types are implicitly public 3 137145

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructure.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 481
UselessParentheses Useless parentheses. 4 13331334
UselessParentheses Useless parentheses. 4 13341335
UselessParentheses Useless parentheses. 4 14201421
UselessParentheses Useless parentheses. 4 14211422
UselessParentheses Useless parentheses. 4 15031504
UselessParentheses Useless parentheses. 4 1504
UselessParentheses Useless parentheses. 4 15321533
UselessParentheses Useless parentheses. 4 1533

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 344345
CollapsibleIfStatements These nested if statements could be combined 3 344350
UselessParentheses Useless parentheses. 4 346347

org/opentrafficsim/road/gtu/lane/perception/UpstreamNeighborsIterable.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 75

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 749752
CollapsibleIfStatements These nested if statements could be combined 3 883900
UselessParentheses Useless parentheses. 4 952
UselessParentheses Useless parentheses. 4 952
UselessParentheses Useless parentheses. 4 953
UselessParentheses Useless parentheses. 4 953

org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 412
UselessParentheses Useless parentheses. 4 412
UselessParentheses Useless parentheses. 4 427
UselessParentheses Useless parentheses. 4 427
UselessParentheses Useless parentheses. 4 440
UselessParentheses Useless parentheses. 4 440
UselessParentheses Useless parentheses. 4 444
UselessParentheses Useless parentheses. 4 444
UselessParentheses Useless parentheses. 4 455
UselessParentheses Useless parentheses. 4 455
UselessParentheses Useless parentheses. 4 654
UselessParentheses Useless parentheses. 4 655

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'context'. 3 126

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 273274
UselessParentheses Useless parentheses. 4 275276

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 211

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 81

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 3740

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 46

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 88

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 41

org/opentrafficsim/road/gtu/lane/perception/mental/Fuller.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 180

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 56

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 640
UnusedFormalParameter Avoid unused method parameters such as 'planDistance'. 3 711
UnusedFormalParameter Avoid unused method parameters such as 'from'. 3 712
UnusedFormalParameter Avoid unused method parameters such as 'width'. 3 712
UnusedFormalParameter Avoid unused method parameters such as 'startPosition'. 3 712
UnusedFormalParameter Avoid unused method parameters such as 'toLine'. 3 713
UnusedFormalParameter Avoid unused method parameters such as 'fromLine'. 3 713
UnusedLocalVariable Avoid unused local variables such as 'f'. 3 725
UnusedLocalVariable Avoid unused local variables such as 'cumulLcLength'. 3 729
UselessParentheses Useless parentheses. 4 826

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 410
UnusedFormalParameter Avoid unused method parameters such as 'startSpeed'. 3 470

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'currentLaneFine'. 3 151

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 236
CollapsibleIfStatements These nested if statements could be combined 3 238245
UselessParentheses Useless parentheses. 4 266
UnusedFormalParameter Avoid unused method parameters such as 'lanePathInfo'. 3 508
UnusedFormalParameter Avoid unused method parameters such as 'perception'. 3 508
UselessParentheses Useless parentheses. 4 629

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 7584

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveGetInLane.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 90

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 162
UselessParentheses Useless parentheses. 4 163164
UnusedFormalParameter Avoid unused method parameters such as 'gtu'. 3 716

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 188200
CollapsibleIfStatements These nested if statements could be combined 3 498514
UselessParentheses Useless parentheses. 4 849850

org/opentrafficsim/road/gtu/lane/tactical/util/Steering.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'speed'. 3 94
UnusedLocalVariable Avoid unused local variables such as 'realPlan'. 3 128

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 43
UselessParentheses Useless parentheses. 4 44
UselessParentheses Useless parentheses. 4 79
UselessParentheses Useless parentheses. 4 80
UnusedLocalVariable Avoid unused local variables such as 'b'. 3 85
SimplifiedTernary Ternary operators that can be simplified with || or && 3 93
UselessParentheses Useless parentheses. 4 124
UselessParentheses Useless parentheses. 4 125

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 110

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 186203
UnusedPrivateMethod Avoid unused private methods such as 'quickIntersectionScan(Parameters,SpeedLimitInfo,CarFollowingModel,Speed,LateralDirectionality,IntersectionPerception)'. 3 593595

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 1836
UselessParentheses Useless parentheses. 4 350
SimplifiedTernary Ternary operators that can be simplified with || or && 3 397398
UselessParentheses Useless parentheses. 4 401402
SimplifiedTernary Ternary operators that can be simplified with || or && 3 414415
UselessParentheses Useless parentheses. 4 426
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type 3 499511
UselessParentheses Useless parentheses. 4 736
UselessParentheses Useless parentheses. 4 736

org/opentrafficsim/road/gtu/strategical/od/SplitFraction.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 199
UselessParentheses Useless parentheses. 4 200

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 222
UselessParentheses Useless parentheses. 4 223
UselessParentheses Useless parentheses. 4 238239
UselessParentheses Useless parentheses. 4 240241

org/opentrafficsim/road/network/control/rampmetering/AlineaSwitch.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 60

org/opentrafficsim/road/network/control/rampmetering/RwsSwitch.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 63

org/opentrafficsim/road/network/factory/LaneFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'simulator'. 3 388

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 271
UselessParentheses Useless parentheses. 4 272
UselessParentheses Useless parentheses. 4 272
UnusedFormalParameter Avoid unused constructor parameters such as 'newSimulator'. 3 355

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 529530
UselessParentheses Useless parentheses. 4 531532
CollapsibleIfStatements These nested if statements could be combined 3 534538
UselessParentheses Useless parentheses. 4 569570
UselessParentheses Useless parentheses. 4 571572
CollapsibleIfStatements These nested if statements could be combined 3 574578
UselessParentheses Useless parentheses. 4 1508
UselessParentheses Useless parentheses. 4 1509
UselessParentheses Useless parentheses. 4 1537
UselessParentheses Useless parentheses. 4 1538

org/opentrafficsim/road/network/lane/LaneType.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inverted'. 3 144

org/opentrafficsim/road/network/lane/NoTrafficLane.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'directionalityNone(RoadNetwork)'. 3 35

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 187
UselessParentheses Useless parentheses. 4 188
CollapsibleIfStatements These nested if statements could be combined 3 417437
CollapsibleIfStatements These nested if statements could be combined 3 846865

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 289292
UselessParentheses Useless parentheses. 4 464
UselessParentheses Useless parentheses. 4 465
UselessParentheses Useless parentheses. 4 614
UselessParentheses Useless parentheses. 4 614
UselessParentheses Useless parentheses. 4 622
UselessParentheses Useless parentheses. 4 622

org/opentrafficsim/road/network/lane/conflict/ConflictBuilderParallel.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 726
UselessParentheses Useless parentheses. 4 727
UselessParentheses Useless parentheses. 4 876
UselessParentheses Useless parentheses. 4 876
UselessParentheses Useless parentheses. 4 884
UselessParentheses Useless parentheses. 4 884

org/opentrafficsim/road/network/lane/conflict/DefaultConflictRule.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 111
UselessParentheses Useless parentheses. 4 112

org/opentrafficsim/road/network/lane/object/BusStop.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 62

org/opentrafficsim/road/network/lane/object/Distraction.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 41

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 62