Checkstyle Results

The following document contains the results of Checkstyle 8.26 with development/dsol-checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
12 3 172 0

Files

File
 I
 W
 E
org/opentrafficsim/trafficcontrol/AbstractTrafficController.java 0 1 0
org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java 0 1 0
org/opentrafficsim/trafficcontrol/FixedTimeController.java 1 9 0
org/opentrafficsim/trafficcontrol/TrafficController.java 0 9 0
org/opentrafficsim/trafficcontrol/ccol/CCOL.java 0 10 0
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java 0 45 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java 2 59 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java 0 38 0

Rules

Category Rule Violations Severity
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 2
 Warning
InnerAssignment 1
 Warning
MissingSwitchDefault 2
 Warning
design DesignForExtension 1
 Warning
VisibilityModifier 31
 Warning
javadoc JavadocStyle
  • checkHtml: "false"
 5
 Warning
misc FinalParameters 63
 Warning
TodoComment 1
 Warning
modifier ModifierOrder 36
 Warning
RedundantModifier 22
 Warning
naming ConstantName 3
 Warning
StaticVariableName 3
 Warning
sizes FileLength 1
 Warning
MethodLength 3
 Info
whitespace WhitespaceAfter 1
 Warning

Details

org/opentrafficsim/trafficcontrol/AbstractTrafficController.java

Severity Category Rule Message Line
 Warning		 design VisibilityModifier Variable 'id' must be private and have accessor methods. 24

org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java

Severity Category Rule Message Line
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 21

org/opentrafficsim/trafficcontrol/FixedTimeController.java

Severity Category Rule Message Line
 Info		 sizes MethodLength Method length is 194 lines (max allowed is 150). 69
 Warning		 coding HiddenField 'simulator' hides a field. 457
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 477
 Warning		 misc FinalParameters Parameter obj should be final. 598
 Warning		 design VisibilityModifier Variable 'offset' must be private and have accessor methods. 709
 Warning		 design VisibilityModifier Variable 'newColor' must be private and have accessor methods. 712
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 719
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 750
 Warning		 naming ConstantName Name 'compareMargin' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 750
 Warning		 misc FinalParameters Parameter o should be final. 753

org/opentrafficsim/trafficcontrol/TrafficController.java

Severity Category Rule Message Line
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 28
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 31
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 34
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 37
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 40
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 43
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 46
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 46
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 78

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Severity Category Rule Message Line
 Warning		 design VisibilityModifier Variable 'id' must be private and have accessor methods. 50
 Warning		 design VisibilityModifier Variable 'simulator' must be private and have accessor methods. 53
 Warning		 naming StaticVariableName Name 'PORT' must match pattern '^[a-z][a-zA-Z0-9]*$'. 56
 Warning		 design VisibilityModifier Variable 'PORT' must be private and have accessor methods. 56
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 59
 Warning		 design VisibilityModifier Variable 'serverSocket' must be private and have accessor methods. 62
 Warning		 design VisibilityModifier Variable 'acceptThread' must be private and have accessor methods. 74
 Warning		 misc FinalParameters Parameter event should be final. 194
 Warning		 misc FinalParameters Parameter newSimulator should be final. 252
 Warning		 misc FinalParameters Parameter newNetwork should be final. 252

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Severity Category Rule Message Line
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 48
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 51
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 54
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 57
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 60
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 63
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 66
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 69
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 72
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 75
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 78
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 81
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 84
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 87
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 90
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 93
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 96
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 99
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 102
 Warning		 design VisibilityModifier Variable 'streams' must be private and have accessor methods. 105
 Warning		 design VisibilityModifier Variable 'routes' must be private and have accessor methods. 108
 Warning		 misc FinalParameters Parameter o1 should be final. 122
 Warning		 misc FinalParameters Parameter o2 should be final. 122
 Warning		 whitespace WhitespaceAfter ',' is not followed by whitespace. 141
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 278
 Warning		 javadoc JavadocStyle First sentence should end with a period. 310
 Warning		 coding MissingSwitchDefault switch without "default" clause. 333
 Warning		 coding MissingSwitchDefault switch without "default" clause. 355
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 398
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 401
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 404
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 407
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 414
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 430
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 451
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 468
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 540
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 550
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 561
 Warning		 javadoc JavadocStyle First sentence should end with a period. 628
 Warning		 misc FinalParameters Parameter steps should be final. 634
 Warning		 coding InnerAssignment Inner assignments should be avoided. 638
 Warning		 misc FinalParameters Parameter e should be final. 863
 Warning		 design VisibilityModifier Variable 'testPanel' must be private and have accessor methods. 872
 Warning		 design VisibilityModifier Variable 'checkBoxPanel' must be private and have accessor methods. 875

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Severity Category Rule Message Line
 Warning		 sizes FileLength File length is 2,846 lines (max allowed is 2,000). 1
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 66
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 69
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 72
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 75
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 78
 Warning		 design VisibilityModifier Variable 'tokenisedRules' must be private and have accessor methods. 81
 Warning		 design VisibilityModifier Variable 'variables' must be private and have accessor methods. 84
 Warning		 design VisibilityModifier Variable 'variablesInDefinitionOrder' must be private and have accessor methods. 87
 Warning		 design VisibilityModifier Variable 'detectors' must be private and have accessor methods. 90
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 93
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 96
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 99
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 102
 Warning		 design VisibilityModifier Variable 'numberOfConflictGroups' must be private and have accessor methods. 105
 Warning		 javadoc JavadocStyle First sentence should end with a period. 128
 Warning		 design VisibilityModifier Variable 'displayBackground' must be private and have accessor methods. 138
 Warning		 design VisibilityModifier Variable 'displayObjectLocations' must be private and have accessor methods. 141
 Warning		 misc FinalParameters Parameter controllerName should be final. 165
 Warning		 misc FinalParameters Parameter display should be final. 165
 Warning		 misc FinalParameters Parameter controllerName should be final. 184
 Info		 sizes MethodLength Method length is 151 lines (max allowed is 150). 253
 Warning		 naming StaticVariableName Name 'BIND_UNARY_MINUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 920
 Warning		 misc FinalParameters Parameter tokens should be final. 1176
 Info		 sizes MethodLength Method length is 269 lines (max allowed is 150). 1387
 Warning		 misc FinalParameters Parameter name should be final. 1698
 Warning		 misc FinalParameters Parameter stream should be final. 1698
 Warning		 misc FinalParameters Parameter flags should be final. 1698
 Warning		 misc FinalParameters Parameter location should be final. 1698
 Warning		 misc FinalParameters Parameter detectorId should be final. 1752
 Warning		 misc FinalParameters Parameter detectingGTU should be final. 1752
 Warning		 misc FinalParameters Parameter event should be final. 1813
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 1978
 Warning		 design VisibilityModifier Variable 'flags' must be private and have accessor methods. 2104
 Warning		 design VisibilityModifier Variable 'value' must be private and have accessor methods. 2107
 Warning		 design VisibilityModifier Variable 'timerMax10' must be private and have accessor methods. 2110
 Warning		 design VisibilityModifier Variable 'color' must be private and have accessor methods. 2113
 Warning		 design VisibilityModifier Variable 'name' must be private and have accessor methods. 2116
 Warning		 javadoc JavadocStyle First sentence should end with a period. 2118
 Warning		 design VisibilityModifier Variable 'stream' must be private and have accessor methods. 2119
 Warning		 design VisibilityModifier Variable 'refCount' must be private and have accessor methods. 2122
 Warning		 design VisibilityModifier Variable 'updateTime10' must be private and have accessor methods. 2125
 Warning		 design VisibilityModifier Variable 'startSource' must be private and have accessor methods. 2128
 Warning		 design VisibilityModifier Variable 'endSource' must be private and have accessor methods. 2131
 Warning		 naming StaticVariableName Name 'ROWLETTERS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 2137
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 2190
 Warning		 misc FinalParameters Parameter trafCOD should be final. 2190
 Warning		 misc FinalParameters Parameter sensor should be final. 2224
 Warning		 misc FinalParameters Parameter newValue should be final. 2346
 Warning		 misc FinalParameters Parameter timeStamp10 should be final. 2346
 Warning		 misc FinalParameters Parameter cause should be final. 2346
 Warning		 misc FinalParameters Parameter trafCOD should be final. 2346
 Warning		 coding HiddenField 'trafCOD' hides a field. 2346
 Warning		 misc FinalParameters Parameter colorValue should be final. 2500
 Warning		 misc FinalParameters Parameter value10 should be final. 2549
 Warning		 misc FinalParameters Parameter startSource should be final. 2573
 Warning		 misc FinalParameters Parameter endSource should be final. 2597
 Warning		 misc FinalParameters Parameter printFlags should be final. 2628
 Warning		 misc FinalParameters Parameter event should be final. 2737
 Warning		 design VisibilityModifier Variable 'cause' must be private and have accessor methods. 2758
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 2764

org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java

Severity Category Rule Message Line
 Warning		 design VisibilityModifier Variable 'defaultInitialDelay' must be private and have accessor methods. 56
 Warning		 design DesignForExtension Class 'TrafCODDisplay' looks like designed for extension (can be subclassed), but the method 'paintComponent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TrafCODDisplay' final or making the method 'paintComponent' static/final/abstract/empty, or adding allowed annotation for the method. 88
 Warning		 misc FinalParameters Parameter e should be final. 110
 Warning		 misc FinalParameters Parameter e should be final. 117
 Warning		 misc FinalParameters Parameter e should be final. 134
 Warning		 misc FinalParameters Parameter e should be final. 141
 Warning		 misc FinalParameters Parameter e should be final. 148
 Warning		 misc FinalParameters Parameter e should be final. 155
 Warning		 misc FinalParameters Parameter e should be final. 162
 Warning		 javadoc JavadocStyle First sentence should end with a period. 175
 Warning		 naming ConstantName Name 'xOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 219
 Warning		 naming ConstantName Name 'yOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 222
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 231
 Warning		 misc FinalParameters Parameter center should be final. 231
 Warning		 misc FinalParameters Parameter id should be final. 231
 Warning		 misc FinalParameters Parameter description should be final. 231
 Warning		 misc FinalParameters Parameter g2 should be final. 243
 Warning		 misc FinalParameters Parameter event should be final. 253
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 316
 Warning		 misc FinalParameters Parameter testX should be final. 327
 Warning		 misc FinalParameters Parameter testY should be final. 327
 Warning		 misc FinalParameters Parameter listener should be final. 408
 Warning		 misc FinalParameters Parameter eventType should be final. 408
 Warning		 misc FinalParameters Parameter referenceType should be final. 408
 Warning		 misc FinalParameters Parameter listener should be final. 416
 Warning		 misc FinalParameters Parameter eventType should be final. 416
 Warning		 misc FinalParameters Parameter position should be final. 416
 Warning		 misc FinalParameters Parameter listener should be final. 423
 Warning		 misc FinalParameters Parameter eventType should be final. 423
 Warning		 misc FinalParameters Parameter position should be final. 423
 Warning		 misc FinalParameters Parameter referenceType should be final. 423
 Warning		 misc FinalParameters Parameter listener should be final. 432
 Warning		 misc FinalParameters Parameter eventType should be final. 432
 Warning		 misc FinalParameters Parameter eventType should be final. 446
 Warning		 misc FinalParameters Parameter listener should be final. 460
 Warning		 misc FinalParameters Parameter eventType should be final. 460
 Warning		 misc FinalParameters Parameter trafficLightColor should be final. 474
 Warning		 misc FinalParameters Parameter g2 should be final. 485