PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 3

org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'updateDetector': the method is declared in an interface type 21

org/opentrafficsim/trafficcontrol/TrafficController.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getId': the method is declared in an interface type 28
UnnecessaryModifier Unnecessary modifier 'final' on field 'STARTING_UP': the field is declared in an interface type 31
UnnecessaryModifier Unnecessary modifier 'final' on field 'BEING_CLONED': the field is declared in an interface type 34
UnnecessaryModifier Unnecessary modifier 'final' on field 'RUNNING': the field is declared in an interface type 37
UnnecessaryModifier Unnecessary modifier 'final' on field 'SHUTTING_DOWN': the field is declared in an interface type 40
UnnecessaryModifier Unnecessary modifier 'final' on field 'OFF': the field is declared in an interface type 43
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_STREAM': the field is declared in an interface type 46
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'TRAFFIC_LIGHT_CHANGED': the field is declared in an interface type 78

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'trafficLights'. 88
UnusedFormalParameter Avoid unused constructor parameters such as 'sensors'. 89

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 668–671

Priority 4

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Rule Violation Line
UselessParentheses Useless parentheses. 415
UselessParentheses Useless parentheses. 415
UselessParentheses Useless parentheses. 431
UselessParentheses Useless parentheses. 431
UselessParentheses Useless parentheses. 1670
UselessParentheses Useless parentheses. 1757
UselessParentheses Useless parentheses. 2020
UselessParentheses Useless parentheses. 2785

Files

org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'updateDetector': the method is declared in an interface type 3 21

org/opentrafficsim/trafficcontrol/TrafficController.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getId': the method is declared in an interface type 3 28
UnnecessaryModifier Unnecessary modifier 'final' on field 'STARTING_UP': the field is declared in an interface type 3 31
UnnecessaryModifier Unnecessary modifier 'final' on field 'BEING_CLONED': the field is declared in an interface type 3 34
UnnecessaryModifier Unnecessary modifier 'final' on field 'RUNNING': the field is declared in an interface type 3 37
UnnecessaryModifier Unnecessary modifier 'final' on field 'SHUTTING_DOWN': the field is declared in an interface type 3 40
UnnecessaryModifier Unnecessary modifier 'final' on field 'OFF': the field is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_STREAM': the field is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'TRAFFIC_LIGHT_CHANGED': the field is declared in an interface type 3 78

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'trafficLights'. 3 88
UnusedFormalParameter Avoid unused constructor parameters such as 'sensors'. 3 89

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 668–671

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 415
UselessParentheses Useless parentheses. 4 415
UselessParentheses Useless parentheses. 4 431
UselessParentheses Useless parentheses. 4 431
UselessParentheses Useless parentheses. 4 1670
UselessParentheses Useless parentheses. 4 1757
UselessParentheses Useless parentheses. 4 2020
UselessParentheses Useless parentheses. 4 2785