PMD Results

The following document contains the results of PMD 7.7.0.

Violations By Priority

Priority 3

org/opentrafficsim/core/geometry/Ots2dSet.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 418425

org/opentrafficsim/core/gtu/Gtu.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 989992

org/opentrafficsim/core/gtu/plan/operational/OperationalPlan.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'gtu'. 52

org/opentrafficsim/core/math/Acceleration3d.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'unit'. 69

org/opentrafficsim/core/network/LinkPosition.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getLongitudinalPosition': the method is already in a final class 43

org/opentrafficsim/core/network/Network.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 729732
UnusedFormalParameter Avoid unused method parameters such as 'gtuType'. 761

org/opentrafficsim/core/network/Node.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 352355

org/opentrafficsim/core/network/route/Route.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 7276

org/opentrafficsim/core/perception/AbstractHistorical.java

Rule Violation Line
SimplifiedTernary This conditional expression can be simplified with || or && 147

org/opentrafficsim/core/perception/HistoricalParameters.java

Rule Violation Line
UnnecessaryReturn Unnecessary return statement 182

Priority 4

org/opentrafficsim/core/definitions/DefaultsNl.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DefaultsNl': 'ROAD_USER' is already in scope because it is declared in an enclosing type 213
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DefaultsNl': 'VEHICLE' is already in scope because it is declared in an enclosing type 214
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DefaultsNl': 'BICYCLE' is already in scope because it is declared in an enclosing type 215

org/opentrafficsim/core/geometry/PolyLineCurve2d.java

Rule Violation Line
UselessParentheses Useless parentheses. 53

org/opentrafficsim/core/gtu/Gtu.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Gtu': 'DESTROY_EVENT' is already in scope because it is declared in an enclosing type 394
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Gtu': 'MOVE_EVENT' is already in scope because it is declared in an enclosing type 481

org/opentrafficsim/core/gtu/RelativePosition.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RelativePosition': 'REFERENCE' is already in scope because it is declared in an enclosing type 44

org/opentrafficsim/core/network/Link.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Link': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type 137
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Link': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 153

org/opentrafficsim/core/network/Network.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'NODE_ADD_EVENT' is already in scope because it is declared in an enclosing type 139
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'NODE_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 153
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'LINK_ADD_EVENT' is already in scope because it is declared in an enclosing type 268
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'LINK_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 282
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type 429
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 443
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'NONLOCATED_OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type 530
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'NONLOCATED_OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 544
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'ROUTE_ADD_EVENT' is already in scope because it is declared in an enclosing type 623
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'ROUTE_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 639
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type 932
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 938

org/opentrafficsim/core/network/Node.java

Rule Violation Line
UselessParentheses Useless parentheses. 350

Files

org/opentrafficsim/core/definitions/DefaultsNl.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DefaultsNl': 'ROAD_USER' is already in scope because it is declared in an enclosing type 4 213
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DefaultsNl': 'VEHICLE' is already in scope because it is declared in an enclosing type 4 214
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DefaultsNl': 'BICYCLE' is already in scope because it is declared in an enclosing type 4 215

org/opentrafficsim/core/geometry/Ots2dSet.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 418425

org/opentrafficsim/core/geometry/PolyLineCurve2d.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 53

org/opentrafficsim/core/gtu/Gtu.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Gtu': 'DESTROY_EVENT' is already in scope because it is declared in an enclosing type 4 394
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Gtu': 'MOVE_EVENT' is already in scope because it is declared in an enclosing type 4 481
EmptyCatchBlock Avoid empty catch blocks 3 989992

org/opentrafficsim/core/gtu/RelativePosition.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RelativePosition': 'REFERENCE' is already in scope because it is declared in an enclosing type 4 44

org/opentrafficsim/core/gtu/plan/operational/OperationalPlan.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'gtu'. 3 52

org/opentrafficsim/core/math/Acceleration3d.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'unit'. 3 69

org/opentrafficsim/core/network/Link.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Link': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 137
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Link': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 153

org/opentrafficsim/core/network/LinkPosition.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getLongitudinalPosition': the method is already in a final class 3 43

org/opentrafficsim/core/network/Network.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'NODE_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 139
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'NODE_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 153
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'LINK_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 268
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'LINK_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 282
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 429
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 443
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'NONLOCATED_OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 530
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'NONLOCATED_OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 544
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'ROUTE_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 623
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'ROUTE_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 639
EmptyCatchBlock Avoid empty catch blocks 3 729732
UnusedFormalParameter Avoid unused method parameters such as 'gtuType'. 3 761
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 932
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Network': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 938

org/opentrafficsim/core/network/Node.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 350
CollapsibleIfStatements This if statement could be combined with its parent 3 352355

org/opentrafficsim/core/network/route/Route.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 7276

org/opentrafficsim/core/perception/AbstractHistorical.java

Rule Violation Priority Line
SimplifiedTernary This conditional expression can be simplified with || or && 3 147

org/opentrafficsim/core/perception/HistoricalParameters.java

Rule Violation Priority Line
UnnecessaryReturn Unnecessary return statement 3 182