PMD Results
The following document contains the results of PMD 7.3.0.
Violations By Priority
Priority 3
org/opentrafficsim/core/definitions/DefaultsNl.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessarySemicolon | Unnecessary semicolon | 143 |
org/opentrafficsim/core/dsol/OtsDevsRealTimeParallelMove.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 329–332 |
| EmptyCatchBlock | Avoid empty catch blocks | 372–375 |
| EmptyCatchBlock | Avoid empty catch blocks | 415–418 |
org/opentrafficsim/core/dsol/OtsLoggingAnimator.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'path'. | 40 |
org/opentrafficsim/core/geometry/Flattener.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static' on class 'NumSegments': the class is declared in an interface type | 46 |
| UnnecessaryModifier | Unnecessary modifiers 'public static' on class 'MaxDeviation': the class is declared in an interface type | 85 |
| UnnecessaryModifier | Unnecessary modifiers 'public static' on class 'MaxDeviationAndAngle': the class is declared in an interface type | 165 |
| UnnecessaryModifier | Unnecessary modifiers 'public static' on class 'MaxAngle': the class is declared in an interface type | 277 |
org/opentrafficsim/core/geometry/Ots2dSet.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 425–432 |
org/opentrafficsim/core/gtu/Gtu.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'centerOfGravity'. | 200 |
| EmptyCatchBlock | Avoid empty catch blocks | 918–921 |
org/opentrafficsim/core/math/Acceleration3d.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'unit'. | 72 |
org/opentrafficsim/core/network/LinkPosition.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getLongitudinalPosition': the method is already in a final class | 48 |
org/opentrafficsim/core/network/Network.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 735–738 |
| UnusedFormalParameter | Avoid unused method parameters such as 'gtuType'. | 767 |
org/opentrafficsim/core/network/Node.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 359–362 |
org/opentrafficsim/core/network/route/Route.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 77–81 |
org/opentrafficsim/core/perception/AbstractHistorical.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 146 |
Priority 4
org/opentrafficsim/core/definitions/DefaultsNl.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DefaultsNl': 'ROAD_USER' is already in scope because it is declared in an enclosing type | 203 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DefaultsNl': 'VEHICLE' is already in scope because it is declared in an enclosing type | 204 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DefaultsNl': 'BICYCLE' is already in scope because it is declared in an enclosing type | 205 |
org/opentrafficsim/core/dsol/OtsDevsRealTimeParallelMove.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 152 |
| UselessParentheses | Useless parentheses. | 185 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SimulatorInterface': 'TIME_CHANGED_EVENT' is already in scope because it is inherited by an enclosing type | 203 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SimulatorInterface': 'TIME_CHANGED_EVENT' is already in scope because it is inherited by an enclosing type | 422 |
org/opentrafficsim/core/dsol/OtsLoggingAnimator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 173 |
| UselessParentheses | Useless parentheses. | 206 |
| UselessParentheses | Useless parentheses. | 214 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SimulatorInterface': 'TIME_CHANGED_EVENT' is already in scope because it is inherited by an enclosing type | 252 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SimulatorInterface': 'TIME_CHANGED_EVENT' is already in scope because it is inherited by an enclosing type | 290 |
org/opentrafficsim/core/geometry/Bezier.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 206 |
| UselessParentheses | Useless parentheses. | 266 |
| UselessParentheses | Useless parentheses. | 271 |
org/opentrafficsim/core/geometry/ContinuousArc.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 81 |
| UselessParentheses | Useless parentheses. | 118 |
| UselessParentheses | Useless parentheses. | 131 |
| UselessParentheses | Useless parentheses. | 193–194 |
org/opentrafficsim/core/geometry/ContinuousClothoid.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 364 |
org/opentrafficsim/core/geometry/Fresnel.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 258 |
| UselessParentheses | Useless parentheses. | 259 |
org/opentrafficsim/core/geometry/Ots2dSet.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'java.awt.geom.Rectangle2D' | 3 |
| UnnecessaryImport | Unused import 'org.opentrafficsim.base.geometry.OtsGeometryException' | 15 |
org/opentrafficsim/core/gtu/Gtu.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Gtu': 'DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 342 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Gtu': 'MOVE_EVENT' is already in scope because it is declared in an enclosing type | 435 |
org/opentrafficsim/core/gtu/RelativePosition.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'RelativePosition': 'REFERENCE' is already in scope because it is declared in an enclosing type | 49 |
org/opentrafficsim/core/network/Link.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Link': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 148 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Link': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 164 |
org/opentrafficsim/core/network/Network.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'NODE_ADD_EVENT' is already in scope because it is declared in an enclosing type | 140 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'NODE_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 154 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'LINK_ADD_EVENT' is already in scope because it is declared in an enclosing type | 269 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'LINK_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 283 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 435 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 449 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'NONLOCATED_OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 535 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'NONLOCATED_OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 549 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'ROUTE_ADD_EVENT' is already in scope because it is declared in an enclosing type | 628 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'ROUTE_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 644 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 931 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 937 |
org/opentrafficsim/core/network/Node.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'org.opentrafficsim.base.geometry.SpatialObject' | 22 |
| UselessParentheses | Useless parentheses. | 357 |
Files
org/opentrafficsim/core/definitions/DefaultsNl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 143 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DefaultsNl': 'ROAD_USER' is already in scope because it is declared in an enclosing type | 4 | 203 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DefaultsNl': 'VEHICLE' is already in scope because it is declared in an enclosing type | 4 | 204 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DefaultsNl': 'BICYCLE' is already in scope because it is declared in an enclosing type | 4 | 205 |
org/opentrafficsim/core/dsol/OtsDevsRealTimeParallelMove.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 152 |
| UselessParentheses | Useless parentheses. | 4 | 185 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SimulatorInterface': 'TIME_CHANGED_EVENT' is already in scope because it is inherited by an enclosing type | 4 | 203 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 329–332 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 372–375 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 415–418 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SimulatorInterface': 'TIME_CHANGED_EVENT' is already in scope because it is inherited by an enclosing type | 4 | 422 |
org/opentrafficsim/core/dsol/OtsLoggingAnimator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'path'. | 3 | 40 |
| UselessParentheses | Useless parentheses. | 4 | 173 |
| UselessParentheses | Useless parentheses. | 4 | 206 |
| UselessParentheses | Useless parentheses. | 4 | 214 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SimulatorInterface': 'TIME_CHANGED_EVENT' is already in scope because it is inherited by an enclosing type | 4 | 252 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SimulatorInterface': 'TIME_CHANGED_EVENT' is already in scope because it is inherited by an enclosing type | 4 | 290 |
org/opentrafficsim/core/geometry/Bezier.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 206 |
| UselessParentheses | Useless parentheses. | 4 | 266 |
| UselessParentheses | Useless parentheses. | 4 | 271 |
org/opentrafficsim/core/geometry/ContinuousArc.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 81 |
| UselessParentheses | Useless parentheses. | 4 | 118 |
| UselessParentheses | Useless parentheses. | 4 | 131 |
| UselessParentheses | Useless parentheses. | 4 | 193–194 |
org/opentrafficsim/core/geometry/ContinuousClothoid.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 364 |
org/opentrafficsim/core/geometry/Flattener.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static' on class 'NumSegments': the class is declared in an interface type | 3 | 46 |
| UnnecessaryModifier | Unnecessary modifiers 'public static' on class 'MaxDeviation': the class is declared in an interface type | 3 | 85 |
| UnnecessaryModifier | Unnecessary modifiers 'public static' on class 'MaxDeviationAndAngle': the class is declared in an interface type | 3 | 165 |
| UnnecessaryModifier | Unnecessary modifiers 'public static' on class 'MaxAngle': the class is declared in an interface type | 3 | 277 |
org/opentrafficsim/core/geometry/Fresnel.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 258 |
| UselessParentheses | Useless parentheses. | 4 | 259 |
org/opentrafficsim/core/geometry/Ots2dSet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'java.awt.geom.Rectangle2D' | 4 | 3 |
| UnnecessaryImport | Unused import 'org.opentrafficsim.base.geometry.OtsGeometryException' | 4 | 15 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 425–432 |
org/opentrafficsim/core/gtu/Gtu.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'centerOfGravity'. | 3 | 200 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Gtu': 'DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 342 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Gtu': 'MOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 435 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 918–921 |
org/opentrafficsim/core/gtu/RelativePosition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'RelativePosition': 'REFERENCE' is already in scope because it is declared in an enclosing type | 4 | 49 |
org/opentrafficsim/core/math/Acceleration3d.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'unit'. | 3 | 72 |
org/opentrafficsim/core/network/Link.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Link': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 148 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Link': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 164 |
org/opentrafficsim/core/network/LinkPosition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getLongitudinalPosition': the method is already in a final class | 3 | 48 |
org/opentrafficsim/core/network/Network.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'NODE_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 140 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'NODE_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 154 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'LINK_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 269 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'LINK_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 283 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 435 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 449 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'NONLOCATED_OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 535 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'NONLOCATED_OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 549 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'ROUTE_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 628 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'ROUTE_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 644 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 735–738 |
| UnusedFormalParameter | Avoid unused method parameters such as 'gtuType'. | 3 | 767 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 931 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Network': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 937 |
org/opentrafficsim/core/network/Node.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'org.opentrafficsim.base.geometry.SpatialObject' | 4 | 22 |
| UselessParentheses | Useless parentheses. | 4 | 357 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 359–362 |
org/opentrafficsim/core/network/route/Route.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 77–81 |
org/opentrafficsim/core/perception/AbstractHistorical.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 146 |