Checkstyle Results
The following document contains the results of Checkstyle 10.17.0 with /config/dsol-checks.xml ruleset.
Summary
| Files |  Info |
 Warnings |
 Errors |
|---|---|---|---|
| 39 | 8 | 527 | 0 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | EmptyBlock | 4 | Warning |
| NeedBraces | 103 | Warning | |
| coding | EmptyStatement | 1 | Warning |
HiddenField
|
7 | Warning | |
| SimplifyBooleanExpression | 19 | Warning | |
| design | DesignForExtension | 46 | Warning |
| HideUtilityClassConstructor | 3 | Warning | |
| VisibilityModifier | 42 | Warning | |
| javadoc | JavadocMethod | 1 | Warning |
| JavadocPackage | 1 | Info | |
| JavadocStyle | 8 | Warning | |
| JavadocVariable | 39 | Warning | |
| misc | FinalParameters | 203 | Warning |
NewlineAtEndOfFile
|
10 | Warning | |
| TodoComment | 7 | Warning | |
| modifier | ModifierOrder | 3 | Warning |
| RedundantModifier | 7 | Warning | |
| naming | ConstantName | 12 | Warning |
| LocalVariableName | 2 | Warning | |
| MemberName | 5 | Warning | |
| StaticVariableName | 4 | Warning | |
| sizes | LineLength
|
2 | Info |
| MethodLength | 4 | Info | |
| ParameterNumber | 1 | Info | |
| whitespace | WhitespaceAfter | 1 | Warning |
Details
com/bric/multislider/AquaMultiThumbSliderUi.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Warning |
naming | StaticVariableName | Name 'UPPER_GRAY' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 22 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Warning |
naming | StaticVariableName | Name 'LOWER_GRAY' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 24 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Warning |
naming | StaticVariableName | Name 'OUTLINE_OPACITY' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 26 |
| Warning |
misc | FinalParameters | Parameter slider should be final. | 28 |
| Warning |
design | DesignForExtension | Class 'AquaMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getPreferredComponentDepth' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AquaMultiThumbSliderUi' final or making the method 'getPreferredComponentDepth' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 43 |
| Warning |
design | DesignForExtension | Class 'AquaMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getThumbSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AquaMultiThumbSliderUi' final or making the method 'getThumbSize' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 49 |
| Warning |
design | DesignForExtension | Class 'AquaMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'paintTrack' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AquaMultiThumbSliderUi' final or making the method 'paintTrack' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 71 |
| Warning |
design | DesignForExtension | Class 'AquaMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'calculateTrackRect' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AquaMultiThumbSliderUi' final or making the method 'calculateTrackRect' static/final/abstract/empty, or adding allowed annotation for the method. | 108 |
| Warning |
design | DesignForExtension | Class 'AquaMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'paintThumb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AquaMultiThumbSliderUi' final or making the method 'paintThumb' static/final/abstract/empty, or adding allowed annotation for the method. | 130 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 131 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 131 |
| Warning |
misc | FinalParameters | Parameter selected should be final. | 131 |
com/bric/multislider/DefaultMultiThumbSliderUi.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Warning |
design | VisibilityModifier | Variable 'FOCUS_PADDING' must be private and have accessor methods. | 17 |
| Warning |
naming | MemberName | Name 'FOCUS_PADDING' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 17 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Warning |
design | VisibilityModifier | Variable 'trackHighlightColor' must be private and have accessor methods. | 19 |
| Warning |
misc | FinalParameters | Parameter slider should be final. | 21 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'isTrackHighlightActive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'isTrackHighlightActive' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getPreferredComponentDepth' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'getPreferredComponentDepth' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getThumbSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'getThumbSize' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 39 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'paintTrack' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'paintTrack' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 61 |
| Warning |
coding | EmptyStatement | Empty statement. | 93 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 103 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 105 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'paintTick' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'paintTick' static/final/abstract/empty, or adding allowed annotation for the method. | 128 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 128 |
| Warning |
misc | FinalParameters | Parameter f should be final. | 128 |
| Warning |
misc | FinalParameters | Parameter d1 should be final. | 128 |
| Warning |
misc | FinalParameters | Parameter d2 should be final. | 128 |
| Warning |
misc | FinalParameters | Parameter mirror should be final. | 128 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'paintFocus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'paintFocus' static/final/abstract/empty, or adding allowed annotation for the method. | 154 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 155 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'calculateTrackRect' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'calculateTrackRect' static/final/abstract/empty, or adding allowed annotation for the method. | 163 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getTrackOutline' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'getTrackOutline' static/final/abstract/empty, or adding allowed annotation for the method. | 179 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'paintThumbs' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'paintThumbs' static/final/abstract/empty, or adding allowed annotation for the method. | 193 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 194 |
| Warning |
design | DesignForExtension | Class 'DefaultMultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'paintThumb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DefaultMultiThumbSliderUi' final or making the method 'paintThumb' static/final/abstract/empty, or adding allowed annotation for the method. | 204 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 204 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 204 |
| Warning |
misc | FinalParameters | Parameter selected should be final. | 204 |
com/bric/multislider/EmptyPathException.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
misc | FinalParameters | Parameter message should be final. | 35 |
| Warning |
misc | FinalParameters | Parameter cause should be final. | 40 |
| Warning |
misc | FinalParameters | Parameter message should be final. | 45 |
| Warning |
misc | FinalParameters | Parameter cause should be final. | 45 |
com/bric/multislider/Jvm.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 30 |
| Warning |
naming | ConstantName | Name 'javaVersion' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 59 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
| Warning |
naming | ConstantName | Name 'osName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 61 |
| Warning |
naming | ConstantName | Name 'isMac' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 78 |
| Warning |
naming | ConstantName | Name 'isLinux' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 81 |
| Warning |
naming | ConstantName | Name 'isWindows' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 84 |
| Warning |
naming | ConstantName | Name 'isVista' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 87 |
| Warning |
naming | ConstantName | Name 'isWindows7' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 90 |
| Warning |
naming | ConstantName | Name 'isWindowsXP' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 93 |
| Warning |
naming | ConstantName | Name 'isVistaOrWindows7' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 96 |
| Warning |
naming | ConstantName | Name 'usingQuartz' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 102 |
| Warning |
misc | FinalParameters | Parameter catchSecurityException should be final. | 165 |
com/bric/multislider/MultiThumbSlider.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 84 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 133 |
| Warning |
design | VisibilityModifier | Variable 'thumbPositions' must be private and have accessor methods. | 134 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 136 |
| Warning |
design | VisibilityModifier | Variable 'values' must be private and have accessor methods. | 137 |
| Warning |
design | VisibilityModifier | Variable 'changeListeners' must be private and have accessor methods. | 140 |
| Warning |
misc | FinalParameters | Parameter thumbPositions should be final. | 157 |
| Warning |
misc | FinalParameters | Parameter values should be final. | 157 |
| Warning |
misc | FinalParameters | Parameter orientation should be final. | 168 |
| Warning |
misc | FinalParameters | Parameter thumbPositions should be final. | 168 |
| Warning |
misc | FinalParameters | Parameter values should be final. | 168 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'getUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'getUI' static/final/abstract/empty, or adding allowed annotation for the method. | 176 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'updateUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'updateUI' static/final/abstract/empty, or adding allowed annotation for the method. | 182 |
| Warning |
misc | FinalParameters | Parameter ui should be final. | 231 |
| Warning |
misc | FinalParameters | Parameter l should be final. | 243 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 245 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 247 |
| Warning |
misc | FinalParameters | Parameter l should be final. | 256 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 258 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 266 |
| Warning |
misc | FinalParameters | Parameter forward should be final. | 296 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 301 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 305 |
| Warning |
misc | FinalParameters | Parameter pos should be final. | 352 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 140). | 355 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 358 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 362 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 364 |
| Warning |
misc | FinalParameters | Parameter srcArray should be final. | 382 |
| Warning |
misc | FinalParameters | Parameter length should be final. | 382 |
| Warning |
misc | FinalParameters | Parameter x should be final. | 404 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 404 |
| Warning |
misc | FinalParameters | Parameter x should be final. | 419 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 419 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 431 |
| Warning |
misc | FinalParameters | Parameter b should be final. | 442 |
| Warning |
misc | FinalParameters | Parameter pos should be final. | 454 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 456 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 484 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 491 |
| Warning |
misc | FinalParameters | Parameter b should be final. | 519 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 531 |
| Warning |
misc | FinalParameters | Parameter f should be final. | 568 |
| Warning |
misc | FinalParameters | Parameter thumbPositions should be final. | 595 |
| Warning |
coding | HiddenField | 'thumbPositions' hides a field. | 595 |
| Warning |
misc | FinalParameters | Parameter values should be final. | 595 |
| Warning |
coding | HiddenField | 'values' hides a field. | 595 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 597 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 603 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 605 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 608 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 620 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 625 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 628 |
| Warning |
misc | FinalParameters | Parameter index should be final. | 667 |
| Warning |
misc | FinalParameters | Parameter ignoreIfUnfocused should be final. | 693 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 695 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 695 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 698 |
| Warning |
misc | FinalParameters | Parameter b should be final. | 707 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 718 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 730 |
| Warning |
misc | FinalParameters | Parameter i should be final. | 739 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 741 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 752 |
| Warning |
misc | FinalParameters | Parameter b should be final. | 761 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'getCollisionPolicy' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'getCollisionPolicy' static/final/abstract/empty, or adding allowed annotation for the method. | 766 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 769 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'setCollisionPolicy' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'setCollisionPolicy' static/final/abstract/empty, or adding allowed annotation for the method. | 774 |
| Warning |
misc | FinalParameters | Parameter c should be final. | 774 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'isThumbRemovalAllowed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'isThumbRemovalAllowed' static/final/abstract/empty, or adding allowed annotation for the method. | 779 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 782 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'setThumbRemovalAllowed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'setThumbRemovalAllowed' static/final/abstract/empty, or adding allowed annotation for the method. | 787 |
| Warning |
misc | FinalParameters | Parameter b should be final. | 787 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'setMinimumThumbnailCount' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'setMinimumThumbnailCount' static/final/abstract/empty, or adding allowed annotation for the method. | 792 |
| Warning |
misc | FinalParameters | Parameter i should be final. | 792 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'getMinimumThumbnailCount' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'getMinimumThumbnailCount' static/final/abstract/empty, or adding allowed annotation for the method. | 797 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 800 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'setThumbOverlap' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'setThumbOverlap' static/final/abstract/empty, or adding allowed annotation for the method. | 805 |
| Warning |
misc | FinalParameters | Parameter i should be final. | 805 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSlider' looks like designed for extension (can be subclassed), but the method 'isThumbOverlap' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSlider' final or making the method 'isThumbOverlap' static/final/abstract/empty, or adding allowed annotation for the method. | 810 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 813 |
com/bric/multislider/MultiThumbSliderDemo.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
misc | FinalParameters | Parameter args should be final. | 32 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
| Warning |
design | VisibilityModifier | Variable 'collisionComboBox' must be private and have accessor methods. | 49 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
| Warning |
design | VisibilityModifier | Variable 'uiComboBox' must be private and have accessor methods. | 51 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
| Warning |
design | VisibilityModifier | Variable 'thumbComboBox' must be private and have accessor methods. | 53 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
| Warning |
design | VisibilityModifier | Variable 'overlapOnButton' must be private and have accessor methods. | 55 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 57 |
| Warning |
design | VisibilityModifier | Variable 'overlapOffButton' must be private and have accessor methods. | 57 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
| Warning |
design | VisibilityModifier | Variable 'removalOnButton' must be private and have accessor methods. | 59 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
| Warning |
design | VisibilityModifier | Variable 'removalOffButton' must be private and have accessor methods. | 61 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
| Warning |
design | VisibilityModifier | Variable 'slider1' must be private and have accessor methods. | 63 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 66 |
| Warning |
design | VisibilityModifier | Variable 'slider2' must be private and have accessor methods. | 66 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 69 |
| Warning |
design | VisibilityModifier | Variable 'slider3' must be private and have accessor methods. | 69 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 72 |
| Warning |
design | VisibilityModifier | Variable 'slider4' must be private and have accessor methods. | 72 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 75 |
| Warning |
design | VisibilityModifier | Variable 'sliders' must be private and have accessor methods. | 75 |
| Info |
sizes | MethodLength | Method MultiThumbSliderDemo length is 208 lines (max allowed is 150). | 77 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 173 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 187 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 205 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 222 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 245 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 261 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 272 |
| Warning |
misc | FinalParameters | Parameter list should be final. | 287 |
com/bric/multislider/MultiThumbSliderUi.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 58 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 71 |
| Warning |
design | VisibilityModifier | Variable 'thumbShapeListener' must be private and have accessor methods. | 71 |
| Warning |
misc | FinalParameters | Parameter evt should be final. | 75 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 85 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 87 |
| Warning |
misc | FinalParameters | Parameter width should be final. | 90 |
| Warning |
misc | FinalParameters | Parameter height should be final. | 90 |
| Warning |
misc | FinalParameters | Parameter leftEdge should be final. | 90 |
| Warning |
misc | FinalParameters | Parameter rightEdge should be final. | 90 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 96 |
| Warning |
misc | FinalParameters | Parameter width should be final. | 99 |
| Warning |
misc | FinalParameters | Parameter height should be final. | 99 |
| Warning |
misc | FinalParameters | Parameter leftEdge should be final. | 99 |
| Warning |
misc | FinalParameters | Parameter rightEdge should be final. | 99 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 139 |
| Warning |
misc | FinalParameters | Parameter width should be final. | 142 |
| Warning |
misc | FinalParameters | Parameter height should be final. | 142 |
| Warning |
misc | FinalParameters | Parameter leftEdge should be final. | 142 |
| Warning |
misc | FinalParameters | Parameter rightEdge should be final. | 142 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 158 |
| Warning |
misc | FinalParameters | Parameter width should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter height should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter leftEdge should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter rightEdge should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter sliderUI should be final. | 214 |
| Warning |
misc | FinalParameters | Parameter x should be final. | 214 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 214 |
| Warning |
misc | FinalParameters | Parameter width should be final. | 214 |
| Warning |
misc | FinalParameters | Parameter height should be final. | 214 |
| Warning |
misc | FinalParameters | Parameter leftEdge should be final. | 214 |
| Warning |
misc | FinalParameters | Parameter rightEdge should be final. | 215 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 218 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 241 |
| Warning |
design | VisibilityModifier | Variable 'slider' must be private and have accessor methods. | 241 |
| Warning |
design | VisibilityModifier | Variable 'MAX_LENGTH' must be private and have accessor methods. | 246 |
| Warning |
naming | MemberName | Name 'MAX_LENGTH' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 246 |
| Warning |
design | VisibilityModifier | Variable 'MIN_LENGTH' must be private and have accessor methods. | 251 |
| Warning |
naming | MemberName | Name 'MIN_LENGTH' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 251 |
| Warning |
design | VisibilityModifier | Variable 'PREF_LENGTH' must be private and have accessor methods. | 257 |
| Warning |
naming | MemberName | Name 'PREF_LENGTH' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 257 |
| Warning |
design | VisibilityModifier | Variable 'DEPTH' must be private and have accessor methods. | 262 |
| Warning |
naming | MemberName | Name 'DEPTH' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 262 |
| Warning |
design | VisibilityModifier | Variable 'thumbPositions' must be private and have accessor methods. | 268 |
| Warning |
design | VisibilityModifier | Variable 'thumbIndications' must be private and have accessor methods. | 273 |
| Warning |
design | VisibilityModifier | Variable 'indication' must be private and have accessor methods. | 281 |
| Warning |
design | VisibilityModifier | Variable 'trackRect' must be private and have accessor methods. | 284 |
| Warning |
misc | FinalParameters | Parameter slider should be final. | 286 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getMaximumSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'getMaximumSize' static/final/abstract/empty, or adding allowed annotation for the method. | 291 |
| Warning |
misc | FinalParameters | Parameter s should be final. | 292 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getMinimumSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'getMinimumSize' static/final/abstract/empty, or adding allowed annotation for the method. | 303 |
| Warning |
misc | FinalParameters | Parameter s should be final. | 304 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getPreferredSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'getPreferredSize' static/final/abstract/empty, or adding allowed annotation for the method. | 315 |
| Warning |
misc | FinalParameters | Parameter s should be final. | 316 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 339 |
| Warning |
design | VisibilityModifier | Variable 'values' must be private and have accessor methods. | 339 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 341 |
| Warning |
design | VisibilityModifier | Variable 'positions' must be private and have accessor methods. | 341 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 343 |
| Warning |
design | VisibilityModifier | Variable 'selectedThumb' must be private and have accessor methods. | 343 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 345 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 352 |
| Warning |
misc | FinalParameters | Parameter s should be final. | 352 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 361 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 384 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 388 |
| Warning |
misc | FinalParameters | Parameter src should be final. | 403 |
| Warning |
misc | FinalParameters | Parameter length should be final. | 403 |
| Warning |
misc | FinalParameters | Parameter index should be final. | 409 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 422 |
| Warning |
misc | FinalParameters | Parameter newPosition should be final. | 422 |
| Warning |
misc | FinalParameters | Parameter thumbIndexA should be final. | 427 |
| Warning |
misc | FinalParameters | Parameter thumbIndexB should be final. | 427 |
| Warning |
misc | FinalParameters | Parameter newThumbBPosition should be final. | 427 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 429 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 433 |
| Warning |
misc | FinalParameters | Parameter thumbIndexA should be final. | 438 |
| Warning |
misc | FinalParameters | Parameter thumbIndexB should be final. | 438 |
| Warning |
misc | FinalParameters | Parameter newThumbBPosition should be final. | 438 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 440 |
| Info |
sizes | MethodLength | Method setPosition length is 164 lines (max allowed is 150). | 453 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 453 |
| Warning |
misc | FinalParameters | Parameter newPosition should be final. | 453 |
| Warning |
misc | FinalParameters | Parameter revise should be final. | 453 |
| Warning |
design | VisibilityModifier | Variable 'thumbIndex' must be private and have accessor methods. | 538 |
| Warning |
design | VisibilityModifier | Variable 'startingValue' must be private and have accessor methods. | 541 |
| Warning |
design | VisibilityModifier | Variable 'requestedDelta' must be private and have accessor methods. | 544 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 546 |
| Warning |
misc | FinalParameters | Parameter startingValue should be final. | 546 |
| Warning |
misc | FinalParameters | Parameter requestedDelta should be final. | 546 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 624 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 658 |
| Warning |
design | VisibilityModifier | Variable 'animatingThread' must be private and have accessor methods. | 658 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 660 |
| Warning |
design | VisibilityModifier | Variable 'animatingRunnable' must be private and have accessor methods. | 660 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 726 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 746 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 748 |
| Warning |
design | VisibilityModifier | Variable 'mouseInside' must be private and have accessor methods. | 748 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 750 |
| Warning |
design | VisibilityModifier | Variable 'mouseIsDown' must be private and have accessor methods. | 750 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 752 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 754 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'mousePressed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'mousePressed' static/final/abstract/empty, or adding allowed annotation for the method. | 756 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 756 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 761 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 761 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 778 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 784 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 840 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 846 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 846 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 868 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 917 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'mouseEntered' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'mouseEntered' static/final/abstract/empty, or adding allowed annotation for the method. | 929 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 929 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'mouseExited' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'mouseExited' static/final/abstract/empty, or adding allowed annotation for the method. | 934 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 934 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 940 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'mouseMoved' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'mouseMoved' static/final/abstract/empty, or adding allowed annotation for the method. | 944 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 944 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 946 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 946 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 952 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'getThumbSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'getThumbSize' static/final/abstract/empty, or adding allowed annotation for the method. | 957 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 957 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 969 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 984 |
| Warning |
misc | FinalParameters | Parameter center should be final. | 984 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 987 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 994 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 999 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 1007 |
| Warning |
misc | FinalParameters | Parameter position should be final. | 1012 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1018 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 1059 |
| Warning |
misc | FinalParameters | Parameter i should be final. | 1065 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1095 |
| Warning |
misc | FinalParameters | Parameter b should be final. | 1104 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'mouseDragged' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'mouseDragged' static/final/abstract/empty, or adding allowed annotation for the method. | 1110 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1110 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1112 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1112 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1128 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1135 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1137 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1144 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1144 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1150 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1152 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'mouseReleased' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'mouseReleased' static/final/abstract/empty, or adding allowed annotation for the method. | 1175 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1175 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1177 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1177 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<K>'. | 1208 |
| Warning |
misc | FinalParameters | Parameter jc should be final. | 1208 |
| Warning |
misc | FinalParameters | Parameter propertyName should be final. | 1208 |
| Warning |
misc | FinalParameters | Parameter defaultValue should be final. | 1208 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1211 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1214 |
| Warning |
misc | FinalParameters | Parameter state should be final. | 1224 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 1285 |
| Warning |
design | VisibilityModifier | Variable 'focusListener' must be private and have accessor methods. | 1285 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1287 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1299 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1306 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1308 |
| Warning |
misc | FinalParameters | Parameter index1 should be final. | 1326 |
| Warning |
misc | FinalParameters | Parameter index2 should be final. | 1326 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1343 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1345 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1348 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 1357 |
| Warning |
design | VisibilityModifier | Variable 'keyListener' must be private and have accessor methods. | 1357 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1359 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1361 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1361 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1364 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1374 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1375 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1392 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1393 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1464 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1468 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 1473 |
| Warning |
design | VisibilityModifier | Variable 'propertyListener' must be private and have accessor methods. | 1473 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1476 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 1499 |
| Warning |
design | VisibilityModifier | Variable 'compListener' must be private and have accessor methods. | 1499 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1502 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1506 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1510 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 1517 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'updateIndication' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'updateIndication' static/final/abstract/empty, or adding allowed annotation for the method. | 1522 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1539 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1547 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'calculateGeometry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'calculateGeometry' static/final/abstract/empty, or adding allowed annotation for the method. | 1556 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 1571 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'calculateTrackRect' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'calculateTrackRect' static/final/abstract/empty, or adding allowed annotation for the method. | 1599 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 1616 |
| Warning |
misc | FinalParameters | Parameter direction should be final. | 1616 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1627 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1629 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1631 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'installUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'installUI' static/final/abstract/empty, or adding allowed annotation for the method. | 1652 |
| Warning |
misc | FinalParameters | Parameter slider should be final. | 1653 |
| Warning |
coding | HiddenField | 'slider' hides a field. | 1653 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'paint' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'paint' static/final/abstract/empty, or adding allowed annotation for the method. | 1665 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 1666 |
| Warning |
misc | FinalParameters | Parameter slider2 should be final. | 1666 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1668 |
| Warning |
design | DesignForExtension | Class 'MultiThumbSliderUi' looks like designed for extension (can be subclassed), but the method 'uninstallUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MultiThumbSliderUi' final or making the method 'uninstallUI' static/final/abstract/empty, or adding allowed annotation for the method. | 1698 |
| Warning |
misc | FinalParameters | Parameter slider should be final. | 1699 |
| Warning |
coding | HiddenField | 'slider' hides a field. | 1699 |
com/bric/multislider/PlafPaintUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Info |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 41 |
| Warning |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 45 |
| Warning |
naming | ConstantName | Name 'whites' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 45 |
| Warning |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 49 |
| Warning |
naming | ConstantName | Name 'blacks' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 49 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 59 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 62 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 76 |
| Warning |
misc | FinalParameters | Parameter shape should be final. | 76 |
| Warning |
misc | FinalParameters | Parameter pixelSize should be final. | 76 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 92 |
| Warning |
misc | FinalParameters | Parameter shape should be final. | 92 |
| Warning |
misc | FinalParameters | Parameter pixelSize should be final. | 92 |
| Warning |
misc | FinalParameters | Parameter focusColor should be final. | 92 |
| Warning |
misc | FinalParameters | Parameter changeRenderingHints should be final. | 92 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 148 |
| Warning |
misc | FinalParameters | Parameter r should be final. | 148 |
| Warning |
misc | FinalParameters | Parameter colors should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter x1 should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter y1 should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter x2 should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter y2 should be final. | 161 |
| Warning |
misc | FinalParameters | Parameter direction should be final. | 161 |
| Warning |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 197 |
| Warning |
misc | FinalParameters | Parameter name should be final. | 197 |
| Warning |
misc | FinalParameters | Parameter height should be final. | 197 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 197 |
| Warning |
misc | FinalParameters | Parameter positions should be final. | 197 |
| Warning |
misc | FinalParameters | Parameter colors should be final. | 197 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 226 |
| Warning |
misc | FinalParameters | Parameter c1 should be final. | 243 |
| Warning |
misc | FinalParameters | Parameter c2 should be final. | 243 |
| Warning |
misc | FinalParameters | Parameter p should be final. | 243 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 259 |
| Warning |
misc | FinalParameters | Parameter checkerSize should be final. | 261 |
| Warning |
misc | FinalParameters | Parameter checkerSize should be final. | 266 |
| Warning |
misc | FinalParameters | Parameter color1 should be final. | 266 |
| Warning |
misc | FinalParameters | Parameter color2 should be final. | 266 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 269 |
com/bric/multislider/ShapeBounds.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 33 |
| Warning |
misc | FinalParameters | Parameter shape should be final. | 41 |
| Warning |
misc | FinalParameters | Parameter shapes should be final. | 46 |
| Warning |
misc | FinalParameters | Parameter shape should be final. | 78 |
| Warning |
misc | FinalParameters | Parameter transform should be final. | 78 |
| Warning |
misc | FinalParameters | Parameter shape should be final. | 93 |
| Warning |
misc | FinalParameters | Parameter transform should be final. | 93 |
| Warning |
misc | FinalParameters | Parameter r should be final. | 93 |
| Warning |
misc | FinalParameters | Parameter shape should be final. | 107 |
| Warning |
misc | FinalParameters | Parameter r should be final. | 107 |
| Warning |
misc | FinalParameters | Parameter i should be final. | 117 |
| Info |
sizes | MethodLength | Method getBounds length is 240 lines (max allowed is 150). | 129 |
| Warning |
misc | FinalParameters | Parameter i should be final. | 129 |
| Warning |
misc | FinalParameters | Parameter r should be final. | 129 |
| Warning |
naming | LocalVariableName | Name 'x_coeff' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 143 |
| Warning |
naming | LocalVariableName | Name 'y_coeff' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 144 |
| Warning |
coding | SimplifyBooleanExpression | Expression can be simplified. | 147 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 156 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 171 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 173 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 175 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 177 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 183 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 185 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 187 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 189 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 197 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 199 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 201 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 203 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 221 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 223 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 230 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 232 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 240 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 242 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 244 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 246 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 268 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 278 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 280 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 292 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 294 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 302 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 304 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 311 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 321 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 323 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 335 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 337 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 345 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 347 |
com/bric/multislider/VistaMultiThumbSliderUI.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Warning |
misc | FinalParameters | Parameter slider should be final. | 20 |
| Warning |
whitespace | WhitespaceAfter | ';' is not followed by whitespace. | 23 |
| Warning |
design | DesignForExtension | Class 'VistaMultiThumbSliderUI' looks like designed for extension (can be subclassed), but the method 'getPreferredComponentDepth' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'VistaMultiThumbSliderUI' final or making the method 'getPreferredComponentDepth' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 35 |
| Warning |
design | DesignForExtension | Class 'VistaMultiThumbSliderUI' looks like designed for extension (can be subclassed), but the method 'getThumbSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'VistaMultiThumbSliderUI' final or making the method 'getThumbSize' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 41 |
| Warning |
design | DesignForExtension | Class 'VistaMultiThumbSliderUI' looks like designed for extension (can be subclassed), but the method 'paintTrack' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'VistaMultiThumbSliderUI' final or making the method 'paintTrack' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 63 |
| Warning |
design | DesignForExtension | Class 'VistaMultiThumbSliderUI' looks like designed for extension (can be subclassed), but the method 'getTrackOutline' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'VistaMultiThumbSliderUI' final or making the method 'getTrackOutline' static/final/abstract/empty, or adding allowed annotation for the method. | 94 |
| Warning |
design | DesignForExtension | Class 'VistaMultiThumbSliderUI' looks like designed for extension (can be subclassed), but the method 'paintThumb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'VistaMultiThumbSliderUI' final or making the method 'paintThumb' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
| Warning |
misc | FinalParameters | Parameter g should be final. | 102 |
| Warning |
misc | FinalParameters | Parameter thumbIndex should be final. | 102 |
| Warning |
misc | FinalParameters | Parameter selected should be final. | 102 |
| Warning |
modifier | RedundantModifier | Redundant 'final' modifier. | 144 |
| Warning |
misc | FinalParameters | Parameter c1 should be final. | 144 |
| Warning |
misc | FinalParameters | Parameter c2 should be final. | 144 |
| Warning |
misc | FinalParameters | Parameter f should be final. | 144 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 146 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 148 |
org/opentrafficsim/swing/graphs/SwingContourPlot.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 108 |
org/opentrafficsim/swing/graphs/SwingPlot.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | MethodLength | Method setChart length is 167 lines (max allowed is 150). | 75 |
org/opentrafficsim/swing/gui/AppearanceApplication.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'frameProperties' must be private and have accessor methods. | 72 |
| Warning |
coding | HiddenField | 'fontScaleName' hides a field. | 203 |
| Warning |
coding | HiddenField | 'fontScaleName' hides a field. | 240 |
| Warning |
coding | HiddenField | 'fontScaleName' hides a field. | 406 |
| Warning |
naming | StaticVariableName | Name 'PATH' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 498 |
org/opentrafficsim/swing/gui/AppearanceControl.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 36 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 36 |
org/opentrafficsim/swing/gui/CustomSimulation.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 65 |
org/opentrafficsim/swing/gui/OtsAnimationPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 605 |
org/opentrafficsim/swing/gui/OtsControlPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 469 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 497 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 511 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 519 |
org/opentrafficsim/swing/gui/OtsSimulationPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 99 |
org/opentrafficsim/swing/script/AbstractSimulationScript.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 201 |