Checkstyle Results

The following document contains the results of Checkstyle 10.15.0 with /config/dsol-checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
221	8	68	0

Files

File	I	W	E
org/opentrafficsim/core/animation/Drawable.java	1	0	0
org/opentrafficsim/core/dsol/OtsDevsRealTimeParallelMove.java	1	1	0
org/opentrafficsim/core/dsol/SynchronizedRedBlackTree.java	1	0	0
org/opentrafficsim/core/geometry/Bezier.java	2	0	0
org/opentrafficsim/core/geometry/ContinuousArc.java	0	1	0
org/opentrafficsim/core/geometry/ContinuousBezier.java	0	1	0
org/opentrafficsim/core/geometry/Flattener.java	3	8	0
org/opentrafficsim/core/geometry/FractionalLengthData.java	0	1	0
org/opentrafficsim/core/geometry/Fresnel.java	0	21	0
org/opentrafficsim/core/geometry/Ots2dSet.java	0	1	0
org/opentrafficsim/core/geometry/OtsGeometryUtil.java	0	2	0
org/opentrafficsim/core/geometry/OtsLine2d.java	0	3	0
org/opentrafficsim/core/gtu/Gtu.java	0	12	0
org/opentrafficsim/core/gtu/perception/DirectEgoPerception.java	0	13	0
org/opentrafficsim/core/gtu/plan/operational/Segment.java	0	2	0
org/opentrafficsim/core/gtu/plan/operational/Segments.java	0	1	0
org/opentrafficsim/core/network/Network.java	0	1	0

Rules

Category	Rule	Violations	Severity
blocks	NeedBraces	11	Warning
coding	HiddenField ignoreConstructorParameter: "true" ignoreSetter: "true"	4	Warning
design	DesignForExtension	2	Warning
	FinalClass	2	Warning
	VisibilityModifier	5	Warning
imports	UnusedImports	1	Warning
javadoc	JavadocPackage	1	Info
misc	TodoComment	9	Warning
modifier	RedundantModifier	10	Warning
naming	StaticVariableName	24	Warning
sizes	LineLength max: "128"	6	Info
	MethodLength	1	Info

Details

org/opentrafficsim/core/animation/Drawable.java

Severity	Category	Rule	Message	Line
Info	javadoc	JavadocPackage	Missing package-info.java file.	1

org/opentrafficsim/core/dsol/OtsDevsRealTimeParallelMove.java

Severity	Category	Rule	Message	Line
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	89
Info	sizes	MethodLength	Method run length is 336 lines (max allowed is 150).	91

org/opentrafficsim/core/dsol/SynchronizedRedBlackTree.java

Severity	Category	Rule	Message	Line
Info	sizes	LineLength	Line is longer than 128 characters (found 129).	14

org/opentrafficsim/core/geometry/Bezier.java

Severity	Category	Rule	Message	Line
Info	sizes	LineLength	Line is longer than 128 characters (found 130).	98
Info	sizes	LineLength	Line is longer than 128 characters (found 130).	117

org/opentrafficsim/core/geometry/ContinuousArc.java

Severity	Category	Rule	Message	Line
Warning	coding	HiddenField	'angle' hides a field.	124

org/opentrafficsim/core/geometry/ContinuousBezier.java

Severity	Category	Rule	Message	Line
Warning	design	VisibilityModifier	Variable 'points' must be private and have accessor methods.	53

org/opentrafficsim/core/geometry/Flattener.java

Severity	Category	Rule	Message	Line
Warning	modifier	RedundantModifier	Redundant 'public' modifier.	46
Warning	modifier	RedundantModifier	Redundant 'static' modifier.	46
Warning	modifier	RedundantModifier	Redundant 'public' modifier.	86
Warning	modifier	RedundantModifier	Redundant 'static' modifier.	86
Info	sizes	LineLength	Line is longer than 128 characters (found 133).	135
Warning	modifier	RedundantModifier	Redundant 'public' modifier.	167
Warning	modifier	RedundantModifier	Redundant 'static' modifier.	167
Info	sizes	LineLength	Line is longer than 128 characters (found 129).	248
Warning	modifier	RedundantModifier	Redundant 'public' modifier.	280
Warning	modifier	RedundantModifier	Redundant 'static' modifier.	280
Info	sizes	LineLength	Line is longer than 128 characters (found 129).	344

org/opentrafficsim/core/geometry/FractionalLengthData.java

Severity	Category	Rule	Message	Line
Warning	modifier	RedundantModifier	Redundant 'final' modifier.	170

org/opentrafficsim/core/geometry/Fresnel.java

Severity	Category	Rule	Message	Line
Warning	design	FinalClass	Class Fresnel should be declared as final.	19
Warning	naming	StaticVariableName	Name 'CN1' must match pattern '^[a-z][a-zA-Z0-9]*$'.	24
Warning	naming	StaticVariableName	Name 'CD1' must match pattern '^[a-z][a-zA-Z0-9]*$'.	33
Warning	naming	StaticVariableName	Name 'CN2' must match pattern '^[a-z][a-zA-Z0-9]*$'.	42
Warning	naming	StaticVariableName	Name 'CD2' must match pattern '^[a-z][a-zA-Z0-9]*$'.	52
Warning	naming	StaticVariableName	Name 'SN1' must match pattern '^[a-z][a-zA-Z0-9]*$'.	62
Warning	naming	StaticVariableName	Name 'SD1' must match pattern '^[a-z][a-zA-Z0-9]*$'.	71
Warning	naming	StaticVariableName	Name 'SN2' must match pattern '^[a-z][a-zA-Z0-9]*$'.	80
Warning	naming	StaticVariableName	Name 'SD2' must match pattern '^[a-z][a-zA-Z0-9]*$'.	90
Warning	naming	StaticVariableName	Name 'FN3' must match pattern '^[a-z][a-zA-Z0-9]*$'.	100
Warning	naming	StaticVariableName	Name 'FD3' must match pattern '^[a-z][a-zA-Z0-9]*$'.	110
Warning	naming	StaticVariableName	Name 'FN4' must match pattern '^[a-z][a-zA-Z0-9]*$'.	120
Warning	naming	StaticVariableName	Name 'FD4' must match pattern '^[a-z][a-zA-Z0-9]*$'.	130
Warning	naming	StaticVariableName	Name 'FN5' must match pattern '^[a-z][a-zA-Z0-9]*$'.	140
Warning	naming	StaticVariableName	Name 'FD5' must match pattern '^[a-z][a-zA-Z0-9]*$'.	151
Warning	naming	StaticVariableName	Name 'GN3' must match pattern '^[a-z][a-zA-Z0-9]*$'.	162
Warning	naming	StaticVariableName	Name 'GD3' must match pattern '^[a-z][a-zA-Z0-9]*$'.	172
Warning	naming	StaticVariableName	Name 'GN4' must match pattern '^[a-z][a-zA-Z0-9]*$'.	182
Warning	naming	StaticVariableName	Name 'GD4' must match pattern '^[a-z][a-zA-Z0-9]*$'.	192
Warning	naming	StaticVariableName	Name 'GN5' must match pattern '^[a-z][a-zA-Z0-9]*$'.	202
Warning	naming	StaticVariableName	Name 'GD5' must match pattern '^[a-z][a-zA-Z0-9]*$'.	213

org/opentrafficsim/core/geometry/Ots2dSet.java

Severity	Category	Rule	Message	Line
Warning	imports	UnusedImports	Unused import - java.awt.geom.Rectangle2D.	3

org/opentrafficsim/core/geometry/OtsGeometryUtil.java

Severity	Category	Rule	Message	Line
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	141
Warning	modifier	RedundantModifier	Redundant 'final' modifier.	142

org/opentrafficsim/core/geometry/OtsLine2d.java

Severity	Category	Rule	Message	Line
Warning	coding	HiddenField	'line2d' hides a field.	97
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	928
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	971

org/opentrafficsim/core/gtu/Gtu.java

Severity	Category	Rule	Message	Line
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	128
Warning	design	VisibilityModifier	Variable 'ALIGNED' must be private and have accessor methods.	129
Warning	naming	StaticVariableName	Name 'ALIGNED' must match pattern '^[a-z][a-zA-Z0-9]*$'.	129
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	132
Warning	design	VisibilityModifier	Variable 'ALIGN_COUNT' must be private and have accessor methods.	133
Warning	naming	StaticVariableName	Name 'ALIGN_COUNT' must match pattern '^[a-z][a-zA-Z0-9]*$'.	133
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	339
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	863
Warning	design	VisibilityModifier	Variable 'MOVE_EVENT' must be private and have accessor methods.	1027
Warning	naming	StaticVariableName	Name 'MOVE_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'.	1027
Warning	design	VisibilityModifier	Variable 'DESTROY_EVENT' must be private and have accessor methods.	1040
Warning	naming	StaticVariableName	Name 'DESTROY_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'.	1040

org/opentrafficsim/core/gtu/perception/DirectEgoPerception.java

Severity	Category	Rule	Message	Line
Warning	design	DesignForExtension	Class 'DirectEgoPerception' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DirectEgoPerception' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method.	161
Warning	design	DesignForExtension	Class 'DirectEgoPerception' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DirectEgoPerception' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method.	173
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	176
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	178
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	180
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	185
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	188
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	192
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	195
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	199
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	202
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	206
Warning	blocks	NeedBraces	'if' construct must use '{}'s.	209

org/opentrafficsim/core/gtu/plan/operational/Segment.java

Severity	Category	Rule	Message	Line
Warning	coding	HiddenField	'duration' hides a field.	79
Warning	coding	HiddenField	'duration' hides a field.	95

org/opentrafficsim/core/gtu/plan/operational/Segments.java

Severity	Category	Rule	Message	Line
Warning	design	FinalClass	Class Segments should be declared as final.	23

org/opentrafficsim/core/network/Network.java

Severity	Category	Rule	Message	Line
Warning	misc	TodoComment	Comment matches to-do format 'TODO:'.	773