Built by Maven

PMD Results

The following document contains the results of PMD 7.0.0.

Violations By Priority

Priority 2

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCfLcTacticalPlanner.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 500

Priority 3

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 493–496
UnnecessaryModifier Unnecessary modifier 'public' on interface 'RoadPosition': the interface is declared in an interface type 868

org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 1384–1387
SimplifiedTernary This conditional expression can be simplified with || or && 1637

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 123
UselessQualifiedThis Useless qualified this usage in the same class. 125
UselessQualifiedThis Useless qualified this usage in the same class. 126
UselessQualifiedThis Useless qualified this usage in the same class. 130
UselessQualifiedThis Useless qualified this usage in the same class. 131
CollapsibleIfStatements This if statement could be combined with its parent 319–322
UselessQualifiedThis Useless qualified this usage in the same class. 330

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 119–123

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionCollector': the interface is declared in an interface type 74
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionAccumulator': the interface is declared in an interface type 108
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionFinalizer': the interface is declared in an interface type 133

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectableFiltered.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 60–63

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 339–345

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 721–724
CollapsibleIfStatements This if statement could be combined with its parent 853–870

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'context'. 125

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 36

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'planDistance'. 673
UnusedFormalParameter Avoid unused method parameters such as 'width'. 674
UnusedFormalParameter Avoid unused method parameters such as 'from'. 674
UnusedFormalParameter Avoid unused method parameters such as 'startPosition'. 674
UnusedFormalParameter Avoid unused method parameters such as 'fromLine'. 674
UnusedFormalParameter Avoid unused method parameters such as 'toLine'. 675
UnusedLocalVariable Avoid unused local variables such as 'f'. 687
UnusedLocalVariable Avoid unused local variables such as 'cumulLcLength'. 691

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCfLcTacticalPlanner.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'currentLaneFine'. 144
UnusedLocalVariable Avoid unused local variables such as 'nextSplitNode'. 422
UnusedLocalVariable Avoid unused local variables such as 'nextLane'. 497

org/opentrafficsim/road/gtu/lane/tactical/LanePathInfo.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getReferenceLane': the method is already in a final class 45

org/opentrafficsim/road/gtu/lane/tactical/NextSplitInfo.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class 46

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 74–83

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'gtu'. 715

org/opentrafficsim/road/gtu/lane/tactical/util/AnticipationInfo.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on record 'AnticipationInfo': records are implicitly final 28

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 191–202
CollapsibleIfStatements This if statement could be combined with its parent 499–515

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Line
SimplifiedTernary This conditional expression can be simplified with || or && 98

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Desire.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 56
UnnecessaryModifier Unnecessary modifier 'final' on method 'leftIsLargerOrEqual': the method is already in a final class 73

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Rule Violation Line
SimplifiedTernary This conditional expression can be simplified with || or && 109

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 185–202
UnusedPrivateMethod Avoid unused private methods such as 'quickIntersectionScan(Parameters, SpeedLimitInfo, CarFollowingModel, Speed, LateralDirectionality, IntersectionPerception)'. 592

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Line
SimplifiedTernary This conditional expression can be simplified with || or && 312–313
SimplifiedTernary This conditional expression can be simplified with || or && 329–330
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type 421

org/opentrafficsim/road/gtu/strategical/RouteGenerator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 117–120
UnnecessarySemicolon Unnecessary semicolon 163

org/opentrafficsim/road/network/RoadNetwork.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on record 'LaneChangeInfoEdge': records are implicitly static 526

org/opentrafficsim/road/network/factory/LaneFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 124
UnusedFormalParameter Avoid unused method parameters such as 'simulator'. 432

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 301–305
CollapsibleIfStatements This if statement could be combined with its parent 341–345

org/opentrafficsim/road/network/lane/LanePosition.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getLocation': the method is already in a final class 31

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 403–424
CollapsibleIfStatements This if statement could be combined with its parent 787–806

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 278–281
EmptyCatchBlock Avoid empty catch blocks 1104–1107
EmptyCatchBlock Avoid empty catch blocks 1126–1129
EmptyCatchBlock Avoid empty catch blocks 1139–1142
EmptyCatchBlock Avoid empty catch blocks 1198–1201
EmptyCatchBlock Avoid empty catch blocks 1219–1222
EmptyCatchBlock Avoid empty catch blocks 1232–1235
UnnecessaryModifier Unnecessary modifier 'static' on record 'ConflictBuilderRecordSmall': records are implicitly static 1352
UnnecessaryModifier Unnecessary modifier 'static' on record 'ConflictBuilderRecordBig': records are implicitly static 1467

org/opentrafficsim/road/network/lane/conflict/ConflictPriority.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isPriority': the method is already in a final class 35
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGiveWay': the method is already in a final class 44
UnnecessaryModifier Unnecessary modifier 'final' on method 'isStop': the method is already in a final class 53
UnnecessaryModifier Unnecessary modifier 'final' on method 'isAllStop': the method is already in a final class 62
UnnecessaryModifier Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class 71

org/opentrafficsim/road/network/lane/object/BusStop.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'name'. 42
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 60

org/opentrafficsim/road/network/lane/object/Distraction.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 37

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 52

org/opentrafficsim/road/network/lane/object/detector/TrafficLightDetector.java

Rule Violation Line
UnnecessaryReturn Unnecessary return statement 253

org/opentrafficsim/road/network/lane/object/trafficlight/TrafficLightColor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isRedOrYellow': the method is already in a final class 31
UnnecessaryModifier Unnecessary modifier 'final' on method 'isRed': the method is already in a final class 37
UnnecessaryModifier Unnecessary modifier 'final' on method 'isYellow': the method is already in a final class 43
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGreen': the method is already in a final class 49
UnnecessaryModifier Unnecessary modifier 'final' on method 'isPreGreen': the method is already in a final class 55
UnnecessaryModifier Unnecessary modifier 'final' on method 'isBlack': the method is already in a final class 61

org/opentrafficsim/road/network/speed/SpeedInfoCurvature.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getSpeedForLateralAcceleration': the method is already in a final class 43

org/opentrafficsim/road/od/OdApplier.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on record 'GeneratorObjects': records are implicitly static 928

Priority 4

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Line
UselessParentheses Useless parentheses. 785
UselessParentheses Useless parentheses. 991

org/opentrafficsim/road/gtu/generator/Platoons.java

Rule Violation Line
UnnecessaryImport Unused import 'java.util.Set' 7

org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type 301
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type 474
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_MOVE_EVENT' is already in scope because it is declared in an enclosing type 546
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type 1415
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type 1423

org/opentrafficsim/road/gtu/lane/perception/categories/WienerProcess.java

Rule Violation Line
UselessParentheses Useless parentheses. 87

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/AccPerception.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LongitudinalControllerPerception': 'RANGE' is already in scope because it is inherited by an enclosing type 86

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/CaccPerception.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LongitudinalControllerPerception': 'RANGE' is already in scope because it is inherited by an enclosing type 87

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 263

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/Estimation.java

Rule Violation Line
UselessParentheses Useless parentheses. 87

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Rule Violation Line
UselessParentheses Useless parentheses. 80

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Rule Violation Line
UselessParentheses Useless parentheses. 45

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Rule Violation Line
UselessParentheses Useless parentheses. 87

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Rule Violation Line
UselessParentheses Useless parentheses. 40

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Rule Violation Line
UselessParentheses Useless parentheses. 55

org/opentrafficsim/road/gtu/lane/plan/operational/LaneBasedOperationalPlan.java

Rule Violation Line
UselessParentheses Useless parentheses. 148

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Line
UselessParentheses Useless parentheses. 615
UselessParentheses Useless parentheses. 615
UselessParentheses Useless parentheses. 753

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope 301
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope 315
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope 320
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationLaneChangePlan' is already in scope 323

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedTacticalPlanner.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedTacticalPlanner': 'mostOnSide' is already in scope 88

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveRoute.java

Rule Violation Line
UselessParentheses Useless parentheses. 117

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type 188
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type 210
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type 228
UselessParentheses Useless parentheses. 762

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/GapAcceptance.java

Rule Violation Line
UnnecessaryImport Unused static import 'org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.GapAcceptance.egoAcceleration' 3

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Tailgating.java

Rule Violation Line
UnnecessaryImport Unused static import 'org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Tailgating.socialPressure' 3

org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalRoutePlanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 172

org/opentrafficsim/road/network/RoadNetwork.java

Rule Violation Line
UselessParentheses Useless parentheses. 337

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Line
UselessParentheses Useless parentheses. 282
UselessParentheses Useless parentheses. 284
UselessParentheses Useless parentheses. 322
UselessParentheses Useless parentheses. 324
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'DETECTOR_ADD_EVENT' is already in scope because it is declared in an enclosing type 385
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'DETECTOR_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 396
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type 598
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 608
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type 775
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 808
UselessParentheses Useless parentheses. 1051
UselessParentheses Useless parentheses. 1119

org/opentrafficsim/road/network/lane/object/detector/LaneDetector.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneDetector': 'DEFAULT_DETECTOR_ELEVATION' is already in scope because it is declared in an enclosing type 111
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneDetector': 'DETECTOR_TRIGGER_EVENT' is already in scope because it is declared in an enclosing type 150

org/opentrafficsim/road/network/lane/object/detector/TrafficLightDetector.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_ENTRY_EVENT' is already in scope because it is declared in an enclosing type 193
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_EXIT_EVENT' is already in scope because it is declared in an enclosing type 206

org/opentrafficsim/road/od/OdApplier.java

Rule Violation Line
UselessParentheses Useless parentheses. 336
UselessParentheses Useless parentheses. 341

org/opentrafficsim/road/od/SplitFraction.java

Rule Violation Line
UselessParentheses Useless parentheses. 175

Files

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 493–496
UselessParentheses Useless parentheses. 4 785
UnnecessaryModifier Unnecessary modifier 'public' on interface 'RoadPosition': the interface is declared in an interface type 3 868
UselessParentheses Useless parentheses. 4 991

org/opentrafficsim/road/gtu/generator/Platoons.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'java.util.Set' 4 7

org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type 4 301
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type 4 474
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_MOVE_EVENT' is already in scope because it is declared in an enclosing type 4 546
EmptyCatchBlock Avoid empty catch blocks 3 1384–1387
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type 4 1415
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type 4 1423
SimplifiedTernary This conditional expression can be simplified with || or && 3 1637

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 123
UselessQualifiedThis Useless qualified this usage in the same class. 3 125
UselessQualifiedThis Useless qualified this usage in the same class. 3 126
UselessQualifiedThis Useless qualified this usage in the same class. 3 130
UselessQualifiedThis Useless qualified this usage in the same class. 3 131
CollapsibleIfStatements This if statement could be combined with its parent 3 319–322
UselessQualifiedThis Useless qualified this usage in the same class. 3 330

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 119–123

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionCollector': the interface is declared in an interface type 3 74
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionAccumulator': the interface is declared in an interface type 3 108
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionFinalizer': the interface is declared in an interface type 3 133

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectableFiltered.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 60–63

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 339–345

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 721–724
CollapsibleIfStatements This if statement could be combined with its parent 3 853–870

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'context'. 3 125

org/opentrafficsim/road/gtu/lane/perception/categories/WienerProcess.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 87

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/AccPerception.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LongitudinalControllerPerception': 'RANGE' is already in scope because it is inherited by an enclosing type 4 86

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/CaccPerception.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LongitudinalControllerPerception': 'RANGE' is already in scope because it is inherited by an enclosing type 4 87

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 263

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/Estimation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 87

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 80

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 36

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 45

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 87

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 40

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 55

org/opentrafficsim/road/gtu/lane/plan/operational/LaneBasedOperationalPlan.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 148

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 615
UselessParentheses Useless parentheses. 4 615
UnusedFormalParameter Avoid unused method parameters such as 'planDistance'. 3 673
UnusedFormalParameter Avoid unused method parameters such as 'width'. 3 674
UnusedFormalParameter Avoid unused method parameters such as 'from'. 3 674
UnusedFormalParameter Avoid unused method parameters such as 'startPosition'. 3 674
UnusedFormalParameter Avoid unused method parameters such as 'fromLine'. 3 674
UnusedFormalParameter Avoid unused method parameters such as 'toLine'. 3 675
UnusedLocalVariable Avoid unused local variables such as 'f'. 3 687
UnusedLocalVariable Avoid unused local variables such as 'cumulLcLength'. 3 691
UselessParentheses Useless parentheses. 4 753

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope 4 301
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope 4 315
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope 4 320
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationLaneChangePlan' is already in scope 4 323

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCfLcTacticalPlanner.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'currentLaneFine'. 3 144
UnusedLocalVariable Avoid unused local variables such as 'nextSplitNode'. 3 422
UnusedLocalVariable Avoid unused local variables such as 'nextLane'. 3 497
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 500

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedTacticalPlanner.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneBasedTacticalPlanner': 'mostOnSide' is already in scope 4 88

org/opentrafficsim/road/gtu/lane/tactical/LanePathInfo.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getReferenceLane': the method is already in a final class 3 45

org/opentrafficsim/road/gtu/lane/tactical/NextSplitInfo.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class 3 46

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 74–83

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveRoute.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 117

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type 4 188
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type 4 210
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type 4 228
UnusedFormalParameter Avoid unused method parameters such as 'gtu'. 3 715
UselessParentheses Useless parentheses. 4 762

org/opentrafficsim/road/gtu/lane/tactical/util/AnticipationInfo.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on record 'AnticipationInfo': records are implicitly final 3 28

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 191–202
CollapsibleIfStatements This if statement could be combined with its parent 3 499–515

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Priority Line
SimplifiedTernary This conditional expression can be simplified with || or && 3 98

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Desire.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'get': the method is already in a final class 3 56
UnnecessaryModifier Unnecessary modifier 'final' on method 'leftIsLargerOrEqual': the method is already in a final class 3 73

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/GapAcceptance.java

Rule Violation Priority Line
UnnecessaryImport Unused static import 'org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.GapAcceptance.egoAcceleration' 4 3

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Rule Violation Priority Line
SimplifiedTernary This conditional expression can be simplified with || or && 3 109

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 185–202
UnusedPrivateMethod Avoid unused private methods such as 'quickIntersectionScan(Parameters, SpeedLimitInfo, CarFollowingModel, Speed, LateralDirectionality, IntersectionPerception)'. 3 592

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Priority Line
SimplifiedTernary This conditional expression can be simplified with || or && 3 312–313
SimplifiedTernary This conditional expression can be simplified with || or && 3 329–330
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type 3 421

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Tailgating.java

Rule Violation Priority Line
UnnecessaryImport Unused static import 'org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Tailgating.socialPressure' 4 3

org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalRoutePlanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 172

org/opentrafficsim/road/gtu/strategical/RouteGenerator.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 117–120
UnnecessarySemicolon Unnecessary semicolon 3 163

org/opentrafficsim/road/network/RoadNetwork.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 337
UnnecessaryModifier Unnecessary modifier 'static' on record 'LaneChangeInfoEdge': records are implicitly static 3 526

org/opentrafficsim/road/network/factory/LaneFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 124
UnusedFormalParameter Avoid unused method parameters such as 'simulator'. 3 432

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 282
UselessParentheses Useless parentheses. 4 284
CollapsibleIfStatements This if statement could be combined with its parent 3 301–305
UselessParentheses Useless parentheses. 4 322
UselessParentheses Useless parentheses. 4 324
CollapsibleIfStatements This if statement could be combined with its parent 3 341–345
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'DETECTOR_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 385
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'DETECTOR_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 396
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 598
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 608
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type 4 775
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Lane': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type 4 808
UselessParentheses Useless parentheses. 4 1051
UselessParentheses Useless parentheses. 4 1119

org/opentrafficsim/road/network/lane/LanePosition.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getLocation': the method is already in a final class 3 31

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 403–424
CollapsibleIfStatements This if statement could be combined with its parent 3 787–806

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 278–281
EmptyCatchBlock Avoid empty catch blocks 3 1104–1107
EmptyCatchBlock Avoid empty catch blocks 3 1126–1129
EmptyCatchBlock Avoid empty catch blocks 3 1139–1142
EmptyCatchBlock Avoid empty catch blocks 3 1198–1201
EmptyCatchBlock Avoid empty catch blocks 3 1219–1222
EmptyCatchBlock Avoid empty catch blocks 3 1232–1235
UnnecessaryModifier Unnecessary modifier 'static' on record 'ConflictBuilderRecordSmall': records are implicitly static 3 1352
UnnecessaryModifier Unnecessary modifier 'static' on record 'ConflictBuilderRecordBig': records are implicitly static 3 1467

org/opentrafficsim/road/network/lane/conflict/ConflictPriority.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isPriority': the method is already in a final class 3 35
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGiveWay': the method is already in a final class 3 44
UnnecessaryModifier Unnecessary modifier 'final' on method 'isStop': the method is already in a final class 3 53
UnnecessaryModifier Unnecessary modifier 'final' on method 'isAllStop': the method is already in a final class 3 62
UnnecessaryModifier Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class 3 71

org/opentrafficsim/road/network/lane/object/BusStop.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'name'. 3 42
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 60

org/opentrafficsim/road/network/lane/object/Distraction.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 37

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 52

org/opentrafficsim/road/network/lane/object/detector/LaneDetector.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneDetector': 'DEFAULT_DETECTOR_ELEVATION' is already in scope because it is declared in an enclosing type 4 111
UnnecessaryFullyQualifiedName Unnecessary qualifier 'LaneDetector': 'DETECTOR_TRIGGER_EVENT' is already in scope because it is declared in an enclosing type 4 150

org/opentrafficsim/road/network/lane/object/detector/TrafficLightDetector.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_ENTRY_EVENT' is already in scope because it is declared in an enclosing type 4 193
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_EXIT_EVENT' is already in scope because it is declared in an enclosing type 4 206
UnnecessaryReturn Unnecessary return statement 3 253

org/opentrafficsim/road/network/lane/object/trafficlight/TrafficLightColor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'isRedOrYellow': the method is already in a final class 3 31
UnnecessaryModifier Unnecessary modifier 'final' on method 'isRed': the method is already in a final class 3 37
UnnecessaryModifier Unnecessary modifier 'final' on method 'isYellow': the method is already in a final class 3 43
UnnecessaryModifier Unnecessary modifier 'final' on method 'isGreen': the method is already in a final class 3 49
UnnecessaryModifier Unnecessary modifier 'final' on method 'isPreGreen': the method is already in a final class 3 55
UnnecessaryModifier Unnecessary modifier 'final' on method 'isBlack': the method is already in a final class 3 61

org/opentrafficsim/road/network/speed/SpeedInfoCurvature.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getSpeedForLateralAcceleration': the method is already in a final class 3 43

org/opentrafficsim/road/od/OdApplier.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 336
UselessParentheses Useless parentheses. 4 341
UnnecessaryModifier Unnecessary modifier 'static' on record 'GeneratorObjects': records are implicitly static 3 928

org/opentrafficsim/road/od/SplitFraction.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 175

Suppressed Violations

Filename Rule message Suppression type Reason
org/opentrafficsim/road/gtu/generator/LaneBasedGtuGenerator.java Avoid unused private methods such as 'generateCharacteristics()'. @suppresswarnings
org/opentrafficsim/road/gtu/generator/LaneBasedGtuGenerator.java Avoid unused private methods such as 'enable()'. @suppresswarnings
org/opentrafficsim/road/gtu/generator/LaneBasedGtuGenerator.java Avoid unused private methods such as 'disable(Lane)'. @suppresswarnings
org/opentrafficsim/road/gtu/generator/LaneBasedGtuGenerator.java Avoid unused private methods such as 'tryToPlaceGTU(GeneratorLanePosition)'. @suppresswarnings
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/NeighborsUtil.java Avoid unused local variables such as 'gtu'. @suppresswarnings