The following document contains the results of Checkstyle 8.35 with development/dsol-checks.xml ruleset. 
| Files |  |
 |
 |
|---|---|---|---|
| 381 | 71 | 102 | 0 |
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | AvoidNestedBlocks
|
3 | |
| EmptyBlock | 1 | | |
LeftCurly
|
6 | | |
| coding | InnerAssignment | 2 | |
| design | DesignForExtension | 1 | |
| HideUtilityClassConstructor | 2 | | |
| VisibilityModifier | 16 | | |
| imports | UnusedImports | 6 | |
| javadoc | JavadocPackage | 1 | |
| JavadocVariable | 3 | | |
| misc | TodoComment | 52 | |
| modifier | RedundantModifier | 2 | |
| naming | StaticVariableName | 8 | |
| sizes | LineLength
|
28 | |
| MethodLength | 11 | | |
| ParameterNumber | 31 | |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 339 |
|
blocks | AvoidNestedBlocks | Avoid nested blocks. | 366 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 399 |
|
blocks | AvoidNestedBlocks | Avoid nested blocks. | 426 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 1066 |
|
sizes | LineLength | Line is longer than 128 characters (found 132). | 1167 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 142). | 82 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 322 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
design | DesignForExtension | Class 'ArrivalsHeadwayGenerator' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ArrivalsHeadwayGenerator' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 164 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 42 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 154 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 158 |
|
naming | StaticVariableName | Name 'CACHING' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 159 |
|
design | VisibilityModifier | Variable 'CACHING' must be private and have accessor methods. | 159 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 162 |
|
naming | StaticVariableName | Name 'CACHED_POSITION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 163 |
|
design | VisibilityModifier | Variable 'CACHED_POSITION' must be private and have accessor methods. | 163 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 166 |
|
naming | StaticVariableName | Name 'NON_CACHED_POSITION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 167 |
|
design | VisibilityModifier | Variable 'NON_CACHED_POSITION' must be private and have accessor methods. | 167 |
|
coding | InnerAssignment | Inner assignments should be avoided. | 984 |
|
sizes | MethodLength | Method length is 215 lines (max allowed is 150). | 1266 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1372 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
design | VisibilityModifier | Variable 'eventMargin' must be private and have accessor methods. | 153 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 159 |
|
naming | StaticVariableName | Name 'CACHING' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 160 |
|
design | VisibilityModifier | Variable 'CACHING' must be private and have accessor methods. | 160 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 163 |
|
naming | StaticVariableName | Name 'CACHED_POSITION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 164 |
|
design | VisibilityModifier | Variable 'CACHED_POSITION' must be private and have accessor methods. | 164 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 167 |
|
naming | StaticVariableName | Name 'NON_CACHED_POSITION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 168 |
|
design | VisibilityModifier | Variable 'NON_CACHED_POSITION' must be private and have accessor methods. | 168 |
|
blocks | EmptyBlock | Must have at least one statement. | 592 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1357 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1358 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 376 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 132). | 41 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 131). | 37 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 46 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 8). | 78 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 8). | 48 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 132). | 68 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
design | VisibilityModifier | Variable 'object' must be private and have accessor methods. | 249 |
|
design | VisibilityModifier | Variable 'distance' must be private and have accessor methods. | 252 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | MethodLength | Method length is 186 lines (max allowed is 150). | 201 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1248 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | UnusedImports | Unused import - org.opentrafficsim.road.gtu.lane.Break. | 22 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 47 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 117 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 447 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 458 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 132). | 228 |
|
sizes | LineLength | Line is longer than 128 characters (found 130). | 230 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 8). | 106 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 57 |
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 118 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 126 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 131). | 20 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 22 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 8). | 60 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
naming | StaticVariableName | Name 'MIN_LC_LENGTH_FACTOR' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 78 |
|
design | VisibilityModifier | Variable 'MIN_LC_LENGTH_FACTOR' must be private and have accessor methods. | 78 |
|
sizes | MethodLength | Method length is 207 lines (max allowed is 150). | 226 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 377 |
|
sizes | LineLength | Line is longer than 128 characters (found 131). | 549 |
|
sizes | ParameterNumber | More than 7 parameters (found 10). | 616 |
|
sizes | ParameterNumber | More than 7 parameters (found 10). | 681 |
|
sizes | ParameterNumber | More than 7 parameters (found 11). | 711 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 731 |
|
sizes | ParameterNumber | More than 7 parameters (found 10). | 805 |
|
sizes | ParameterNumber | More than 7 parameters (found 10). | 897 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | UnusedImports | Unused import - org.opentrafficsim.core.gtu.GTUDirectionality. | 25 |
|
imports | UnusedImports | Unused import - org.opentrafficsim.core.gtu.RelativePosition. | 27 |
|
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 61 |
|
sizes | MethodLength | Method length is 154 lines (max allowed is 150). | 295 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | MethodLength | Method length is 201 lines (max allowed is 150). | 304 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 131). | 26 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 235 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 383 |
|
sizes | MethodLength | Method length is 178 lines (max allowed is 150). | 448 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 675 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 58 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 130). | 90 |
|
sizes | LineLength | Line is longer than 128 characters (found 130). | 92 |
|
sizes | LineLength | Line is longer than 128 characters (found 131). | 120 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 13 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 46 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 51 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 46 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 33 |
|
sizes | LineLength | Line is longer than 128 characters (found 144). | 35 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 34 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 63 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 33 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 126 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 96 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 111 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | MethodLength | Method length is 187 lines (max allowed is 150). | 97 |
|
sizes | MethodLength | Method length is 165 lines (max allowed is 150). | 298 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 30 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
naming | StaticVariableName | Name 'CROSSSTANDING' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 107 |
|
sizes | LineLength | Line is longer than 128 characters (found 136). | 119 |
|
sizes | MethodLength | Method length is 186 lines (max allowed is 150). | 138 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 540 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 132). | 45 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 109 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 136 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 140 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 157 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 101 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 8). | 38 |
|
sizes | ParameterNumber | More than 7 parameters (found 8). | 95 |
|
sizes | ParameterNumber | More than 7 parameters (found 8). | 184 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | UnusedImports | Unused import - org.opentrafficsim.road.gtu.lane.Break. | 24 |
|
sizes | ParameterNumber | More than 7 parameters (found 10). | 455 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 523 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 66 |
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 127 |
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 204 |
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 270 |
|
sizes | MethodLength | Method length is 196 lines (max allowed is 150). | 289 |
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 290 |
|
modifier | RedundantModifier | Redundant 'public' modifier. | 499 |
|
sizes | ParameterNumber | More than 7 parameters (found 9). | 528 |
|
sizes | ParameterNumber | More than 7 parameters (found 14). | 723 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 130). | 115 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 133). | 583 |
|
sizes | LineLength | Line is longer than 128 characters (found 132). | 694 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 244 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 50 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 219 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | ParameterNumber | More than 7 parameters (found 8). | 410 |
|
sizes | LineLength | Line is longer than 128 characters (found 133). | 480 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 295 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 705 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | UnusedImports | Unused import - org.djutils.metadata.MetaData. | 29 |
|
imports | UnusedImports | Unused import - org.djutils.metadata.ObjectDescriptor. | 30 |
|
blocks | LeftCurly | '{' at column 32 should be on a new line. | 471 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1011 |
|
blocks | AvoidNestedBlocks | Avoid nested blocks. | 1033 |
|
blocks | LeftCurly | '{' at column 50 should be on a new line. | 1167 |
|
coding | InnerAssignment | Inner assignments should be avoided. | 1214 |
|
sizes | LineLength | Line is longer than 128 characters (found 160). | 1389 |
|
sizes | LineLength | Line is longer than 128 characters (found 153). | 1400 |
|
sizes | LineLength | Line is longer than 128 characters (found 162). | 1405 |
|
sizes | LineLength | Line is longer than 128 characters (found 153). | 1463 |
|
sizes | LineLength | Line is longer than 128 characters (found 162). | 1468 |
|
sizes | LineLength | Line is longer than 128 characters (found 172). | 1479 |
|
sizes | LineLength | Line is longer than 128 characters (found 160). | 1483 |
|
blocks | LeftCurly | '{' at column 41 should be on a new line. | 1506 |
|
blocks | LeftCurly | '{' at column 39 should be on a new line. | 1534 |
|
blocks | LeftCurly | '{' at column 76 should be on a new line. | 1815 |
|
blocks | LeftCurly | '{' at column 80 should be on a new line. | 1835 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 301 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 298 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1367 |
|
design | VisibilityModifier | Variable 'cbr' must be private and have accessor methods. | 1379 |
|
design | VisibilityModifier | Variable 'nrOfJobs' must be private and have accessor methods. | 1382 |
|
design | VisibilityModifier | Variable 'cbr' must be private and have accessor methods. | 1521 |
|
design | VisibilityModifier | Variable 'nrOfJobs' must be private and have accessor methods. | 1524 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 54 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
|
design | VisibilityModifier | Variable 'cbr' must be private and have accessor methods. | 422 |
|
design | VisibilityModifier | Variable 'nrOfJobs' must be private and have accessor methods. | 425 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 558 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 128 characters (found 136). | 80 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 561 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 640 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | MethodLength | Method length is 186 lines (max allowed is 150). | 263 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 336 |