Checkstyle Results

The following document contains the results of Checkstyle 6.2 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
234 29 122 0

Files

File  I  W  E
org/opentrafficsim/graphs/Axis.java 0 13 0
org/opentrafficsim/graphs/ContourPlot.java 1 2 0
org/opentrafficsim/graphs/DataSampler.java 0 4 0
org/opentrafficsim/graphs/FundamentalDiagramLane.java 0 1 0
org/opentrafficsim/graphs/TrajectoryPlot.java 0 11 0
org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java 0 5 0
org/opentrafficsim/road/gtu/generator/DualHeadwaySpaceChecker.java 0 1 0
org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java 1 15 0
org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java 1 1 0
org/opentrafficsim/road/gtu/generator/SpaceChecker.java 0 1 0
org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java 1 2 0
org/opentrafficsim/road/gtu/lane/LaneBasedIndividualGTU.java 1 0 0
org/opentrafficsim/road/gtu/lane/perception/PerceivedObjectType.java 0 2 0
org/opentrafficsim/road/gtu/lane/perception/categories/IntersectionPerception.java 0 4 0
org/opentrafficsim/road/gtu/lane/perception/headway/package-info.java 0 1 0
org/opentrafficsim/road/gtu/lane/perception/package-info.java 0 1 0
org/opentrafficsim/road/gtu/lane/plan/operational/LaneBasedOperationalPlan.java 0 3 0
org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java 3 0 0
org/opentrafficsim/road/gtu/lane/tactical/AbstractLaneBasedTacticalPlanner.java 1 0 0
org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java 1 3 0
org/opentrafficsim/road/gtu/lane/tactical/directedlanechange/AbstractDirectedLaneChangeModel.java 1 0 0
org/opentrafficsim/road/gtu/lane/tactical/following/AbstractIDM.java 1 0 0
org/opentrafficsim/road/gtu/lane/tactical/lanechangemobil/LaneChangeModel.java 0 1 0
org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java 5 0 0
org/opentrafficsim/road/gtu/lane/tactical/toledo/ToledoCFTester.java 0 2 0
org/opentrafficsim/road/gtu/lane/tactical/toledo/package-info.java 0 1 0
org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java 2 0 0
org/opentrafficsim/road/gtu/lane/tactical/util/TrafficLightUtil.java 0 1 0
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/package-info.java 0 1 0
org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalPlannerNone.java 0 18 0
org/opentrafficsim/road/gtu/strategical/od/Interpolation.java 1 0 0
org/opentrafficsim/road/gtu/strategical/od/ODMatrix.java 1 1 0
org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java 0 5 0
org/opentrafficsim/road/network/animation/LaneAnimation.java 1 0 0
org/opentrafficsim/road/network/factory/LaneFactory.java 1 0 0
org/opentrafficsim/road/network/lane/DirectedLanePosition.java 0 12 0
org/opentrafficsim/road/network/lane/Lane.java 0 2 0
org/opentrafficsim/road/network/lane/LaneDirection.java 0 1 0
org/opentrafficsim/road/network/lane/conflict/package-info.java 0 1 0
org/opentrafficsim/road/network/lane/object/AbstractLaneBasedObject.java 1 0 0
org/opentrafficsim/road/network/lane/object/LaneBlock.java 0 1 0
org/opentrafficsim/road/network/lane/object/sensor/AbstractSensor.java 1 0 0
org/opentrafficsim/road/network/lane/object/sensor/SensorAnimation.java 0 1 0
org/opentrafficsim/road/network/lane/object/sensor/TrafficLightSensor.java 3 2 0
org/opentrafficsim/road/network/sampling/RoadSampler.java 0 1 0
org/opentrafficsim/road/network/sampling/SpeedLimit.java 0 1 0
org/opentrafficsim/road/network/speed/SpeedLimitProspect.java 1 0 0

Rules

Category Rule Violations Severity
blocks AvoidNestedBlocks
  • allowInSwitchCase: "true"
 2  Warning
EmptyBlock 7  Warning
NeedBraces 8  Warning
design DesignForExtension 46  Warning
HideUtilityClassConstructor 1  Warning
VisibilityModifier 7  Warning
imports UnusedImports 7  Warning
javadoc JavadocMethod 1  Warning
JavadocVariable 4  Warning
misc FinalParameters 22  Warning
NewlineAtEndOfFile
  • fileExtensions: "java"
  • lineSeparator: "crlf"
 6  Warning
TodoComment 8  Warning
modifier RedundantModifier 2  Warning
sizes LineLength
  • max: "128"
 14  Info
MethodLength 6  Info
ParameterNumber 9  Info
whitespace NoWhitespaceBefore 1  Warning

Details

org/opentrafficsim/graphs/Axis.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getRelativeBin' is not designed for extension - needs to be abstract, final or empty. 75
 Warning design DesignForExtension Method 'adjustMaximumValue' is not designed for extension - needs to be abstract, final or empty. 84
 Warning design DesignForExtension Method 'getValue' is not designed for extension - needs to be abstract, final or empty. 95
 Warning design DesignForExtension Method 'getAggregatedBinCount' is not designed for extension - needs to be abstract, final or empty. 103
 Warning design DesignForExtension Method 'getBinCount' is not designed for extension - needs to be abstract, final or empty. 112
 Warning design DesignForExtension Method 'getCurrentGranularity' is not designed for extension - needs to be abstract, final or empty. 121
 Warning design DesignForExtension Method 'setCurrentGranularity' is not designed for extension - needs to be abstract, final or empty. 131
 Warning design DesignForExtension Method 'getMaximumValue' is not designed for extension - needs to be abstract, final or empty. 148
 Warning design DesignForExtension Method 'setMaximumValue' is not designed for extension - needs to be abstract, final or empty. 158
 Warning design DesignForExtension Method 'getMinimumValue' is not designed for extension - needs to be abstract, final or empty. 171
 Warning design DesignForExtension Method 'getFormat' is not designed for extension - needs to be abstract, final or empty. 189
 Warning design DesignForExtension Method 'getShortName' is not designed for extension - needs to be abstract, final or empty. 198
 Warning design DesignForExtension Method 'getName' is not designed for extension - needs to be abstract, final or empty. 207

org/opentrafficsim/graphs/ContourPlot.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 9). 123
 Warning blocks EmptyBlock Must have at least one statement. 202
 Warning design DesignForExtension Method 'createChart' is not designed for extension - needs to be abstract, final or empty. 267

org/opentrafficsim/graphs/DataSampler.java

Severity Category Rule Message Line
 Warning misc NewlineAtEndOfFile File does not end with a newline.
 Warning blocks EmptyBlock Must have at least one statement. 71
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 77
 Warning whitespace NoWhitespaceBefore ';' is preceded with whitespace. 84

org/opentrafficsim/graphs/FundamentalDiagramLane.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'flow' must be private and have accessor methods. 139

org/opentrafficsim/graphs/TrajectoryPlot.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'sample' is not designed for extension - needs to be abstract, final or empty. 182
 Warning blocks EmptyBlock Must have at least one statement. 256
 Warning design DesignForExtension Method 'createChart' is not designed for extension - needs to be abstract, final or empty. 291
 Warning misc FinalParameters Parameter gtu should be final. 595
 Warning misc FinalParameters Parameter lane should be final. 595
 Warning misc FinalParameters Parameter position should be final. 595
 Warning misc FinalParameters Parameter item should be final. 634
 Warning misc FinalParameters Parameter item should be final. 641
 Warning misc FinalParameters Parameter item should be final. 653
 Warning design VisibilityModifier Variable 'distance' must be private and have accessor methods. 676
 Warning design VisibilityModifier Variable 'time' must be private and have accessor methods. 679

org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - org.opentrafficsim.road.gtu.lane.perception.LanePerception. 32
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 309
 Warning blocks AvoidNestedBlocks Avoid nested blocks. 337
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 370
 Warning blocks AvoidNestedBlocks Avoid nested blocks. 398

org/opentrafficsim/road/gtu/generator/DualHeadwaySpaceChecker.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'checkEnoughSpace' is not designed for extension - needs to be abstract, final or empty. 19

org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'reTryInterval' must be private and have accessor methods. 78
 Warning design VisibilityModifier Variable 'initialLongitudinalPositions' must be private and have accessor methods. 81
 Warning design VisibilityModifier Variable 'roomChecker' must be private and have accessor methods. 84
 Warning design VisibilityModifier Variable 'gtuColorer' must be private and have accessor methods. 87
 Info sizes ParameterNumber More than 7 parameters (found 10). 108
 Warning misc FinalParameters Parameter id should be final. 108
 Warning misc FinalParameters Parameter roomChecker should be final. 111
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 281
 Warning design DesignForExtension Method 'getGeneratedGTUs' is not designed for extension - needs to be abstract, final or empty. 289
 Warning design DesignForExtension Method 'setGeneratedGTUs' is not designed for extension - needs to be abstract, final or empty. 297
 Warning misc FinalParameters Parameter generatedGTUs should be final. 297
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 306
 Warning design DesignForExtension Method 'getEndTime' is not designed for extension - needs to be abstract, final or empty. 315
 Warning design DesignForExtension Method 'getMaxGTUs' is not designed for extension - needs to be abstract, final or empty. 324
 Warning design DesignForExtension Method 'getGtuColorer' is not designed for extension - needs to be abstract, final or empty. 333
 Warning modifier RedundantModifier Redundant 'public' modifier. 355

org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 11). 101
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 191

org/opentrafficsim/road/gtu/generator/SpaceChecker.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 24

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Severity Category Rule Message Line
 Info sizes MethodLength Method length is 162 lines (max allowed is 150). 535
 Warning blocks EmptyBlock Must have at least one statement. 898
 Warning blocks EmptyBlock Must have at least one statement. 913

org/opentrafficsim/road/gtu/lane/LaneBasedIndividualGTU.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 490

org/opentrafficsim/road/gtu/lane/perception/PerceivedObjectType.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 25
 Warning javadoc JavadocVariable Missing a Javadoc comment. 27

org/opentrafficsim/road/gtu/lane/perception/categories/IntersectionPerception.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - java.util.Set. 5
 Warning imports UnusedImports Unused import - org.djunits.value.vdouble.scalar.Length. 9
 Warning imports UnusedImports Unused import - org.opentrafficsim.road.network.lane.object.trafficlight.SimpleTrafficLight. 20
 Warning blocks EmptyBlock Must have at least one statement. 99

org/opentrafficsim/road/gtu/lane/perception/headway/package-info.java

Severity Category Rule Message Line
 Warning misc NewlineAtEndOfFile File does not end with a newline.

org/opentrafficsim/road/gtu/lane/perception/package-info.java

Severity Category Rule Message Line
 Warning misc NewlineAtEndOfFile File does not end with a newline.

org/opentrafficsim/road/gtu/lane/plan/operational/LaneBasedOperationalPlan.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - org.djunits.value.vdouble.scalar.Length. 7
 Warning javadoc JavadocVariable Missing a Javadoc comment. 42
 Warning javadoc JavadocVariable Missing a Javadoc comment. 44

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 9). 85
 Info sizes ParameterNumber More than 7 parameters (found 9). 199
 Info sizes LineLength Line is longer than 128 characters (found 131). 796

org/opentrafficsim/road/gtu/lane/tactical/AbstractLaneBasedTacticalPlanner.java

Severity Category Rule Message Line
 Info sizes MethodLength Method length is 152 lines (max allowed is 150). 263

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 240
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 388
 Info sizes MethodLength Method length is 168 lines (max allowed is 150). 450
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 668

org/opentrafficsim/road/gtu/lane/tactical/directedlanechange/AbstractDirectedLaneChangeModel.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 9). 54

org/opentrafficsim/road/gtu/lane/tactical/following/AbstractIDM.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 44

org/opentrafficsim/road/gtu/lane/tactical/lanechangemobil/LaneChangeModel.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 15

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Severity Category Rule Message Line
 Info sizes MethodLength Method length is 214 lines (max allowed is 150). 90
 Info sizes MethodLength Method length is 175 lines (max allowed is 150). 318
 Info sizes LineLength Line is longer than 128 characters (found 131). 841
 Info sizes LineLength Line is longer than 128 characters (found 131). 864
 Info sizes LineLength Line is longer than 128 characters (found 131). 949

org/opentrafficsim/road/gtu/lane/tactical/toledo/ToledoCFTester.java

Severity Category Rule Message Line
 Warning design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 28
 Warning misc FinalParameters Parameter args should be final. 35

org/opentrafficsim/road/gtu/lane/tactical/toledo/package-info.java

Severity Category Rule Message Line
 Warning misc NewlineAtEndOfFile File does not end with a newline.

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 552
 Info sizes LineLength Line is longer than 128 characters (found 131). 716

org/opentrafficsim/road/gtu/lane/tactical/util/TrafficLightUtil.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - org.opentrafficsim.road.network.lane.object.trafficlight.TrafficLightColor. 19

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/package-info.java

Severity Category Rule Message Line
 Warning misc NewlineAtEndOfFile File does not end with a newline.

org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalPlannerNone.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'generateTacticalPlanner' is not designed for extension - needs to be abstract, final or empty. 42
 Warning design DesignForExtension Method 'nextNode' is not designed for extension - needs to be abstract, final or empty. 49
 Warning misc FinalParameters Parameter link should be final. 50
 Warning misc FinalParameters Parameter direction should be final. 50
 Warning misc FinalParameters Parameter gtuType should be final. 50
 Warning design DesignForExtension Method 'nextLinkDirection' is not designed for extension - needs to be abstract, final or empty. 56
 Warning misc FinalParameters Parameter link should be final. 57
 Warning misc FinalParameters Parameter direction should be final. 57
 Warning misc FinalParameters Parameter gtuType should be final. 57
 Warning design DesignForExtension Method 'nextNode' is not designed for extension - needs to be abstract, final or empty. 64
 Warning misc FinalParameters Parameter node should be final. 65
 Warning misc FinalParameters Parameter previousLink should be final. 65
 Warning misc FinalParameters Parameter gtuType should be final. 65
 Warning design DesignForExtension Method 'nextLinkDirection' is not designed for extension - needs to be abstract, final or empty. 71
 Warning misc FinalParameters Parameter node should be final. 72
 Warning misc FinalParameters Parameter previousLink should be final. 72
 Warning misc FinalParameters Parameter gtuType should be final. 72
 Warning design DesignForExtension Method 'getRoute' is not designed for extension - needs to be abstract, final or empty. 78

org/opentrafficsim/road/gtu/strategical/od/Interpolation.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 134). 57

org/opentrafficsim/road/gtu/strategical/od/ODMatrix.java

Severity Category Rule Message Line
 Warning javadoc JavadocMethod Missing a Javadoc comment. 490
 Info sizes LineLength Line is longer than 128 characters (found 131). 587

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'generateTacticalPlanner' is not designed for extension - needs to be abstract, final or empty. 82
 Warning design DesignForExtension Method 'nextNode' is not designed for extension - needs to be abstract, final or empty. 89
 Warning design DesignForExtension Method 'nextLinkDirection' is not designed for extension - needs to be abstract, final or empty. 97
 Warning design DesignForExtension Method 'nextNode' is not designed for extension - needs to be abstract, final or empty. 106
 Warning design DesignForExtension Method 'nextLinkDirection' is not designed for extension - needs to be abstract, final or empty. 114

org/opentrafficsim/road/network/animation/LaneAnimation.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 141). 86

org/opentrafficsim/road/network/factory/LaneFactory.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 9). 179

org/opentrafficsim/road/network/lane/DirectedLanePosition.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getLocation' is not designed for extension - needs to be abstract, final or empty. 90
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 105
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 117
 Warning blocks NeedBraces 'if' construct must use '{}'s. 120
 Warning blocks NeedBraces 'if' construct must use '{}'s. 122
 Warning blocks NeedBraces 'if' construct must use '{}'s. 124
 Warning blocks NeedBraces 'if' construct must use '{}'s. 127
 Warning blocks NeedBraces 'if' construct must use '{}'s. 131
 Warning blocks NeedBraces 'if' construct must use '{}'s. 134
 Warning blocks NeedBraces 'if' construct must use '{}'s. 138
 Warning blocks NeedBraces 'if' construct must use '{}'s. 141
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 147

org/opentrafficsim/road/network/lane/Lane.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'addDirectionality' is not designed for extension - needs to be abstract, final or empty. 1350
 Warning design DesignForExtension Method 'removeDirectionality' is not designed for extension - needs to be abstract, final or empty. 1363

org/opentrafficsim/road/network/lane/LaneDirection.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 56

org/opentrafficsim/road/network/lane/conflict/package-info.java

Severity Category Rule Message Line
 Warning misc NewlineAtEndOfFile File does not end with a newline.

org/opentrafficsim/road/network/lane/object/AbstractLaneBasedObject.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 129). 83

org/opentrafficsim/road/network/lane/object/LaneBlock.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'clone' is not designed for extension - needs to be abstract, final or empty. 62

org/opentrafficsim/road/network/lane/object/sensor/AbstractSensor.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 8). 74

org/opentrafficsim/road/network/lane/object/sensor/SensorAnimation.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 62

org/opentrafficsim/road/network/lane/object/sensor/TrafficLightSensor.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 9). 89
 Info sizes MethodLength Method length is 188 lines (max allowed is 150). 180
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 255
 Warning blocks EmptyBlock Must have at least one statement. 432
 Info sizes LineLength Line is longer than 128 characters (found 129). 498

org/opentrafficsim/road/network/sampling/RoadSampler.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 421

org/opentrafficsim/road/network/sampling/SpeedLimit.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - org.djunits.unit.SpeedUnit. 3

org/opentrafficsim/road/network/speed/SpeedLimitProspect.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 335