SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 3.1.12

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
184 140 0 0

Files

Class Bugs
loadfromxml.LoadXML 1
org.opentrafficsim.ahfe.AHFEAnimation$1 2
org.opentrafficsim.ahfe.AHFEAnimation$AHFEModel 3
org.opentrafficsim.ahfe.AHFESimulation$1 2
org.opentrafficsim.ahfe.AHFESimulation$AHFEModel 3
org.opentrafficsim.ahfe.AHFEUtil 1
org.opentrafficsim.ahfe.AbstractDelayedPerceptionCategory 2
org.opentrafficsim.ahfe.AbstractDelayedPerceptionCategory$DelayedInfoType 1
org.opentrafficsim.ahfe.AnticipationRelianceScript 2
org.opentrafficsim.ahfe.AnticipationRelianceScript$CarFollowingTaskAR 1
org.opentrafficsim.ahfe.AnticipationRelianceScript$IdmPlusFactoryAR 1
org.opentrafficsim.ahfe.AnticipationRelianceScript$LaneChangeTaskAR 1
org.opentrafficsim.ahfe.AnticipationRelianceScript$SituationalAwarenessDataType 1
org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskAnticipationRelianceDataType 1
org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskDemandDataType 1
org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskManagerAR 1
org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskSaturationDataType 1
org.opentrafficsim.ahfe.DelayedNeighborsPerception$ErrorValue 1
org.opentrafficsim.demo.CircularLaneModel 1
org.opentrafficsim.demo.CircularRoadModel 1
org.opentrafficsim.demo.CircularRoadSwing 2
org.opentrafficsim.demo.CrossingTrafficLightsModel 1
org.opentrafficsim.demo.NetworksSwing 1
org.opentrafficsim.demo.RampMeteringDemo 3
org.opentrafficsim.demo.RampMeteringDemo$ControlledTacticalPlanner 1
org.opentrafficsim.demo.SequentialLanes$SequentialModel 1
org.opentrafficsim.demo.ShortMerge$ShortMergeModel 2
org.opentrafficsim.demo.carFollowing.OSMModel 1
org.opentrafficsim.demo.conflict.BusStreetDemo$BusStreetModel 2
org.opentrafficsim.demo.conflict.BusStreetDemo$CharacteristicsGenerator 1
org.opentrafficsim.demo.conflict.TJunctionDemo$TJunctionModel 1
org.opentrafficsim.demo.conflict.TestNetworkDemo$TestNetworkModel 1
org.opentrafficsim.demo.conflict.TurboRoundaboutDemo$TurboRoundaboutModel 1
org.opentrafficsim.demo.conflictAndControl.DemoTrafcodAndTurbo$TrafCODModel 5
org.opentrafficsim.demo.geometry.shape.ShapeFileReader 5
org.opentrafficsim.demo.geometry.shape.ShapeModel 2
org.opentrafficsim.demo.network.xml.Circuit$TestXMLModel 1
org.opentrafficsim.demo.network.xml.FourStop$TestXMLModel 1
org.opentrafficsim.demo.network.xml.Grid10X10 6
org.opentrafficsim.demo.network.xml.N201ODfactory 4
org.opentrafficsim.demo.network.xml.NetworkTest$TestXMLModel 1
org.opentrafficsim.demo.network.xml.TestXMLParserA58$TestXMLModelA58 3
org.opentrafficsim.demo.network.xml.TestXMLParserAimsun$TestAimsunModel 1
org.opentrafficsim.demo.network.xml.TestXMLParserAmsterdam$TestXMLModelAmsterdam 3
org.opentrafficsim.demo.network.xml.TestXMLParserEindhoven$TestXMLModelEindhoven 3
org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs 9
org.opentrafficsim.demo.network.xml.TestXMLParserN201$TestXMLModelN201 3
org.opentrafficsim.demo.network.xml.TestXMLParserReadXstream$TestXMLModelReadXStream 3
org.opentrafficsim.demo.network.xml.TestXMLParserWriteXstream$TestXMLModelWriteXStream 4
org.opentrafficsim.demo.sdm.SdmSimulation 1
org.opentrafficsim.demo.sdm.SdmStrategicalPlannerFactory$SdmPerception 1
org.opentrafficsim.demo.steering.SteeringSimulation 1
org.opentrafficsim.demo.trafficcontrol.TrafCODDemo1 1
org.opentrafficsim.demo.trafficcontrol.TrafCODDemo1$TrafCODModel 1
org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2 1
org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2$TrafCODModel 1
org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2_Generators 1
org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2_Generators$TrafCODModel 1
org.opentrafficsim.demo.web.OTSDemoServer$MyResourceHandler 2
org.opentrafficsim.demo.web.OTSDemoServer$XHRHandler 4
org.opentrafficsim.demo.web.OTSFederatedDemoServer$MyResourceHandler 2
org.opentrafficsim.demo.web.OTSFederatedDemoServer$XHRHandler 4
org.opentrafficsim.demo.web.SimpleLoadBalancer 3
org.opentrafficsim.demo.web.SuperDemoWebApplication 4
strategies.LmrsStrategies 2
strategies.LmrsStrategies$LmrsStrategiesAnimation 1
strategies.LmrsStrategies$LmrsStrategiesModel 1
strategies.LmrsStrategies$LmrsStrategiesSimulation 1
strategies.LmrsStrategies$SigmaMeasurement 1
strategies.LmrsStrategies$VDes0Measurement 1
strategies.LmrsStrategies$VDesMeasurement 1
strategies.LmrsStrategies$VGainMeasurement 1
strategies.StrategiesDemo 1
strategies.StrategiesDemo$LmrsStrategiesPerceptionFactory 1
strategies.StrategiesDemo$SocioIDMFactory 1

loadfromxml.LoadXML

Bug Category Details Line Priority
Found reliance on default encoding in loadfromxml.LoadXML.main(String[]): new String(byte[]) I18N DM_DEFAULT_ENCODING 131 High

org.opentrafficsim.ahfe.AHFEAnimation$1

Bug Category Details Line Priority
Found reliance on default encoding in org.opentrafficsim.ahfe.AHFEAnimation$1.run(): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 337 High
org.opentrafficsim.ahfe.AHFEAnimation$1.run() invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 384 Medium

org.opentrafficsim.ahfe.AHFEAnimation$AHFEModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.ahfe.AHFEAnimation$AHFEModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 496 Medium
Class org.opentrafficsim.ahfe.AHFEAnimation$AHFEModel defines non-transient non-serializable instance field sampler BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.network.sampling.RoadSampler stored into non-transient field AHFEAnimation$AHFEModel.sampler BAD_PRACTICE SE_BAD_FIELD_STORE 492 Medium

org.opentrafficsim.ahfe.AHFESimulation$1

Bug Category Details Line Priority
Found reliance on default encoding in org.opentrafficsim.ahfe.AHFESimulation$1.run(): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 325 High
org.opentrafficsim.ahfe.AHFESimulation$1.run() invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 372 Medium

org.opentrafficsim.ahfe.AHFESimulation$AHFEModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.ahfe.AHFESimulation$AHFEModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 477 Medium
Class org.opentrafficsim.ahfe.AHFESimulation$AHFEModel defines non-transient non-serializable instance field sampler BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.network.sampling.RoadSampler stored into non-transient field AHFESimulation$AHFEModel.sampler BAD_PRACTICE SE_BAD_FIELD_STORE 473 Medium

org.opentrafficsim.ahfe.AHFEUtil

Bug Category Details Line Priority
Bad attempt to compute absolute value of signed random integer in org.opentrafficsim.ahfe.AHFEUtil.createDemand(OTSRoadNetwork, GTUColorer, OTSSimulatorInterface, int, String, Duration, Duration, double, Time, Frequency, Frequency, double, double, double, double) CORRECTNESS RV_ABSOLUTE_VALUE_OF_RANDOM_INT 153 High

org.opentrafficsim.ahfe.AbstractDelayedPerceptionCategory

Bug Category Details Line Priority
Load of known null value in org.opentrafficsim.ahfe.AbstractDelayedPerceptionCategory.changeLane(LateralDirectionality) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 184 Medium
org.opentrafficsim.ahfe.AbstractDelayedPerceptionCategory.changeLane(LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 176 Medium

org.opentrafficsim.ahfe.AbstractDelayedPerceptionCategory$DelayedInfoType

Bug Category Details Line Priority
There is an apparent infinite recursive loop in org.opentrafficsim.ahfe.AbstractDelayedPerceptionCategory$DelayedInfoType.getId() CORRECTNESS IL_INFINITE_RECURSIVE_LOOP 231 High

org.opentrafficsim.ahfe.AnticipationRelianceScript

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.ahfe.AnticipationRelianceScript.setupSimulation(OTSSimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 344 Medium
Write to static field org.opentrafficsim.core.gtu.AbstractGTU.ALIGNED from instance method org.opentrafficsim.ahfe.AnticipationRelianceScript.setupSimulation(OTSSimulatorInterface) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 341 High

org.opentrafficsim.ahfe.AnticipationRelianceScript$CarFollowingTaskAR

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.AnticipationRelianceScript$CarFollowingTaskAR be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 587-605 Medium

org.opentrafficsim.ahfe.AnticipationRelianceScript$IdmPlusFactoryAR

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.AnticipationRelianceScript$IdmPlusFactoryAR be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 742-770 Medium

org.opentrafficsim.ahfe.AnticipationRelianceScript$LaneChangeTaskAR

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.AnticipationRelianceScript$LaneChangeTaskAR be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 615-625 Medium

org.opentrafficsim.ahfe.AnticipationRelianceScript$SituationalAwarenessDataType

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.AnticipationRelianceScript$SituationalAwarenessDataType be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 854-874 Medium

org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskAnticipationRelianceDataType

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskAnticipationRelianceDataType be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 801-822 Medium

org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskDemandDataType

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskDemandDataType be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 828-848 Medium

org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskManagerAR

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskManagerAR be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 704-738 Medium

org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskSaturationDataType

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.AnticipationRelianceScript$TaskSaturationDataType be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 775-795 Medium

org.opentrafficsim.ahfe.DelayedNeighborsPerception$ErrorValue

Bug Category Details Line Priority
Should org.opentrafficsim.ahfe.DelayedNeighborsPerception$ErrorValue be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 512-545 Medium

org.opentrafficsim.demo.CircularLaneModel

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.CircularLaneModel.constructModel() STYLE REC_CATCH_EXCEPTION 208 Medium

org.opentrafficsim.demo.CircularRoadModel

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.CircularRoadModel.constructModel() STYLE REC_CATCH_EXCEPTION 227 Medium

org.opentrafficsim.demo.CircularRoadSwing

Bug Category Details Line Priority
Useless object stored in variable lanes of method org.opentrafficsim.demo.CircularRoadSwing.addStatisticsTabs(OTSSimulatorInterface) STYLE UC_USELESS_OBJECT 164 Medium
Useless object stored in variable positions of method org.opentrafficsim.demo.CircularRoadSwing.addStatisticsTabs(OTSSimulatorInterface) STYLE UC_USELESS_OBJECT 165 Medium

org.opentrafficsim.demo.CrossingTrafficLightsModel

Bug Category Details Line Priority
Useless object stored in variable trafficLights of method org.opentrafficsim.demo.CrossingTrafficLightsModel.constructModel() STYLE UC_USELESS_OBJECT 192 Medium

org.opentrafficsim.demo.NetworksSwing

Bug Category Details Line Priority
Integer remainder modulo 1 computed in org.opentrafficsim.demo.NetworksSwing.addStatisticsTabs(OTSSimulatorInterface) STYLE INT_BAD_REM_BY_1 150 High

org.opentrafficsim.demo.RampMeteringDemo

Bug Category Details Line Priority
Dead store to lanesBC in org.opentrafficsim.demo.RampMeteringDemo.setupSimulation(OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 287 Medium
Dead store to lanesFB in org.opentrafficsim.demo.RampMeteringDemo.setupSimulation(OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 295 Medium
Useless object stored in variable detectors34 of method org.opentrafficsim.demo.RampMeteringDemo.setupSimulation(OTSSimulatorInterface) STYLE UC_USELESS_OBJECT 315 Medium

org.opentrafficsim.demo.RampMeteringDemo$ControlledTacticalPlanner

Bug Category Details Line Priority
Class org.opentrafficsim.demo.RampMeteringDemo$ControlledTacticalPlanner defines non-transient non-serializable instance field laneChangeSystem BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.demo.SequentialLanes$SequentialModel

Bug Category Details Line Priority
Useless object stored in variable links of method org.opentrafficsim.demo.SequentialLanes$SequentialModel.constructModel() STYLE UC_USELESS_OBJECT 297 Medium

org.opentrafficsim.demo.ShortMerge$ShortMergeModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.ShortMerge$ShortMergeModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 239 Medium
Bad attempt to compute absolute value of signed random integer in org.opentrafficsim.demo.ShortMerge$ShortMergeModel.addGenerator() CORRECTNESS RV_ABSOLUTE_VALUE_OF_RANDOM_INT 273 High

org.opentrafficsim.demo.carFollowing.OSMModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field converter BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.demo.conflict.BusStreetDemo$BusStreetModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.conflict.BusStreetDemo$BusStreetModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 176 Medium
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.conflict.BusStreetDemo$BusStreetModel.constructModel() STYLE REC_CATCH_EXCEPTION 221 Medium

org.opentrafficsim.demo.conflict.BusStreetDemo$CharacteristicsGenerator

Bug Category Details Line Priority
new org.opentrafficsim.demo.conflict.BusStreetDemo$CharacteristicsGenerator(DEVSSimulatorInterface$TimeDoubleUnit, double[], OTSRoadNetwork) may expose internal representation by storing an externally mutable object into BusStreetDemo$CharacteristicsGenerator.probabilities MALICIOUS_CODE EI_EXPOSE_REP2 356 Medium

org.opentrafficsim.demo.conflict.TJunctionDemo$TJunctionModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.conflict.TJunctionDemo$TJunctionModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 119 Medium

org.opentrafficsim.demo.conflict.TestNetworkDemo$TestNetworkModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.conflict.TestNetworkDemo$TestNetworkModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 117 Medium

org.opentrafficsim.demo.conflict.TurboRoundaboutDemo$TurboRoundaboutModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.conflict.TurboRoundaboutDemo$TurboRoundaboutModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 119 Medium

org.opentrafficsim.demo.conflictAndControl.DemoTrafcodAndTurbo$TrafCODModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.conflictAndControl.DemoTrafcodAndTurbo$TrafCODModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 248 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.conflictAndControl.DemoTrafcodAndTurbo$TrafCODModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 154 Medium
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.conflictAndControl.DemoTrafcodAndTurbo$TrafCODModel.constructModel() STYLE REC_CATCH_EXCEPTION 279 Medium
Useless object stored in variable sensors of method org.opentrafficsim.demo.conflictAndControl.DemoTrafcodAndTurbo$TrafCODModel.constructModel() STYLE UC_USELESS_OBJECT 176 Medium
Useless object stored in variable trafficLights of method org.opentrafficsim.demo.conflictAndControl.DemoTrafcodAndTurbo$TrafCODModel.constructModel() STYLE UC_USELESS_OBJECT 175 Medium

org.opentrafficsim.demo.geometry.shape.ShapeFileReader

Bug Category Details Line Priority
Dead store to capacity in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(OTSRoadNetwork, String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 242 Medium
Dead store to length in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(OTSRoadNetwork, String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 230 Medium
Dead store to speed in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(OTSRoadNetwork, String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 240 Medium
Redundant nullcheck of nr, which is known to be non-null in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readNodes(Network, String, String, boolean, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 126 Medium
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(OTSRoadNetwork, String, Map, Map, OTSSimulatorInterface) STYLE REC_CATCH_EXCEPTION 283 Medium

org.opentrafficsim.demo.geometry.shape.ShapeModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.geometry.shape.ShapeModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 56 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.geometry.shape.ShapeModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 54 Medium

org.opentrafficsim.demo.network.xml.Circuit$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.Circuit$TestXMLModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 129 Medium

org.opentrafficsim.demo.network.xml.FourStop$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.FourStop$TestXMLModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 129 Medium

org.opentrafficsim.demo.network.xml.Grid10X10

Bug Category Details Line Priority
Format string should use %n rather than \n in org.opentrafficsim.demo.network.xml.Grid10X10.main(String[]) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 256 Medium
Format string should use %n rather than \n in org.opentrafficsim.demo.network.xml.Grid10X10.main(String[]) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 260 Medium
Format string should use %n rather than \n in org.opentrafficsim.demo.network.xml.Grid10X10.main(String[]) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 242 Medium
Format string should use %n rather than \n in org.opentrafficsim.demo.network.xml.Grid10X10.main(String[]) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 233 Medium
Format string should use %n rather than \n in org.opentrafficsim.demo.network.xml.Grid10X10.main(String[]) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 235 Medium
Format string should use %n rather than \n in org.opentrafficsim.demo.network.xml.Grid10X10.main(String[]) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 240 Medium

org.opentrafficsim.demo.network.xml.N201ODfactory

Bug Category Details Line Priority
Dead store to colorer in org.opentrafficsim.demo.network.xml.N201ODfactory.makeGeneratorsFromOD(OTSRoadNetwork, ODMatrix, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 155 High
Dead store to northBound in org.opentrafficsim.demo.network.xml.N201ODfactory.getQuery(OTSRoadNetwork, Sampler) STYLE DLS_DEAD_LOCAL_STORE 234 Medium
Dead store to route in org.opentrafficsim.demo.network.xml.N201ODfactory.makeGeneratorsFromOD(OTSRoadNetwork, ODMatrix, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 167 Medium
Useless object stored in variable northBound of method org.opentrafficsim.demo.network.xml.N201ODfactory.getQuery(OTSRoadNetwork, Sampler) STYLE UC_USELESS_OBJECT 234 Medium

org.opentrafficsim.demo.network.xml.NetworkTest$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.NetworkTest$TestXMLModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 129 Medium

org.opentrafficsim.demo.network.xml.TestXMLParserA58$TestXMLModelA58

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserA58$TestXMLModelA58.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 141 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserA58$TestXMLModelA58.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 158 Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserA58$TestXMLModelA58 defines non-transient non-serializable instance field gisMap BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.demo.network.xml.TestXMLParserAimsun$TestAimsunModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserAimsun$TestAimsunModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 127 Medium

org.opentrafficsim.demo.network.xml.TestXMLParserAmsterdam$TestXMLModelAmsterdam

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserAmsterdam$TestXMLModelAmsterdam.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 164 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserAmsterdam$TestXMLModelAmsterdam.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 184 Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserAmsterdam$TestXMLModelAmsterdam defines non-transient non-serializable instance field gisMap BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.demo.network.xml.TestXMLParserEindhoven$TestXMLModelEindhoven

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserEindhoven$TestXMLModelEindhoven.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 159 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserEindhoven$TestXMLModelEindhoven.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 142 Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserEindhoven$TestXMLModelEindhoven defines non-transient non-serializable instance field gisMap BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 151 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 175 Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs defines non-transient non-serializable instance field meanSpeed BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs defines non-transient non-serializable instance field meanTravelTimePerDistance BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs defines non-transient non-serializable instance field meanTripLength BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs defines non-transient non-serializable instance field totalDelay BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs defines non-transient non-serializable instance field totalNumberOfStops BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs defines non-transient non-serializable instance field totalTravelDistance BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserKPIs$TestXMLModelKPIs defines non-transient non-serializable instance field totalTravelTime BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.demo.network.xml.TestXMLParserN201$TestXMLModelN201

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserN201$TestXMLModelN201.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 141 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserN201$TestXMLModelN201.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 158 Medium
Class org.opentrafficsim.demo.network.xml.TestXMLParserN201$TestXMLModelN201 defines non-transient non-serializable instance field gisMap BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.demo.network.xml.TestXMLParserReadXstream$TestXMLModelReadXStream

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserReadXstream$TestXMLModelReadXStream.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 146 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserReadXstream$TestXMLModelReadXStream.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 131 Medium
Found reliance on default encoding in org.opentrafficsim.demo.network.xml.TestXMLParserReadXstream$TestXMLModelReadXStream.constructModel(): new String(byte[]) I18N DM_DEFAULT_ENCODING 131 High

org.opentrafficsim.demo.network.xml.TestXMLParserWriteXstream$TestXMLModelWriteXStream

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserWriteXstream$TestXMLModelWriteXStream.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 134 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserWriteXstream$TestXMLModelWriteXStream.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 155 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.network.xml.TestXMLParserWriteXstream$TestXMLModelWriteXStream.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 146 Medium
Found reliance on default encoding in org.opentrafficsim.demo.network.xml.TestXMLParserWriteXstream$TestXMLModelWriteXStream.constructModel(): String.getBytes() I18N DM_DEFAULT_ENCODING 146 High

org.opentrafficsim.demo.sdm.SdmSimulation

Bug Category Details Line Priority
Found reliance on default encoding in org.opentrafficsim.demo.sdm.SdmSimulation.onSimulationEnd(): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 576 High

org.opentrafficsim.demo.sdm.SdmStrategicalPlannerFactory$SdmPerception

Bug Category Details Line Priority
Should org.opentrafficsim.demo.sdm.SdmStrategicalPlannerFactory$SdmPerception be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 148-180 Medium

org.opentrafficsim.demo.steering.SteeringSimulation

Bug Category Details Line Priority
Useless object stored in variable originLanes of method org.opentrafficsim.demo.steering.SteeringSimulation.setupSimulation(OTSSimulatorInterface) STYLE UC_USELESS_OBJECT 172 Medium

org.opentrafficsim.demo.trafficcontrol.TrafCODDemo1

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.trafficcontrol.TrafCODDemo1.demo(boolean) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 115 Medium

org.opentrafficsim.demo.trafficcontrol.TrafCODDemo1$TrafCODModel

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.trafficcontrol.TrafCODDemo1$TrafCODModel.constructModel() STYLE REC_CATCH_EXCEPTION 275 Medium

org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2.demo(boolean) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 109 Medium

org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2$TrafCODModel

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2$TrafCODModel.constructModel() STYLE REC_CATCH_EXCEPTION 243 Medium

org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2_Generators

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2_Generators.demo(boolean) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 99 Medium

org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2_Generators$TrafCODModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.trafficcontrol.TrafCODDemo2_Generators$TrafCODModel.constructModel() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 172 Medium

org.opentrafficsim.demo.web.OTSDemoServer$MyResourceHandler

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.web.OTSDemoServer$MyResourceHandler.handle(String, Request, HttpServletRequest, HttpServletResponse) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 326 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.web.OTSDemoServer$MyResourceHandler.handle(String, Request, HttpServletRequest, HttpServletResponse) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 332 Medium

org.opentrafficsim.demo.web.OTSDemoServer$XHRHandler

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.opentrafficsim.demo.web.OTSDemoServer$XHRHandler.setParameters(OTSModelInterface, String) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 718 High
Boxing/unboxing to parse a primitive org.opentrafficsim.demo.web.OTSDemoServer$XHRHandler.setParameters(OTSModelInterface, String) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 713 High
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.web.OTSDemoServer$XHRHandler.setParameters(OTSModelInterface, String) STYLE REC_CATCH_EXCEPTION 746 Medium
HTTP parameter written to Servlet output in org.opentrafficsim.demo.web.OTSDemoServer$XHRHandler.handle(String, Request, HttpServletRequest, HttpServletResponse) SECURITY XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER 465 Medium

org.opentrafficsim.demo.web.OTSFederatedDemoServer$MyResourceHandler

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.web.OTSFederatedDemoServer$MyResourceHandler.handle(String, Request, HttpServletRequest, HttpServletResponse) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 223 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.web.OTSFederatedDemoServer$MyResourceHandler.handle(String, Request, HttpServletRequest, HttpServletResponse) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 229 Medium

org.opentrafficsim.demo.web.OTSFederatedDemoServer$XHRHandler

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.opentrafficsim.demo.web.OTSFederatedDemoServer$XHRHandler.setParameters(OTSModelInterface, String) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 598 High
Boxing/unboxing to parse a primitive org.opentrafficsim.demo.web.OTSFederatedDemoServer$XHRHandler.setParameters(OTSModelInterface, String) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 593 High
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.web.OTSFederatedDemoServer$XHRHandler.setParameters(OTSModelInterface, String) STYLE REC_CATCH_EXCEPTION 626 Medium
HTTP parameter written to Servlet output in org.opentrafficsim.demo.web.OTSFederatedDemoServer$XHRHandler.handle(String, Request, HttpServletRequest, HttpServletResponse) SECURITY XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER 345 Medium

org.opentrafficsim.demo.web.SimpleLoadBalancer

Bug Category Details Line Priority
Unread field: org.opentrafficsim.demo.web.SimpleLoadBalancer.messageCount PERFORMANCE URF_UNREAD_FIELD 51 Medium
Unused field: org.opentrafficsim.demo.web.SimpleLoadBalancer.lbContext PERFORMANCE UUF_UNUSED_FIELD Not available Medium
Unused field: org.opentrafficsim.demo.web.SimpleLoadBalancer.lbSocket PERFORMANCE UUF_UNUSED_FIELD Not available Medium

org.opentrafficsim.demo.web.SuperDemoWebApplication

Bug Category Details Line Priority
instanceof will always return true for all non-null values in org.opentrafficsim.demo.web.SuperDemoWebApplication.processSimRunControl(String, FM2SimRunControlMessage), since all org.sim0mq.message.types.NumberDuration are instances of Number STYLE BC_VACUOUS_INSTANCEOF 308 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.web.SuperDemoWebApplication.init() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 143 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.web.SuperDemoWebApplication.init() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 149 Medium
org.opentrafficsim.demo.web.SuperDemoWebApplication.processKillFederate() invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 526 Medium

strategies.LmrsStrategies

Bug Category Details Line Priority
strategies.LmrsStrategies.notify(EventInterface) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 1021 Medium
Return value of new LmrsStrategies$LmrsStrategiesSimulation(LmrsStrategies, OTSModelInterface) ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 410 Medium

strategies.LmrsStrategies$LmrsStrategiesAnimation

Bug Category Details Line Priority
Should strategies.LmrsStrategies$LmrsStrategiesAnimation be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 499-512 Medium

strategies.LmrsStrategies$LmrsStrategiesModel

Bug Category Details Line Priority
strategies.LmrsStrategies$LmrsStrategiesModel.constructModel() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 836 Medium

strategies.LmrsStrategies$LmrsStrategiesSimulation

Bug Category Details Line Priority
Should strategies.LmrsStrategies$LmrsStrategiesSimulation be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 471-473 Medium

strategies.LmrsStrategies$SigmaMeasurement

Bug Category Details Line Priority
Should strategies.LmrsStrategies$SigmaMeasurement be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1038-1095 Medium

strategies.LmrsStrategies$VDes0Measurement

Bug Category Details Line Priority
Should strategies.LmrsStrategies$VDes0Measurement be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1257-1316 Medium

strategies.LmrsStrategies$VDesMeasurement

Bug Category Details Line Priority
Should strategies.LmrsStrategies$VDesMeasurement be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1184-1241 Medium

strategies.LmrsStrategies$VGainMeasurement

Bug Category Details Line Priority
Should strategies.LmrsStrategies$VGainMeasurement be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1111-1168 Medium

strategies.StrategiesDemo

Bug Category Details Line Priority
Integral division result cast to double or float in strategies.StrategiesDemo.setupSimulation(OTSSimulatorInterface) STYLE ICAST_IDIV_CAST_TO_DOUBLE 581 Medium

strategies.StrategiesDemo$LmrsStrategiesPerceptionFactory

Bug Category Details Line Priority
Should strategies.StrategiesDemo$LmrsStrategiesPerceptionFactory be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 692-712 Medium

strategies.StrategiesDemo$SocioIDMFactory

Bug Category Details Line Priority
Should strategies.StrategiesDemo$SocioIDMFactory be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 672-687 Medium