Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.17.0 with /config/dsol-checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
88 6 90 0

Files

File  I  W  E
org/opentrafficsim/editor/ApplicationStore.java 0 2 0
org/opentrafficsim/editor/EvalWrapper.java 0 1 0
org/opentrafficsim/editor/NodeActions.java 0 1 0
org/opentrafficsim/editor/OtsEditor.java 1 9 0
org/opentrafficsim/editor/OtsRunner.java 0 1 0
org/opentrafficsim/editor/Schema.java 0 1 0
org/opentrafficsim/editor/Undo.java 1 9 0
org/opentrafficsim/editor/XiIncludeNode.java 0 4 0
org/opentrafficsim/editor/XsdPaths.java 0 1 0
org/opentrafficsim/editor/XsdTreeNode.java 0 7 0
org/opentrafficsim/editor/decoration/AbstractNodeDecoratorAttribute.java 0 2 0
org/opentrafficsim/editor/decoration/AutomaticLinkId.java 0 2 0
org/opentrafficsim/editor/decoration/DefaultDecorator.java 0 1 0
org/opentrafficsim/editor/decoration/string/AbstractStringFunction.java 0 1 0
org/opentrafficsim/editor/decoration/string/XiIncludeStringFunction.java 0 1 0
org/opentrafficsim/editor/decoration/validation/CoupledValidator.java 0 1 0
org/opentrafficsim/editor/decoration/validation/KeyValidator.java 0 1 0
org/opentrafficsim/editor/decoration/validation/NoDuplicateChildrenValidator.java 0 2 0
org/opentrafficsim/editor/decoration/validation/ParentValidator.java 0 3 0
org/opentrafficsim/editor/decoration/validation/RoadLayoutElementValidator.java 0 6 0
org/opentrafficsim/editor/decoration/validation/XPathValidator.java 0 6 0
org/opentrafficsim/editor/decoration/validation/XsdAllValidator.java 0 2 0
org/opentrafficsim/editor/extensions/OdEditor.java 0 1 0
org/opentrafficsim/editor/extensions/RoadLayoutEditor.java 0 2 0
org/opentrafficsim/editor/extensions/RouteEditor.java 0 1 0
org/opentrafficsim/editor/extensions/TrafCodEditor.java 0 1 0
org/opentrafficsim/editor/extensions/map/ChangeListener.java 0 3 0
org/opentrafficsim/editor/extensions/map/EditorMap.java 1 3 0
org/opentrafficsim/editor/extensions/map/MapData.java 0 1 0
org/opentrafficsim/editor/extensions/map/MapLinkData.java 0 11 0
org/opentrafficsim/editor/extensions/map/MapStripeData.java 1 0 0
org/opentrafficsim/editor/extensions/map/RoadLayoutListener.java 1 0 0
org/opentrafficsim/editor/listeners/ChangesListener.java 0 1 0
org/opentrafficsim/editor/listeners/XsdTreeMouseListener.java 1 1 0
org/opentrafficsim/editor/listeners/XsdTreeSelectionListener.java 0 1 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 2  Warning
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 39  Warning
MissingSwitchDefault 1  Warning
design FinalClass 1  Warning
HideUtilityClassConstructor 1  Warning
VisibilityModifier 16  Warning
imports UnusedImports 1  Warning
misc TodoComment 10  Warning
modifier ModifierOrder 4  Warning
RedundantModifier 13  Warning
sizes FileLength 2  Warning
MethodLength 5  Info
ParameterNumber 1  Info

Details

org/opentrafficsim/editor/ApplicationStore.java

Severity Category Rule Message Line
 Warning coding HiddenField 'file' hides a field. 119
 Warning coding HiddenField 'file' hides a field. 141

org/opentrafficsim/editor/EvalWrapper.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 318

org/opentrafficsim/editor/NodeActions.java

Severity Category Rule Message Line
 Warning coding HiddenField 'editor' hides a field. 72

org/opentrafficsim/editor/OtsEditor.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,058 lines (max allowed is 2,000). 1
 Info sizes MethodLength Method OtsEditor length is 152 lines (max allowed is 150). 306
 Warning coding HiddenField 'scenario' hides a field. 499
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 516
 Warning coding HiddenField 'properties' hides a field. 665
 Warning coding HiddenField 'coupledNode' hides a field. 803
 Warning coding HiddenField 'backNode' hides a field. 803
 Warning coding HiddenField 'backAttribute' hides a field. 803
 Warning coding HiddenField 'clipboard' hides a field. 1959
 Warning coding HiddenField 'cut' hides a field. 1959

org/opentrafficsim/editor/OtsRunner.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 46

org/opentrafficsim/editor/Schema.java

Severity Category Rule Message Line
 Warning coding HiddenField 'elements' hides a field. 597

org/opentrafficsim/editor/Undo.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'ignoreChanges' must be private and have accessor methods. 54
 Info sizes MethodLength Method notify length is 170 lines (max allowed is 150). 231
 Warning modifier RedundantModifier Redundant 'public' modifier. 461
 Warning design VisibilityModifier Variable 'type' must be private and have accessor methods. 499
 Warning design VisibilityModifier Variable 'subActions' must be private and have accessor methods. 502
 Warning design VisibilityModifier Variable 'node' must be private and have accessor methods. 505
 Warning design VisibilityModifier Variable 'parent' must be private and have accessor methods. 508
 Warning design VisibilityModifier Variable 'attribute' must be private and have accessor methods. 511
 Warning design VisibilityModifier Variable 'postActionShowNode' must be private and have accessor methods. 514
 Warning modifier RedundantModifier Redundant 'public' modifier. 524

org/opentrafficsim/editor/XiIncludeNode.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 297
 Warning modifier RedundantModifier Redundant 'public' modifier. 541
 Warning coding HiddenField 'name' hides a field. 771
 Warning coding HiddenField 'name' hides a field. 787

org/opentrafficsim/editor/XsdPaths.java

Severity Category Rule Message Line
 Warning design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 13

org/opentrafficsim/editor/XsdTreeNode.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,752 lines (max allowed is 2,000). 1
 Warning coding HiddenField 'children' hides a field. 354
 Warning coding HiddenField 'parent' hides a field. 1468
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 1641
 Warning coding HiddenField 'stringFunction' hides a field. 2141
 Warning coding HiddenField 'value' hides a field. 2380
 Warning coding HiddenField 'maxOccurs' hides a field. 2521

org/opentrafficsim/editor/decoration/AbstractNodeDecoratorAttribute.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'predicate' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'attributes' must be private and have accessor methods. 31

org/opentrafficsim/editor/decoration/AutomaticLinkId.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'lastNode' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'lastId' must be private and have accessor methods. 30

org/opentrafficsim/editor/decoration/DefaultDecorator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 191

org/opentrafficsim/editor/decoration/string/AbstractStringFunction.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'overwrite' must be private and have accessor methods. 28

org/opentrafficsim/editor/decoration/string/XiIncludeStringFunction.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - org.opentrafficsim.editor.XsdTreeNodeRoot. 8

org/opentrafficsim/editor/decoration/validation/CoupledValidator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 28

org/opentrafficsim/editor/decoration/validation/KeyValidator.java

Severity Category Rule Message Line
 Warning coding HiddenField 'nodes' hides a field. 160

org/opentrafficsim/editor/decoration/validation/NoDuplicateChildrenValidator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 123
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 123

org/opentrafficsim/editor/decoration/validation/ParentValidator.java

Severity Category Rule Message Line
 Warning coding HiddenField 'contextPath' hides a field. 63
 Warning coding HiddenField 'idAttribute' hides a field. 74
 Warning coding HiddenField 'parentAttribute' hides a field. 85

org/opentrafficsim/editor/decoration/validation/RoadLayoutElementValidator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 226
 Warning coding HiddenField 'attribute' hides a field. 375
 Warning modifier RedundantModifier Redundant 'final' modifier. 397
 Warning modifier RedundantModifier Redundant 'static' modifier. 426
 Warning modifier RedundantModifier Redundant 'public' modifier. 465
 Warning coding HiddenField 'attribute' hides a field. 494

org/opentrafficsim/editor/decoration/validation/XPathValidator.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'keyNode' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'keyPath' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'fields' must be private and have accessor methods. 31
 Warning coding HiddenField 'fields' hides a field. 44
 Warning modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 165
 Warning modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 172

org/opentrafficsim/editor/decoration/validation/XsdAllValidator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 93
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 93

org/opentrafficsim/editor/extensions/OdEditor.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 60

org/opentrafficsim/editor/extensions/RoadLayoutEditor.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 64
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 84

org/opentrafficsim/editor/extensions/RouteEditor.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 59

org/opentrafficsim/editor/extensions/TrafCodEditor.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 45

org/opentrafficsim/editor/extensions/map/ChangeListener.java

Severity Category Rule Message Line
 Warning coding HiddenField 'node' hides a field. 102
 Warning coding HiddenField 'node' hides a field. 126
 Warning coding HiddenField 'node' hides a field. 173

org/opentrafficsim/editor/extensions/map/EditorMap.java

Severity Category Rule Message Line
 Warning design FinalClass Class EditorMap should be declared as final. 86
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 422
 Info sizes MethodLength Method notify length is 188 lines (max allowed is 150). 523
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 778

org/opentrafficsim/editor/extensions/map/MapData.java

Severity Category Rule Message Line
 Warning coding HiddenField 'node' hides a field. 109

org/opentrafficsim/editor/extensions/map/MapLinkData.java

Severity Category Rule Message Line
 Warning coding HiddenField 'shape' hides a field. 213
 Warning blocks EmptyBlock Must have at least one statement. 422
 Warning blocks EmptyBlock Must have at least one statement. 426
 Warning coding HiddenField 'laneData' hides a field. 676
 Warning design VisibilityModifier Variable 'coordinates' must be private and have accessor methods. 1018
 Warning coding MissingSwitchDefault switch without "default" clause. 1095
 Warning coding HiddenField 'from' hides a field. 1301
 Warning coding HiddenField 'to' hides a field. 1301
 Warning coding HiddenField 'length' hides a field. 1308
 Warning coding HiddenField 'shape' hides a field. 1324
 Warning coding HiddenField 'weighted' hides a field. 1325

org/opentrafficsim/editor/extensions/map/MapStripeData.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 9). 73

org/opentrafficsim/editor/extensions/map/RoadLayoutListener.java

Severity Category Rule Message Line
 Info sizes MethodLength Method calculateData length is 162 lines (max allowed is 150). 81

org/opentrafficsim/editor/listeners/ChangesListener.java

Severity Category Rule Message Line
 Warning coding HiddenField 'scenario' hides a field. 95

org/opentrafficsim/editor/listeners/XsdTreeMouseListener.java

Severity Category Rule Message Line
 Warning coding HiddenField 'editor' hides a field. 65
 Info sizes MethodLength Method addDefaultActions length is 259 lines (max allowed is 150). 247

org/opentrafficsim/editor/listeners/XsdTreeSelectionListener.java

Severity Category Rule Message Line
 Warning coding HiddenField 'editor' hides a field. 108