PMD Results

The following document contains the results of PMD 7.3.0.

Violations By Priority

Priority 3

org/opentrafficsim/editor/ApplicationStore.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 5558
EmptyCatchBlock Avoid empty catch blocks 9093

org/opentrafficsim/editor/EvalWrapper.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'evalChanged': the method is declared in an interface type 323

org/opentrafficsim/editor/OtsEditor.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 356
UselessQualifiedThis Useless qualified this usage in the same class. 357
UselessQualifiedThis Useless qualified this usage in the same class. 358
UselessQualifiedThis Useless qualified this usage in the same class. 358
EmptyCatchBlock Avoid empty catch blocks 364367
UselessQualifiedThis Useless qualified this usage in the same class. 474
UselessQualifiedThis Useless qualified this usage in the same class. 475
UselessQualifiedThis Useless qualified this usage in the same class. 475
UselessQualifiedThis Useless qualified this usage in the same class. 651
UselessQualifiedThis Useless qualified this usage in the same class. 671
UselessQualifiedThis Useless qualified this usage in the same class. 682
UselessQualifiedThis Useless qualified this usage in the same class. 723
UselessQualifiedThis Useless qualified this usage in the same class. 726
UselessQualifiedThis Useless qualified this usage in the same class. 752
UselessQualifiedThis Useless qualified this usage in the same class. 772
UselessQualifiedThis Useless qualified this usage in the same class. 884
UselessQualifiedThis Useless qualified this usage in the same class. 1365
UselessQualifiedThis Useless qualified this usage in the same class. 1374
UselessQualifiedThis Useless qualified this usage in the same class. 1383
UselessQualifiedThis Useless qualified this usage in the same class. 1392
UselessQualifiedThis Useless qualified this usage in the same class. 1407
UselessQualifiedThis Useless qualified this usage in the same class. 1564
UselessQualifiedThis Useless qualified this usage in the same class. 1565
UselessQualifiedThis Useless qualified this usage in the same class. 1645
UselessQualifiedThis Useless qualified this usage in the same class. 1674
UselessQualifiedThis Useless qualified this usage in the same class. 1899
UselessQualifiedThis Useless qualified this usage in the same class. 2030
UselessQualifiedThis Useless qualified this usage in the same class. 2030

org/opentrafficsim/editor/XsdTreeNode.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 623626
UnusedFormalParameter Avoid unused method parameters such as 'field'. 2046

org/opentrafficsim/editor/decoration/AbstractNodeDecorator.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 47

org/opentrafficsim/editor/decoration/AbstractNodeDecoratorAttribute.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 56
UselessQualifiedThis Useless qualified this usage in the same class. 58

org/opentrafficsim/editor/decoration/string/AbstractStringFunction.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 48

org/opentrafficsim/editor/decoration/string/AttributesStringFunction.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 58
UselessQualifiedThis Useless qualified this usage in the same class. 64

org/opentrafficsim/editor/decoration/string/ChoiceNodeStringFunction.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 62

org/opentrafficsim/editor/decoration/validation/AttributesNotEqualValidator.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 61
UselessQualifiedThis Useless qualified this usage in the same class. 62

org/opentrafficsim/editor/decoration/validation/NoDuplicateChildrenValidator.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 64
UselessQualifiedThis Useless qualified this usage in the same class. 74
UnnecessaryModifier Unnecessary modifier 'final' on method 'nodesEqual': private methods cannot be overridden 126

org/opentrafficsim/editor/decoration/validation/ParentValidator.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 151
UselessQualifiedThis Useless qualified this usage in the same class. 153
UselessQualifiedThis Useless qualified this usage in the same class. 162
MisplacedNullCheck The null check here is misplaced; if the variable 'parent' is null there will be a NullPointerException 176

org/opentrafficsim/editor/decoration/validation/RoadLayoutElementValidator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'updateAllActive': private methods cannot be overridden 229
UnnecessaryModifier Unnecessary modifier 'final' on method 'getLayoutFromLink': private methods cannot be overridden 402
UnnecessarySemicolon Unnecessary semicolon 421
UnnecessaryModifier Unnecessary modifier 'static' on enum 'LayoutCoupling': nested enums are implicitly static 432

org/opentrafficsim/editor/decoration/validation/TrafficLightValidator.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 124129

org/opentrafficsim/editor/decoration/validation/XPathValidator.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 351354

org/opentrafficsim/editor/decoration/validation/XsdAllValidator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'nodesEqual': private methods cannot be overridden 94

org/opentrafficsim/editor/extensions/map/FlattenerListener.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 6972

org/opentrafficsim/editor/extensions/map/MapLinkData.java

Rule Violation Line
EmptyControlStatement Empty if statement 384396
EmptyControlStatement Empty if statement 388396
SimplifiedTernary This conditional expression can be simplified with || or && 1085

org/opentrafficsim/editor/listeners/XsdTreeKeyListener.java

Rule Violation Line
UnnecessaryReturn Unnecessary return statement 50
CollapsibleIfStatements This if statement could be combined with its parent 7578

org/opentrafficsim/editor/listeners/XsdTreeMouseListener.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 146149
UselessQualifiedThis Useless qualified this usage in the same class. 455
UselessQualifiedThis Useless qualified this usage in the same class. 456

org/opentrafficsim/editor/render/StringCellRenderer.java

Rule Violation Line
SimplifiedTernary This conditional expression can be simplified with || or && 78

Priority 4

org/opentrafficsim/editor/DocumentReader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DocumentReader': 'getChildren' is already in scope 73
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DocumentReader': 'getChildren' is already in scope 75
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DocumentReader': 'getAttribute' is already in scope 77

org/opentrafficsim/editor/OtsEditor.java

Rule Violation Line
UselessParentheses Useless parentheses. 802

org/opentrafficsim/editor/Schema.java

Rule Violation Line
UselessParentheses Useless parentheses. 326

org/opentrafficsim/editor/XiIncludeNode.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Node': 'TEXT_NODE' is already in scope because it is inherited by an enclosing type 63
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Node': 'ATTRIBUTE_NODE' is already in scope because it is inherited by an enclosing type 364

org/opentrafficsim/editor/XsdTreeNode.java

Rule Violation Line
UselessParentheses Useless parentheses. 348
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::OPTION_CHANGED' is already in scope because it is declared in an enclosing type 492
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type 1028
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type 1049
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNode': 'ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type 1064
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNode': 'ATTRIBUTE_CHANGED' is already in scope because it is declared in an enclosing type 2709

org/opentrafficsim/editor/XsdTreeNodeUtil.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'ref' is already in scope 110
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 111
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'type' is already in scope 115
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 119
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 123
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 128
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 142
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 148
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 161
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 180

org/opentrafficsim/editor/decoration/string/XiIncludeStringFunction.java

Rule Violation Line
UnnecessaryImport Unused import 'org.opentrafficsim.editor.XsdTreeNodeRoot' 8

org/opentrafficsim/editor/extensions/OdEditor.java

Rule Violation Line
UselessParentheses Useless parentheses. 64

org/opentrafficsim/editor/extensions/RouteEditor.java

Rule Violation Line
UselessParentheses Useless parentheses. 89

org/opentrafficsim/editor/extensions/map/EditorMap.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Component': 'LEFT_ALIGNMENT' is already in scope because it is inherited by an enclosing type 486

org/opentrafficsim/editor/listeners/ChangesListener.java

Rule Violation Line
UselessParentheses Useless parentheses. 111

org/opentrafficsim/editor/render/AttributeCellRenderer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SwingConstants': 'CENTER' is already in scope because it is inherited by an enclosing type 205
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SwingConstants': 'LEFT' is already in scope because it is inherited by an enclosing type 209

org/opentrafficsim/editor/render/StringCellRenderer.java

Rule Violation Line
UselessParentheses Useless parentheses. 6465
UselessParentheses Useless parentheses. 65
UselessParentheses Useless parentheses. 78

Files

org/opentrafficsim/editor/ApplicationStore.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 5558
EmptyCatchBlock Avoid empty catch blocks 3 9093

org/opentrafficsim/editor/DocumentReader.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DocumentReader': 'getChildren' is already in scope 4 73
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DocumentReader': 'getChildren' is already in scope 4 75
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DocumentReader': 'getAttribute' is already in scope 4 77

org/opentrafficsim/editor/EvalWrapper.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'evalChanged': the method is declared in an interface type 3 323

org/opentrafficsim/editor/OtsEditor.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 356
UselessQualifiedThis Useless qualified this usage in the same class. 3 357
UselessQualifiedThis Useless qualified this usage in the same class. 3 358
UselessQualifiedThis Useless qualified this usage in the same class. 3 358
EmptyCatchBlock Avoid empty catch blocks 3 364367
UselessQualifiedThis Useless qualified this usage in the same class. 3 474
UselessQualifiedThis Useless qualified this usage in the same class. 3 475
UselessQualifiedThis Useless qualified this usage in the same class. 3 475
UselessQualifiedThis Useless qualified this usage in the same class. 3 651
UselessQualifiedThis Useless qualified this usage in the same class. 3 671
UselessQualifiedThis Useless qualified this usage in the same class. 3 682
UselessQualifiedThis Useless qualified this usage in the same class. 3 723
UselessQualifiedThis Useless qualified this usage in the same class. 3 726
UselessQualifiedThis Useless qualified this usage in the same class. 3 752
UselessQualifiedThis Useless qualified this usage in the same class. 3 772
UselessParentheses Useless parentheses. 4 802
UselessQualifiedThis Useless qualified this usage in the same class. 3 884
UselessQualifiedThis Useless qualified this usage in the same class. 3 1365
UselessQualifiedThis Useless qualified this usage in the same class. 3 1374
UselessQualifiedThis Useless qualified this usage in the same class. 3 1383
UselessQualifiedThis Useless qualified this usage in the same class. 3 1392
UselessQualifiedThis Useless qualified this usage in the same class. 3 1407
UselessQualifiedThis Useless qualified this usage in the same class. 3 1564
UselessQualifiedThis Useless qualified this usage in the same class. 3 1565
UselessQualifiedThis Useless qualified this usage in the same class. 3 1645
UselessQualifiedThis Useless qualified this usage in the same class. 3 1674
UselessQualifiedThis Useless qualified this usage in the same class. 3 1899
UselessQualifiedThis Useless qualified this usage in the same class. 3 2030
UselessQualifiedThis Useless qualified this usage in the same class. 3 2030

org/opentrafficsim/editor/Schema.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 326

org/opentrafficsim/editor/XiIncludeNode.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Node': 'TEXT_NODE' is already in scope because it is inherited by an enclosing type 4 63
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Node': 'ATTRIBUTE_NODE' is already in scope because it is inherited by an enclosing type 4 364

org/opentrafficsim/editor/XsdTreeNode.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 348
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::OPTION_CHANGED' is already in scope because it is declared in an enclosing type 4 492
EmptyCatchBlock Avoid empty catch blocks 3 623626
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type 4 1028
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type 4 1049
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNode': 'ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type 4 1064
UnusedFormalParameter Avoid unused method parameters such as 'field'. 3 2046
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNode': 'ATTRIBUTE_CHANGED' is already in scope because it is declared in an enclosing type 4 2709

org/opentrafficsim/editor/XsdTreeNodeUtil.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'ref' is already in scope 4 110
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 4 111
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'type' is already in scope 4 115
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 4 119
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 4 123
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 4 128
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 4 142
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 4 148
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 4 161
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope 4 180

org/opentrafficsim/editor/decoration/AbstractNodeDecorator.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 47

org/opentrafficsim/editor/decoration/AbstractNodeDecoratorAttribute.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 56
UselessQualifiedThis Useless qualified this usage in the same class. 3 58

org/opentrafficsim/editor/decoration/string/AbstractStringFunction.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 48

org/opentrafficsim/editor/decoration/string/AttributesStringFunction.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 58
UselessQualifiedThis Useless qualified this usage in the same class. 3 64

org/opentrafficsim/editor/decoration/string/ChoiceNodeStringFunction.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 62

org/opentrafficsim/editor/decoration/string/XiIncludeStringFunction.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'org.opentrafficsim.editor.XsdTreeNodeRoot' 4 8

org/opentrafficsim/editor/decoration/validation/AttributesNotEqualValidator.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 61
UselessQualifiedThis Useless qualified this usage in the same class. 3 62

org/opentrafficsim/editor/decoration/validation/NoDuplicateChildrenValidator.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 64
UselessQualifiedThis Useless qualified this usage in the same class. 3 74
UnnecessaryModifier Unnecessary modifier 'final' on method 'nodesEqual': private methods cannot be overridden 3 126

org/opentrafficsim/editor/decoration/validation/ParentValidator.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 151
UselessQualifiedThis Useless qualified this usage in the same class. 3 153
UselessQualifiedThis Useless qualified this usage in the same class. 3 162
MisplacedNullCheck The null check here is misplaced; if the variable 'parent' is null there will be a NullPointerException 3 176

org/opentrafficsim/editor/decoration/validation/RoadLayoutElementValidator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'updateAllActive': private methods cannot be overridden 3 229
UnnecessaryModifier Unnecessary modifier 'final' on method 'getLayoutFromLink': private methods cannot be overridden 3 402
UnnecessarySemicolon Unnecessary semicolon 3 421
UnnecessaryModifier Unnecessary modifier 'static' on enum 'LayoutCoupling': nested enums are implicitly static 3 432

org/opentrafficsim/editor/decoration/validation/TrafficLightValidator.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 124129

org/opentrafficsim/editor/decoration/validation/XPathValidator.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 351354

org/opentrafficsim/editor/decoration/validation/XsdAllValidator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'nodesEqual': private methods cannot be overridden 3 94

org/opentrafficsim/editor/extensions/OdEditor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 64

org/opentrafficsim/editor/extensions/RouteEditor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 89

org/opentrafficsim/editor/extensions/map/EditorMap.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Component': 'LEFT_ALIGNMENT' is already in scope because it is inherited by an enclosing type 4 486

org/opentrafficsim/editor/extensions/map/FlattenerListener.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 6972

org/opentrafficsim/editor/extensions/map/MapLinkData.java

Rule Violation Priority Line
EmptyControlStatement Empty if statement 3 384396
EmptyControlStatement Empty if statement 3 388396
SimplifiedTernary This conditional expression can be simplified with || or && 3 1085

org/opentrafficsim/editor/listeners/ChangesListener.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 111

org/opentrafficsim/editor/listeners/XsdTreeKeyListener.java

Rule Violation Priority Line
UnnecessaryReturn Unnecessary return statement 3 50
CollapsibleIfStatements This if statement could be combined with its parent 3 7578

org/opentrafficsim/editor/listeners/XsdTreeMouseListener.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 146149
UselessQualifiedThis Useless qualified this usage in the same class. 3 455
UselessQualifiedThis Useless qualified this usage in the same class. 3 456

org/opentrafficsim/editor/render/AttributeCellRenderer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SwingConstants': 'CENTER' is already in scope because it is inherited by an enclosing type 4 205
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SwingConstants': 'LEFT' is already in scope because it is inherited by an enclosing type 4 209

org/opentrafficsim/editor/render/StringCellRenderer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 6465
UselessParentheses Useless parentheses. 4 65
SimplifiedTernary This conditional expression can be simplified with || or && 3 78
UselessParentheses Useless parentheses. 4 78