PMD Results
The following document contains the results of PMD 7.7.0.
Violations By Priority
Priority 3
org/opentrafficsim/editor/ApplicationStore.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 86–89 |
| EmptyCatchBlock | Avoid empty catch blocks | 130–133 |
org/opentrafficsim/editor/OtsEditor.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 319 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 320 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 321 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 321 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 470 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 471 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 471 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 655 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 670 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 674 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 713 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 716 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 742 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 762 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 872 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1218 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1227 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1237 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1247 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1256 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1272 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1397 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1398 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1473 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1502 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1721 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 1721 |
org/opentrafficsim/editor/PropertiesDialog.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 132 |
org/opentrafficsim/editor/XsdTreeNode.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 659–662 |
org/opentrafficsim/editor/XsdTreeNodeUtil.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'node'. | 179 |
| UnusedFormalParameter | Avoid unused method parameters such as 'node'. | 211 |
org/opentrafficsim/editor/decoration/AbstractNodeDecoratorAttribute.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 60 |
org/opentrafficsim/editor/decoration/string/AttributesStringFunction.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 54 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 60 |
org/opentrafficsim/editor/decoration/validation/AttributesNotEqualValidator.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 70 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 71 |
org/opentrafficsim/editor/decoration/validation/KeyValidator.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'fieldIndex'. | 276 |
org/opentrafficsim/editor/decoration/validation/ParentValidator.java
| Rule | Violation | Line |
|---|---|---|
| MisplacedNullCheck | The null check here is misplaced; if the variable 'parent' is null there will be a NullPointerException | 164 |
org/opentrafficsim/editor/decoration/validation/TrafficLightValidator.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 135–139 |
org/opentrafficsim/editor/decoration/validation/XPathValidator.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 387–390 |
org/opentrafficsim/editor/extensions/map/FlattenerListener.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 61–64 |
org/opentrafficsim/editor/extensions/map/MapLinkData.java
| Rule | Violation | Line |
|---|---|---|
| EmptyControlStatement | Empty if statement | 398–410 |
| EmptyControlStatement | Empty if statement | 402–410 |
| EmptyCatchBlock | Avoid empty catch blocks | 749–752 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 1311 |
org/opentrafficsim/editor/listeners/XsdTreeKeyListener.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryReturn | Unnecessary return statement | 56 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 81–84 |
org/opentrafficsim/editor/render/StringCellRenderer.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 78 |
Priority 4
org/opentrafficsim/editor/DocumentReader.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DocumentReader': 'getChildren' is already in scope | 186 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DocumentReader': 'getChildren' is already in scope | 188 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DocumentReader': 'getAttribute' is already in scope | 190 |
org/opentrafficsim/editor/OtsEditor.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 792 |
org/opentrafficsim/editor/Schema.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 334 |
org/opentrafficsim/editor/XiIncludeNode.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Node': 'TEXT_NODE' is already in scope because it is inherited by an enclosing type | 59 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Node': 'ATTRIBUTE_NODE' is already in scope because it is inherited by an enclosing type | 316 |
org/opentrafficsim/editor/XsdTreeNode.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::OPTION_CHANGED' is already in scope because it is declared in an enclosing type | 478 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type | 1074 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type | 1095 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNode': 'ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type | 1110 |
org/opentrafficsim/editor/XsdTreeNodeUtil.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope | 121 |
org/opentrafficsim/editor/extensions/OdEditor.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 60 |
org/opentrafficsim/editor/extensions/RouteEditor.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 83 |
org/opentrafficsim/editor/extensions/map/EditorMap.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Component': 'LEFT_ALIGNMENT' is already in scope because it is inherited by an enclosing type | 530 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'ChangeListener': 'CHANGE_EVENT' is already in scope because it is inherited by an enclosing type | 632 |
org/opentrafficsim/editor/extensions/map/MapLinkData.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.util': 'Map' is already in scope because it is imported in this file | 152 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.util': 'Map' is already in scope because it is imported in this file | 155 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.util': 'Map' is already in scope because it is imported in this file | 606 |
org/opentrafficsim/editor/extensions/map/SynchronizableMapStripe.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 56 |
| UselessParentheses | Useless parentheses. | 66 |
org/opentrafficsim/editor/listeners/ChangesListener.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 99 |
org/opentrafficsim/editor/render/AttributeCellRenderer.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SwingConstants': 'CENTER' is already in scope because it is inherited by an enclosing type | 207 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SwingConstants': 'LEFT' is already in scope because it is inherited by an enclosing type | 211 |
org/opentrafficsim/editor/render/StringCellRenderer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 64–65 |
| UselessParentheses | Useless parentheses. | 65 |
| UselessParentheses | Useless parentheses. | 78 |
Files
org/opentrafficsim/editor/ApplicationStore.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 86–89 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 130–133 |
org/opentrafficsim/editor/DocumentReader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DocumentReader': 'getChildren' is already in scope | 4 | 186 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DocumentReader': 'getChildren' is already in scope | 4 | 188 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'DocumentReader': 'getAttribute' is already in scope | 4 | 190 |
org/opentrafficsim/editor/OtsEditor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 319 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 320 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 321 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 321 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 470 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 471 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 471 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 655 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 670 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 674 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 713 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 716 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 742 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 762 |
| UselessParentheses | Useless parentheses. | 4 | 792 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 872 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1218 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1227 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1237 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1247 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1256 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1272 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1397 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1398 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1473 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1502 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1721 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 1721 |
org/opentrafficsim/editor/PropertiesDialog.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 132 |
org/opentrafficsim/editor/Schema.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 334 |
org/opentrafficsim/editor/XiIncludeNode.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Node': 'TEXT_NODE' is already in scope because it is inherited by an enclosing type | 4 | 59 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Node': 'ATTRIBUTE_NODE' is already in scope because it is inherited by an enclosing type | 4 | 316 |
org/opentrafficsim/editor/XsdTreeNode.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::OPTION_CHANGED' is already in scope because it is declared in an enclosing type | 4 | 478 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 659–662 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type | 4 | 1074 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNodeRoot': 'XsdTreeNode::ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type | 4 | 1095 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNode': 'ACTIVATION_CHANGED' is already in scope because it is declared in an enclosing type | 4 | 1110 |
org/opentrafficsim/editor/XsdTreeNodeUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'XsdTreeNodeUtil': 'append' is already in scope | 4 | 121 |
| UnusedFormalParameter | Avoid unused method parameters such as 'node'. | 3 | 179 |
| UnusedFormalParameter | Avoid unused method parameters such as 'node'. | 3 | 211 |
org/opentrafficsim/editor/decoration/AbstractNodeDecoratorAttribute.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 60 |
org/opentrafficsim/editor/decoration/string/AttributesStringFunction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 54 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 60 |
org/opentrafficsim/editor/decoration/validation/AttributesNotEqualValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 70 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 71 |
org/opentrafficsim/editor/decoration/validation/KeyValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'fieldIndex'. | 3 | 276 |
org/opentrafficsim/editor/decoration/validation/ParentValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MisplacedNullCheck | The null check here is misplaced; if the variable 'parent' is null there will be a NullPointerException | 3 | 164 |
org/opentrafficsim/editor/decoration/validation/TrafficLightValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 135–139 |
org/opentrafficsim/editor/decoration/validation/XPathValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 387–390 |
org/opentrafficsim/editor/extensions/OdEditor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 60 |
org/opentrafficsim/editor/extensions/RouteEditor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 83 |
org/opentrafficsim/editor/extensions/map/EditorMap.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Component': 'LEFT_ALIGNMENT' is already in scope because it is inherited by an enclosing type | 4 | 530 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'ChangeListener': 'CHANGE_EVENT' is already in scope because it is inherited by an enclosing type | 4 | 632 |
org/opentrafficsim/editor/extensions/map/FlattenerListener.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 61–64 |
org/opentrafficsim/editor/extensions/map/MapLinkData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.util': 'Map' is already in scope because it is imported in this file | 4 | 152 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.util': 'Map' is already in scope because it is imported in this file | 4 | 155 |
| EmptyControlStatement | Empty if statement | 3 | 398–410 |
| EmptyControlStatement | Empty if statement | 3 | 402–410 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.util': 'Map' is already in scope because it is imported in this file | 4 | 606 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 749–752 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 1311 |
org/opentrafficsim/editor/extensions/map/SynchronizableMapStripe.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 56 |
| UselessParentheses | Useless parentheses. | 4 | 66 |
org/opentrafficsim/editor/listeners/ChangesListener.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 99 |
org/opentrafficsim/editor/listeners/XsdTreeKeyListener.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryReturn | Unnecessary return statement | 3 | 56 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 81–84 |
org/opentrafficsim/editor/render/AttributeCellRenderer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SwingConstants': 'CENTER' is already in scope because it is inherited by an enclosing type | 4 | 207 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SwingConstants': 'LEFT' is already in scope because it is inherited by an enclosing type | 4 | 211 |
org/opentrafficsim/editor/render/StringCellRenderer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 64–65 |
| UselessParentheses | Useless parentheses. | 4 | 65 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 78 |
| UselessParentheses | Useless parentheses. | 4 | 78 |