PMD Results
The following document contains the results of PMD 7.3.0.
Violations By Priority
Priority 2
org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCfLcTacticalPlanner.java
| Rule | Violation | Line |
|---|---|---|
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 499 |
Priority 3
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 485–488 |
| UnnecessaryModifier | Unnecessary modifier 'public' on interface 'RoadPosition': the interface is declared in an interface type | 855 |
org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'projection'. | 978 |
| EmptyCatchBlock | Avoid empty catch blocks | 1378–1381 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 1651 |
org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 122 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 124 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 125 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 129 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 130 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 307–310 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 318 |
org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectableFiltered.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 59–62 |
org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 706–710 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 837–854 |
org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 35 |
org/opentrafficsim/road/gtu/lane/perception/structure/LaneStructure.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 88 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 94 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 133 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 182 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 183 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 184 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 253 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 254 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 313 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 314 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 352 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 353 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 393 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 412 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 433 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 455 |
org/opentrafficsim/road/gtu/lane/perception/structure/NavigatingIterable.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 86 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'planDistance'. | 687 |
| UnusedFormalParameter | Avoid unused method parameters such as 'width'. | 688 |
| UnusedFormalParameter | Avoid unused method parameters such as 'from'. | 688 |
| UnusedFormalParameter | Avoid unused method parameters such as 'startPosition'. | 688 |
| UnusedFormalParameter | Avoid unused method parameters such as 'fromLine'. | 688 |
| UnusedFormalParameter | Avoid unused method parameters such as 'toLine'. | 689 |
| UnusedLocalVariable | Avoid unused local variables such as 'f'. | 700 |
| UnusedLocalVariable | Avoid unused local variables such as 'cumulLcLength'. | 704 |
org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCfLcTacticalPlanner.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'currentLaneFine'. | 148 |
| UnusedLocalVariable | Avoid unused local variables such as 'nextSplitNode'. | 421 |
| UnusedLocalVariable | Avoid unused local variables such as 'nextLane'. | 496 |
org/opentrafficsim/road/gtu/lane/tactical/LanePathInfo.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getReferenceLane': the method is already in a final class | 44 |
org/opentrafficsim/road/gtu/lane/tactical/NextSplitInfo.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class | 45 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 72–81 |
org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'gtu'. | 698 |
org/opentrafficsim/road/gtu/lane/tactical/util/AnticipationInfo.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on record 'AnticipationInfo': records are implicitly final | 28 |
org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 191–202 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 499–515 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 93 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Desire.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'get': the method is already in a final class | 56 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'leftIsLargerOrEqual': the method is already in a final class | 73 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 109 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 186–203 |
| UnusedPrivateMethod | Avoid unused private methods such as 'quickIntersectionScan(Parameters, SpeedLimitInfo, CarFollowingModel, Speed, LateralDirectionality, IntersectionPerception)'. | 589 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 360–361 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 377–378 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type | 469 |
org/opentrafficsim/road/gtu/strategical/RouteGenerator.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 116–119 |
| UnnecessarySemicolon | Unnecessary semicolon | 161 |
org/opentrafficsim/road/network/RoadNetwork.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'LaneChangeInfoEdge': records are implicitly static | 524 |
org/opentrafficsim/road/network/factory/LaneFactory.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'simulator'. | 125 |
| UnusedFormalParameter | Avoid unused method parameters such as 'simulator'. | 404 |
org/opentrafficsim/road/network/lane/Lane.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 294–298 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 334–338 |
org/opentrafficsim/road/network/lane/LanePosition.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getLocation': the method is already in a final class | 31 |
org/opentrafficsim/road/network/lane/conflict/Conflict.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 413–446 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 663–681 |
org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 269–272 |
| EmptyCatchBlock | Avoid empty catch blocks | 1074–1077 |
| EmptyCatchBlock | Avoid empty catch blocks | 1096–1099 |
| EmptyCatchBlock | Avoid empty catch blocks | 1109–1112 |
| EmptyCatchBlock | Avoid empty catch blocks | 1166–1169 |
| EmptyCatchBlock | Avoid empty catch blocks | 1187–1190 |
| EmptyCatchBlock | Avoid empty catch blocks | 1200–1203 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordSmall': records are implicitly static | 1318 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordBig': records are implicitly static | 1432 |
org/opentrafficsim/road/network/lane/conflict/ConflictPriority.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPriority': the method is already in a final class | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGiveWay': the method is already in a final class | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isStop': the method is already in a final class | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isAllStop': the method is already in a final class | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class | 71 |
org/opentrafficsim/road/network/lane/object/BusStop.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'name'. | 41 |
org/opentrafficsim/road/network/lane/object/detector/TrafficLightDetector.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryReturn | Unnecessary return statement | 251 |
org/opentrafficsim/road/network/lane/object/trafficlight/TrafficLightColor.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRedOrYellow': the method is already in a final class | 31 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRed': the method is already in a final class | 37 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isYellow': the method is already in a final class | 43 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGreen': the method is already in a final class | 49 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPreGreen': the method is already in a final class | 55 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isBlack': the method is already in a final class | 61 |
org/opentrafficsim/road/network/speed/SpeedInfoCurvature.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getSpeedForLateralAcceleration': the method is already in a final class | 43 |
org/opentrafficsim/road/od/OdApplier.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'GeneratorObjects': records are implicitly static | 910 |
Priority 4
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 775 |
| UselessParentheses | Useless parentheses. | 974 |
org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 300 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 473 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_MOVE_EVENT' is already in scope because it is declared in an enclosing type | 544 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 1409 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 1417 |
org/opentrafficsim/road/gtu/lane/perception/categories/WienerProcess.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 86 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/Estimation.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 91 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'org.opentrafficsim.base.geometry.OtsLocatable' | 7 |
| UnnecessaryImport | Unused import 'org.opentrafficsim.road.network.lane.conflict.Conflict' | 16 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 76 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 44 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 84 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 39 |
org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 52 |
org/opentrafficsim/road/gtu/lane/perception/structure/LaneStructure.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 610–611 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneBasedOperationalPlan.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 138 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 632 |
| UselessParentheses | Useless parentheses. | 632 |
| UselessParentheses | Useless parentheses. | 765 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope | 289 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope | 296 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope | 301 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationLaneChangePlan' is already in scope | 304 |
org/opentrafficsim/road/gtu/lane/tactical/LaneBasedTacticalPlanner.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedTacticalPlanner': 'mostOnSide' is already in scope | 88 |
org/opentrafficsim/road/gtu/lane/tactical/directedlanechange/AbstractDirectedLaneChangeModel.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'org.opentrafficsim.core.gtu.plan.operational.OperationalPlanException' | 15 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveRoute.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 117 |
org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type | 185 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type | 207 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type | 225 |
| UselessParentheses | Useless parentheses. | 745 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Tailgating.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused static import 'org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Tailgating.socialPressure' | 3 |
org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalRoutePlanner.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 168 |
org/opentrafficsim/road/network/RoadNetwork.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 335 |
org/opentrafficsim/road/network/lane/Lane.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 275 |
| UselessParentheses | Useless parentheses. | 277 |
| UselessParentheses | Useless parentheses. | 315 |
| UselessParentheses | Useless parentheses. | 317 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_ADD_EVENT' is already in scope because it is declared in an enclosing type | 378 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 389 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 590 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 600 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 760 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 793 |
| UselessParentheses | Useless parentheses. | 1032 |
| UselessParentheses | Useless parentheses. | 1100 |
org/opentrafficsim/road/network/lane/object/AbstractLaneBasedObject.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 76 |
org/opentrafficsim/road/network/lane/object/detector/LaneDetector.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DEFAULT_DETECTOR_ELEVATION' is already in scope because it is declared in an enclosing type | 103 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DETECTOR_TRIGGER_EVENT' is already in scope because it is declared in an enclosing type | 138 |
org/opentrafficsim/road/network/lane/object/detector/TrafficLightDetector.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_ENTRY_EVENT' is already in scope because it is declared in an enclosing type | 192 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 205 |
org/opentrafficsim/road/od/OdApplier.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 332 |
| UselessParentheses | Useless parentheses. | 337 |
org/opentrafficsim/road/od/SplitFraction.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 175 |
Files
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 485–488 |
| UselessParentheses | Useless parentheses. | 4 | 775 |
| UnnecessaryModifier | Unnecessary modifier 'public' on interface 'RoadPosition': the interface is declared in an interface type | 3 | 855 |
| UselessParentheses | Useless parentheses. | 4 | 974 |
org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 300 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 473 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_MOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 544 |
| UnusedLocalVariable | Avoid unused local variables such as 'projection'. | 3 | 978 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1378–1381 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 1409 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 1417 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 1651 |
org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 122 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 124 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 125 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 129 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 130 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 307–310 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 318 |
org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectableFiltered.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 59–62 |
org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 706–710 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 837–854 |
org/opentrafficsim/road/gtu/lane/perception/categories/WienerProcess.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 86 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/Estimation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 91 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'org.opentrafficsim.base.geometry.OtsLocatable' | 4 | 7 |
| UnnecessaryImport | Unused import 'org.opentrafficsim.road.network.lane.conflict.Conflict' | 4 | 16 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 76 |
org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 3 | 35 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 44 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 84 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 39 |
org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 52 |
org/opentrafficsim/road/gtu/lane/perception/structure/LaneStructure.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 88 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 94 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 133 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 182 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 183 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 184 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 253 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 254 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 313 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 314 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 352 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 353 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 393 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 412 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 433 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 455 |
| UselessParentheses | Useless parentheses. | 4 | 610–611 |
org/opentrafficsim/road/gtu/lane/perception/structure/NavigatingIterable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 86 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneBasedOperationalPlan.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 138 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 632 |
| UselessParentheses | Useless parentheses. | 4 | 632 |
| UnusedFormalParameter | Avoid unused method parameters such as 'planDistance'. | 3 | 687 |
| UnusedFormalParameter | Avoid unused method parameters such as 'width'. | 3 | 688 |
| UnusedFormalParameter | Avoid unused method parameters such as 'from'. | 3 | 688 |
| UnusedFormalParameter | Avoid unused method parameters such as 'startPosition'. | 3 | 688 |
| UnusedFormalParameter | Avoid unused method parameters such as 'fromLine'. | 3 | 688 |
| UnusedFormalParameter | Avoid unused method parameters such as 'toLine'. | 3 | 689 |
| UnusedLocalVariable | Avoid unused local variables such as 'f'. | 3 | 700 |
| UnusedLocalVariable | Avoid unused local variables such as 'cumulLcLength'. | 3 | 704 |
| UselessParentheses | Useless parentheses. | 4 | 765 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope | 4 | 289 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope | 4 | 296 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationPlan' is already in scope | 4 | 301 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneOperationalPlanBuilder': 'buildAccelerationLaneChangePlan' is already in scope | 4 | 304 |
org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCfLcTacticalPlanner.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'currentLaneFine'. | 3 | 148 |
| UnusedLocalVariable | Avoid unused local variables such as 'nextSplitNode'. | 3 | 421 |
| UnusedLocalVariable | Avoid unused local variables such as 'nextLane'. | 3 | 496 |
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 2 | 499 |
org/opentrafficsim/road/gtu/lane/tactical/LaneBasedTacticalPlanner.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedTacticalPlanner': 'mostOnSide' is already in scope | 4 | 88 |
org/opentrafficsim/road/gtu/lane/tactical/LanePathInfo.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getReferenceLane': the method is already in a final class | 3 | 44 |
org/opentrafficsim/road/gtu/lane/tactical/NextSplitInfo.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class | 3 | 45 |
org/opentrafficsim/road/gtu/lane/tactical/directedlanechange/AbstractDirectedLaneChangeModel.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'org.opentrafficsim.core.gtu.plan.operational.OperationalPlanException' | 4 | 15 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 72–81 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveRoute.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 117 |
org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type | 4 | 185 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type | 4 | 207 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Toledo': 'RANDOM' is already in scope because it is declared in an enclosing type | 4 | 225 |
| UnusedFormalParameter | Avoid unused method parameters such as 'gtu'. | 3 | 698 |
| UselessParentheses | Useless parentheses. | 4 | 745 |
org/opentrafficsim/road/gtu/lane/tactical/util/AnticipationInfo.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on record 'AnticipationInfo': records are implicitly final | 3 | 28 |
org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 191–202 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 499–515 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 93 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Desire.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'get': the method is already in a final class | 3 | 56 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'leftIsLargerOrEqual': the method is already in a final class | 3 | 73 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 109 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 186–203 |
| UnusedPrivateMethod | Avoid unused private methods such as 'quickIntersectionScan(Parameters, SpeedLimitInfo, CarFollowingModel, Speed, LateralDirectionality, IntersectionPerception)'. | 3 | 589 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 360–361 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 377–378 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type | 3 | 469 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Tailgating.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused static import 'org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Tailgating.socialPressure' | 4 | 3 |
org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalRoutePlanner.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 168 |
org/opentrafficsim/road/gtu/strategical/RouteGenerator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 116–119 |
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 161 |
org/opentrafficsim/road/network/RoadNetwork.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 335 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'LaneChangeInfoEdge': records are implicitly static | 3 | 524 |
org/opentrafficsim/road/network/factory/LaneFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'simulator'. | 3 | 125 |
| UnusedFormalParameter | Avoid unused method parameters such as 'simulator'. | 3 | 404 |
org/opentrafficsim/road/network/lane/Lane.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 275 |
| UselessParentheses | Useless parentheses. | 4 | 277 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 294–298 |
| UselessParentheses | Useless parentheses. | 4 | 315 |
| UselessParentheses | Useless parentheses. | 4 | 317 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 334–338 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 378 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 389 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 590 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 600 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 760 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 793 |
| UselessParentheses | Useless parentheses. | 4 | 1032 |
| UselessParentheses | Useless parentheses. | 4 | 1100 |
org/opentrafficsim/road/network/lane/LanePosition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getLocation': the method is already in a final class | 3 | 31 |
org/opentrafficsim/road/network/lane/conflict/Conflict.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 413–446 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 663–681 |
org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 269–272 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1074–1077 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1096–1099 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1109–1112 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1166–1169 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1187–1190 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1200–1203 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordSmall': records are implicitly static | 3 | 1318 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordBig': records are implicitly static | 3 | 1432 |
org/opentrafficsim/road/network/lane/conflict/ConflictPriority.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPriority': the method is already in a final class | 3 | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGiveWay': the method is already in a final class | 3 | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isStop': the method is already in a final class | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isAllStop': the method is already in a final class | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class | 3 | 71 |
org/opentrafficsim/road/network/lane/object/AbstractLaneBasedObject.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 76 |
org/opentrafficsim/road/network/lane/object/BusStop.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'name'. | 3 | 41 |
org/opentrafficsim/road/network/lane/object/detector/LaneDetector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DEFAULT_DETECTOR_ELEVATION' is already in scope because it is declared in an enclosing type | 4 | 103 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DETECTOR_TRIGGER_EVENT' is already in scope because it is declared in an enclosing type | 4 | 138 |
org/opentrafficsim/road/network/lane/object/detector/TrafficLightDetector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_ENTRY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 192 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 4 | 205 |
| UnnecessaryReturn | Unnecessary return statement | 3 | 251 |
org/opentrafficsim/road/network/lane/object/trafficlight/TrafficLightColor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRedOrYellow': the method is already in a final class | 3 | 31 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRed': the method is already in a final class | 3 | 37 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isYellow': the method is already in a final class | 3 | 43 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGreen': the method is already in a final class | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPreGreen': the method is already in a final class | 3 | 55 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isBlack': the method is already in a final class | 3 | 61 |
org/opentrafficsim/road/network/speed/SpeedInfoCurvature.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getSpeedForLateralAcceleration': the method is already in a final class | 3 | 43 |
org/opentrafficsim/road/od/OdApplier.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 332 |
| UselessParentheses | Useless parentheses. | 4 | 337 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'GeneratorObjects': records are implicitly static | 3 | 910 |
org/opentrafficsim/road/od/SplitFraction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 175 |
Suppressed Violations
| Filename | Rule message | Suppression type | Reason |
|---|---|---|---|
| org/opentrafficsim/road/gtu/generator/LaneBasedGtuGenerator.java | Avoid unused private methods such as 'generateCharacteristics()'. | @suppresswarnings | |
| org/opentrafficsim/road/gtu/generator/LaneBasedGtuGenerator.java | Avoid unused private methods such as 'enable()'. | @suppresswarnings | |
| org/opentrafficsim/road/gtu/generator/LaneBasedGtuGenerator.java | Avoid unused private methods such as 'disable(Lane)'. | @suppresswarnings | |
| org/opentrafficsim/road/gtu/generator/LaneBasedGtuGenerator.java | Avoid unused private methods such as 'tryToPlaceGTU(GeneratorLanePosition)'. | @suppresswarnings | |
| org/opentrafficsim/road/network/lane/object/detector/LoopDetector.java | Avoid unused private methods such as 'aggregate()'. | @suppresswarnings |