PMD Results
The following document contains the results of PMD 7.7.0.
Violations By Priority
Priority 3
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 488–491 |
org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 1481 |
org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 123 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 125 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 126 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 130 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 131 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 310–313 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 321 |
org/opentrafficsim/road/gtu/lane/perception/categories/DirectIntersectionPerception.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 121 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/CaccPerception.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 89 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 177 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 203 |
org/opentrafficsim/road/gtu/lane/perception/mental/ar/ArTaskLaneChanging.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'perception'. | 94 |
| UnusedFormalParameter | Avoid unused method parameters such as 'parameters'. | 94 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/ChannelTaskAcceleration.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 97–100 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/ChannelTaskCooperation.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 90–93 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/IntersectionPerceptionChannel.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 119 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 139 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 140 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 141 |
org/opentrafficsim/road/gtu/lane/perception/object/PerceivedGtu.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessarySemicolon | Unnecessary semicolon | 154 |
| UnnecessarySemicolon | Unnecessary semicolon | 261 |
org/opentrafficsim/road/gtu/lane/perception/structure/LaneStructure.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 89 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 96 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 135 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 184 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 185 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 186 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 254 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 255 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 313 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 314 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 352 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 353 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 393 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 412 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 433 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 455 |
org/opentrafficsim/road/gtu/lane/perception/structure/NavigatingIterable.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 86 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'deviation'. | 392 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 94–103 |
org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 550–566 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 93 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Desire.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'get': the method is already in a final class | 52 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'leftIsLargerOrEqual': the method is already in a final class | 69 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 111 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 181–197 |
| UnusedPrivateMethod | Avoid unused private methods such as 'quickIntersectionScan(Parameters, SpeedLimitInfo, CarFollowingModel, Speed, LateralDirectionality, IntersectionPerception)'. | 576 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 339–340 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 356–357 |
org/opentrafficsim/road/gtu/strategical/RouteGenerator.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 116–119 |
| UnnecessarySemicolon | Unnecessary semicolon | 161 |
org/opentrafficsim/road/network/factory/LaneFactory.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'simulator'. | 126 |
| UnusedFormalParameter | Avoid unused method parameters such as 'simulator'. | 408 |
org/opentrafficsim/road/network/lane/Lane.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 286–290 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 326–330 |
org/opentrafficsim/road/network/lane/conflict/Conflict.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 446–479 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 622–640 |
org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 272–275 |
| EmptyCatchBlock | Avoid empty catch blocks | 1075–1078 |
| EmptyCatchBlock | Avoid empty catch blocks | 1097–1100 |
| EmptyCatchBlock | Avoid empty catch blocks | 1110–1113 |
| EmptyCatchBlock | Avoid empty catch blocks | 1167–1170 |
| EmptyCatchBlock | Avoid empty catch blocks | 1188–1191 |
| EmptyCatchBlock | Avoid empty catch blocks | 1201–1204 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordSmall': records are implicitly static | 1317 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordBig': records are implicitly static | 1430 |
org/opentrafficsim/road/network/lane/conflict/ConflictPriority.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPriority': the method is already in a final class | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGiveWay': the method is already in a final class | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isStop': the method is already in a final class | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isAllStop': the method is already in a final class | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class | 71 |
org/opentrafficsim/road/network/lane/object/BusStop.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'name'. | 38 |
org/opentrafficsim/road/network/lane/object/trafficlight/TrafficLightColor.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRedOrYellow': the method is already in a final class | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRed': the method is already in a final class | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isYellow': the method is already in a final class | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGreen': the method is already in a final class | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPreGreen': the method is already in a final class | 71 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isBlack': the method is already in a final class | 80 |
org/opentrafficsim/road/network/speed/SpeedInfoCurvature.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getSpeedForLateralAcceleration': the method is already in a final class | 38 |
Priority 4
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 786 |
| UselessParentheses | Useless parentheses. | 969 |
org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 312 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_ENTER_EVENT' is already in scope because it is declared in an enclosing type | 330 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 340 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 349 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 651 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_MOVE_EVENT' is already in scope because it is declared in an enclosing type | 695 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 1570 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 1578 |
org/opentrafficsim/road/gtu/lane/perception/categories/WienerProcess.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 83 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/Estimation.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 73 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 76 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 88 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 49 |
org/opentrafficsim/road/gtu/lane/perception/mental/ar/ArTaskHeadwayBased.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 51 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/ChannelTaskLaneChange.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 67 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/ChannelTaskRoadSideDistraction.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 69 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/NeighborsPerceptionChannel.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 207 |
| UselessParentheses | Useless parentheses. | 236 |
org/opentrafficsim/road/gtu/lane/perception/structure/LaneStructure.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 610–611 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 574 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveRoute.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 135 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/LmrsFactory.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 880 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 54–55 |
| UselessParentheses | Useless parentheses. | 97–98 |
| UselessParentheses | Useless parentheses. | 138–139 |
org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalRoutePlanner.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 165 |
org/opentrafficsim/road/network/RoadNetwork.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 335 |
org/opentrafficsim/road/network/lane/Lane.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 267 |
| UselessParentheses | Useless parentheses. | 269 |
| UselessParentheses | Useless parentheses. | 307 |
| UselessParentheses | Useless parentheses. | 309 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_ADD_EVENT' is already in scope because it is declared in an enclosing type | 370 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 381 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 520 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 530 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 682 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 718 |
| UselessParentheses | Useless parentheses. | 958 |
| UselessParentheses | Useless parentheses. | 1026 |
org/opentrafficsim/road/network/lane/object/AbstractLaneBasedObject.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 74 |
org/opentrafficsim/road/network/lane/object/detector/LaneDetector.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DEFAULT_DETECTOR_ELEVATION' is already in scope because it is declared in an enclosing type | 100 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DETECTOR_TRIGGER_EVENT' is already in scope because it is declared in an enclosing type | 135 |
org/opentrafficsim/road/network/lane/object/detector/TrafficLightDetector.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_ENTRY_EVENT' is already in scope because it is declared in an enclosing type | 197 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 215 |
org/opentrafficsim/road/od/OdApplier.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 337 |
| UselessParentheses | Useless parentheses. | 342 |
org/opentrafficsim/road/od/SplitFraction.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 176 |
Files
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 488–491 |
| UselessParentheses | Useless parentheses. | 4 | 786 |
| UselessParentheses | Useless parentheses. | 4 | 969 |
org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 4 | 312 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_ENTER_EVENT' is already in scope because it is declared in an enclosing type | 4 | 330 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 4 | 340 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 349 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 651 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_MOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 695 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 1481 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 1570 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 1578 |
org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 123 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 125 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 126 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 130 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 131 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 310–313 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 321 |
org/opentrafficsim/road/gtu/lane/perception/categories/DirectIntersectionPerception.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 121 |
org/opentrafficsim/road/gtu/lane/perception/categories/WienerProcess.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 83 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/CaccPerception.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 89 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 177 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 203 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/Estimation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 73 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 76 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 88 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 49 |
org/opentrafficsim/road/gtu/lane/perception/mental/ar/ArTaskHeadwayBased.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 51 |
org/opentrafficsim/road/gtu/lane/perception/mental/ar/ArTaskLaneChanging.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'perception'. | 3 | 94 |
| UnusedFormalParameter | Avoid unused method parameters such as 'parameters'. | 3 | 94 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/ChannelTaskAcceleration.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 97–100 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/ChannelTaskCooperation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 90–93 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/ChannelTaskLaneChange.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 67 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/ChannelTaskRoadSideDistraction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 69 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/IntersectionPerceptionChannel.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 119 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 139 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 140 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 141 |
org/opentrafficsim/road/gtu/lane/perception/mental/channel/NeighborsPerceptionChannel.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 207 |
| UselessParentheses | Useless parentheses. | 4 | 236 |
org/opentrafficsim/road/gtu/lane/perception/object/PerceivedGtu.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 154 |
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 261 |
org/opentrafficsim/road/gtu/lane/perception/structure/LaneStructure.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 89 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 96 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 135 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 184 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 185 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 186 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 254 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 255 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 313 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 314 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 352 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 353 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 393 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 412 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 433 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 455 |
| UselessParentheses | Useless parentheses. | 4 | 610–611 |
org/opentrafficsim/road/gtu/lane/perception/structure/NavigatingIterable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 86 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'deviation'. | 3 | 392 |
| UselessParentheses | Useless parentheses. | 4 | 574 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 94–103 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveRoute.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 135 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/LmrsFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 880 |
org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 550–566 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 54–55 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 93 |
| UselessParentheses | Useless parentheses. | 4 | 97–98 |
| UselessParentheses | Useless parentheses. | 4 | 138–139 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Desire.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'get': the method is already in a final class | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'leftIsLargerOrEqual': the method is already in a final class | 3 | 69 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 111 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 181–197 |
| UnusedPrivateMethod | Avoid unused private methods such as 'quickIntersectionScan(Parameters, SpeedLimitInfo, CarFollowingModel, Speed, LateralDirectionality, IntersectionPerception)'. | 3 | 576 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 339–340 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 356–357 |
org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalRoutePlanner.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 165 |
org/opentrafficsim/road/gtu/strategical/RouteGenerator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 116–119 |
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 161 |
org/opentrafficsim/road/network/RoadNetwork.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 335 |
org/opentrafficsim/road/network/factory/LaneFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'simulator'. | 3 | 126 |
| UnusedFormalParameter | Avoid unused method parameters such as 'simulator'. | 3 | 408 |
org/opentrafficsim/road/network/lane/Lane.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 267 |
| UselessParentheses | Useless parentheses. | 4 | 269 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 286–290 |
| UselessParentheses | Useless parentheses. | 4 | 307 |
| UselessParentheses | Useless parentheses. | 4 | 309 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 326–330 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 370 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 381 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 520 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 530 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 682 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 718 |
| UselessParentheses | Useless parentheses. | 4 | 958 |
| UselessParentheses | Useless parentheses. | 4 | 1026 |
org/opentrafficsim/road/network/lane/conflict/Conflict.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 446–479 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 622–640 |
org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 272–275 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1075–1078 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1097–1100 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1110–1113 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1167–1170 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1188–1191 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1201–1204 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordSmall': records are implicitly static | 3 | 1317 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordBig': records are implicitly static | 3 | 1430 |
org/opentrafficsim/road/network/lane/conflict/ConflictPriority.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPriority': the method is already in a final class | 3 | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGiveWay': the method is already in a final class | 3 | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isStop': the method is already in a final class | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isAllStop': the method is already in a final class | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class | 3 | 71 |
org/opentrafficsim/road/network/lane/object/AbstractLaneBasedObject.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 74 |
org/opentrafficsim/road/network/lane/object/BusStop.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'name'. | 3 | 38 |
org/opentrafficsim/road/network/lane/object/detector/LaneDetector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DEFAULT_DETECTOR_ELEVATION' is already in scope because it is declared in an enclosing type | 4 | 100 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DETECTOR_TRIGGER_EVENT' is already in scope because it is declared in an enclosing type | 4 | 135 |
org/opentrafficsim/road/network/lane/object/detector/TrafficLightDetector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_ENTRY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 197 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 4 | 215 |
org/opentrafficsim/road/network/lane/object/trafficlight/TrafficLightColor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRedOrYellow': the method is already in a final class | 3 | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRed': the method is already in a final class | 3 | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isYellow': the method is already in a final class | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGreen': the method is already in a final class | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPreGreen': the method is already in a final class | 3 | 71 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isBlack': the method is already in a final class | 3 | 80 |
org/opentrafficsim/road/network/speed/SpeedInfoCurvature.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getSpeedForLateralAcceleration': the method is already in a final class | 3 | 38 |
org/opentrafficsim/road/od/OdApplier.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 337 |
| UselessParentheses | Useless parentheses. | 4 | 342 |
org/opentrafficsim/road/od/SplitFraction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 176 |