PMD Results
The following document contains the results of PMD 7.7.0.
Violations By Priority
Priority 2
org/opentrafficsim/road/gtu/perception/categories/DirectInfrastructurePerception.java
| Rule | Violation | Line |
|---|---|---|
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 331–332 |
Priority 3
org/opentrafficsim/road/gtu/LaneBasedGtu.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 1371 |
org/opentrafficsim/road/gtu/operational/LaneOperationalPlanBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessarySemicolon | Unnecessary semicolon | 727 |
org/opentrafficsim/road/gtu/perception/AbstractPerceptionReiterable.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 122 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 124 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 125 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 129 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 130 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 309–312 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 320 |
org/opentrafficsim/road/gtu/perception/categories/DirectIntersectionPerception.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 119 |
org/opentrafficsim/road/gtu/perception/categories/neighbors/CaccPerception.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 89 |
org/opentrafficsim/road/gtu/perception/categories/neighbors/DirectNeighborsPerception.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 177 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 203 |
org/opentrafficsim/road/gtu/perception/mental/ar/ArTaskLaneChanging.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'perception'. | 93 |
| UnusedFormalParameter | Avoid unused method parameters such as 'parameters'. | 93 |
org/opentrafficsim/road/gtu/perception/mental/channel/ChannelTaskAcceleration.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 99–102 |
org/opentrafficsim/road/gtu/perception/mental/channel/ChannelTaskCooperation.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 92–95 |
org/opentrafficsim/road/gtu/perception/mental/channel/IntersectionPerceptionChannel.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 120 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 140 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 141 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 142 |
org/opentrafficsim/road/gtu/perception/object/PerceivedGtu.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessarySemicolon | Unnecessary semicolon | 203 |
| UnnecessarySemicolon | Unnecessary semicolon | 326 |
org/opentrafficsim/road/gtu/perception/structure/LaneStructure.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 90 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 97 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 136 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 185 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 186 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 187 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 255 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 256 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 314 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 315 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 350 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 351 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 407 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 428 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 450 |
org/opentrafficsim/road/gtu/perception/structure/NavigatingIterable.java
| Rule | Violation | Line |
|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 86 |
org/opentrafficsim/road/gtu/strategical/RouteGenerator.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 117–120 |
| UnnecessarySemicolon | Unnecessary semicolon | 166 |
org/opentrafficsim/road/gtu/tactical/lmrs/AccelerationBusStop.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 85–94 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Cooperation.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 91 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Desire.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'get': the method is already in a final class | 52 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'leftIsLargerOrEqual': the method is already in a final class | 69 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/LmrsData.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 115 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/LmrsUtil.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 167–183 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Synchronization.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 274 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 290 |
org/opentrafficsim/road/network/Lane.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 282–286 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 322–326 |
org/opentrafficsim/road/network/conflict/Conflict.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 454–487 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 683–701 |
org/opentrafficsim/road/network/conflict/ConflictBuilder.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 272–275 |
| EmptyCatchBlock | Avoid empty catch blocks | 1076–1079 |
| EmptyCatchBlock | Avoid empty catch blocks | 1098–1101 |
| EmptyCatchBlock | Avoid empty catch blocks | 1111–1114 |
| EmptyCatchBlock | Avoid empty catch blocks | 1168–1171 |
| EmptyCatchBlock | Avoid empty catch blocks | 1189–1192 |
| EmptyCatchBlock | Avoid empty catch blocks | 1202–1205 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordSmall': records are implicitly static | 1317 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordBig': records are implicitly static | 1430 |
org/opentrafficsim/road/network/conflict/ConflictPriority.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPriority': the method is already in a final class | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGiveWay': the method is already in a final class | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isStop': the method is already in a final class | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isAllStop': the method is already in a final class | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class | 71 |
org/opentrafficsim/road/network/factory/LaneFactory.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'simulator'. | 117 |
| UnusedFormalParameter | Avoid unused method parameters such as 'simulator'. | 389 |
org/opentrafficsim/road/network/object/BusStop.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'name'. | 38 |
org/opentrafficsim/road/network/object/trafficlight/TrafficLightColor.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRedOrYellow': the method is already in a final class | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRed': the method is already in a final class | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isYellow': the method is already in a final class | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGreen': the method is already in a final class | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPreGreen': the method is already in a final class | 71 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isBlack': the method is already in a final class | 80 |
Priority 4
org/opentrafficsim/road/gtu/LaneBasedGtu.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 290 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_ENTER_EVENT' is already in scope because it is declared in an enclosing type | 317 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 327 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 335 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 629 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_MOVE_EVENT' is already in scope because it is declared in an enclosing type | 673 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 1460 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 1468 |
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 768 |
| UselessParentheses | Useless parentheses. | 951 |
org/opentrafficsim/road/gtu/operational/LaneOperationalPlanBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 607 |
org/opentrafficsim/road/gtu/perception/categories/WienerProcess.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 83 |
org/opentrafficsim/road/gtu/perception/categories/neighbors/Estimation.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 74 |
org/opentrafficsim/road/gtu/perception/categories/neighbors/TaskHeadwayCollector.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 76 |
org/opentrafficsim/road/gtu/perception/mental/AdaptationSituationalAwareness.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 88 |
org/opentrafficsim/road/gtu/perception/mental/AdaptationSpeed.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 53 |
org/opentrafficsim/road/gtu/perception/mental/ar/ArTaskHeadwayBased.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 51 |
org/opentrafficsim/road/gtu/perception/mental/channel/ChannelTaskLaneChange.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 67 |
org/opentrafficsim/road/gtu/perception/mental/channel/ChannelTaskRoadSideDistraction.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 69 |
org/opentrafficsim/road/gtu/perception/mental/channel/NeighborsPerceptionChannel.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 207 |
| UselessParentheses | Useless parentheses. | 236 |
org/opentrafficsim/road/gtu/perception/object/PerceivedGtu.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 246 |
org/opentrafficsim/road/gtu/perception/structure/LaneStructure.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 603–604 |
org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalRoutePlanner.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 165 |
org/opentrafficsim/road/gtu/tactical/lmrs/IncentiveRoute.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 139 |
org/opentrafficsim/road/gtu/tactical/lmrs/LmrsFactory.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 973 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Synchronization.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'gentleUrgency' is already in scope | 79 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getMergeDistance' is already in scope | 83 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'gentleUrgency' is already in scope | 134 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getMergeDistance' is already in scope | 138 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getMergeDistance' is already in scope | 205 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'tagAlongAcceleration' is already in scope | 245 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getFollower' is already in scope | 273 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'tagAlongAcceleration' is already in scope | 274 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'canBeAhead' is already in scope | 277 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getFollower' is already in scope | 289 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'tagAlongAcceleration' is already in scope | 290 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'gentleUrgency' is already in scope | 298 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'tagAlongAcceleration' is already in scope | 298 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'canBeAhead' is already in scope | 304 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'requiredBufferSpace' is already in scope | 308 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'stopForEnd' is already in scope | 316 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'gentleUrgency' is already in scope | 320 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'stopForEnd' is already in scope | 325 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'requiredBufferSpace' is already in scope | 329 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'requiredBufferSpace' is already in scope | 355 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'requiredBufferSpace' is already in scope | 539 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Tailgating.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'deviate' is already in scope | 72 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'socialPressure' is already in scope | 79 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'deviate' is already in scope | 81 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'deviate' is already in scope | 111 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'socialPressure' is already in scope | 121 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'deviate' is already in scope | 128 |
org/opentrafficsim/road/network/Lane.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 263 |
| UselessParentheses | Useless parentheses. | 265 |
| UselessParentheses | Useless parentheses. | 303 |
| UselessParentheses | Useless parentheses. | 305 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_ADD_EVENT' is already in scope because it is declared in an enclosing type | 366 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 377 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 515 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 525 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 677 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 713 |
| UselessParentheses | Useless parentheses. | 950 |
| UselessParentheses | Useless parentheses. | 1018 |
org/opentrafficsim/road/network/RoadNetwork.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 333 |
org/opentrafficsim/road/network/conflict/ConflictBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'ch.qos.logback.classic.Level' | 33 |
org/opentrafficsim/road/network/object/AbstractLaneBasedObject.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 74 |
org/opentrafficsim/road/network/object/detector/LaneDetector.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DEFAULT_DETECTOR_ELEVATION' is already in scope because it is declared in an enclosing type | 100 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DETECTOR_TRIGGER_EVENT' is already in scope because it is declared in an enclosing type | 135 |
org/opentrafficsim/road/network/object/detector/TrafficLightDetector.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_ENTRY_EVENT' is already in scope because it is declared in an enclosing type | 197 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 215 |
org/opentrafficsim/road/od/OdApplier.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 337 |
| UselessParentheses | Useless parentheses. | 342 |
org/opentrafficsim/road/od/SplitFraction.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 176 |
Files
org/opentrafficsim/road/gtu/LaneBasedGtu.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 4 | 290 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_ENTER_EVENT' is already in scope because it is declared in an enclosing type | 4 | 317 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 4 | 327 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 335 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANE_CHANGE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 629 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_MOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 673 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 1371 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 1460 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneBasedGtu': 'LANEBASED_DESTROY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 1468 |
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 768 |
| UselessParentheses | Useless parentheses. | 4 | 951 |
org/opentrafficsim/road/gtu/operational/LaneOperationalPlanBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 607 |
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 727 |
org/opentrafficsim/road/gtu/perception/AbstractPerceptionReiterable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 122 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 124 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 125 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 129 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 130 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 309–312 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 320 |
org/opentrafficsim/road/gtu/perception/categories/DirectInfrastructurePerception.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 2 | 331–332 |
org/opentrafficsim/road/gtu/perception/categories/DirectIntersectionPerception.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 119 |
org/opentrafficsim/road/gtu/perception/categories/WienerProcess.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 83 |
org/opentrafficsim/road/gtu/perception/categories/neighbors/CaccPerception.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 89 |
org/opentrafficsim/road/gtu/perception/categories/neighbors/DirectNeighborsPerception.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 177 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 203 |
org/opentrafficsim/road/gtu/perception/categories/neighbors/Estimation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 74 |
org/opentrafficsim/road/gtu/perception/categories/neighbors/TaskHeadwayCollector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 76 |
org/opentrafficsim/road/gtu/perception/mental/AdaptationSituationalAwareness.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 88 |
org/opentrafficsim/road/gtu/perception/mental/AdaptationSpeed.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 53 |
org/opentrafficsim/road/gtu/perception/mental/ar/ArTaskHeadwayBased.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 51 |
org/opentrafficsim/road/gtu/perception/mental/ar/ArTaskLaneChanging.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'perception'. | 3 | 93 |
| UnusedFormalParameter | Avoid unused method parameters such as 'parameters'. | 3 | 93 |
org/opentrafficsim/road/gtu/perception/mental/channel/ChannelTaskAcceleration.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 99–102 |
org/opentrafficsim/road/gtu/perception/mental/channel/ChannelTaskCooperation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 92–95 |
org/opentrafficsim/road/gtu/perception/mental/channel/ChannelTaskLaneChange.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 67 |
org/opentrafficsim/road/gtu/perception/mental/channel/ChannelTaskRoadSideDistraction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 69 |
org/opentrafficsim/road/gtu/perception/mental/channel/IntersectionPerceptionChannel.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 120 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 140 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 141 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 142 |
org/opentrafficsim/road/gtu/perception/mental/channel/NeighborsPerceptionChannel.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 207 |
| UselessParentheses | Useless parentheses. | 4 | 236 |
org/opentrafficsim/road/gtu/perception/object/PerceivedGtu.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 203 |
| UselessParentheses | Useless parentheses. | 4 | 246 |
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 326 |
org/opentrafficsim/road/gtu/perception/structure/LaneStructure.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 90 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 97 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 136 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 185 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 186 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 187 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 255 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 256 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 314 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 315 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 350 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 351 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 407 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 428 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 450 |
| UselessParentheses | Useless parentheses. | 4 | 603–604 |
org/opentrafficsim/road/gtu/perception/structure/NavigatingIterable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 85 |
| UselessQualifiedThis | Useless qualified this usage in the same class. | 3 | 86 |
org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalRoutePlanner.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 165 |
org/opentrafficsim/road/gtu/strategical/RouteGenerator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 117–120 |
| UnnecessarySemicolon | Unnecessary semicolon | 3 | 166 |
org/opentrafficsim/road/gtu/tactical/lmrs/AccelerationBusStop.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 85–94 |
org/opentrafficsim/road/gtu/tactical/lmrs/IncentiveRoute.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 139 |
org/opentrafficsim/road/gtu/tactical/lmrs/LmrsFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 973 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Cooperation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 91 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Desire.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'get': the method is already in a final class | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'leftIsLargerOrEqual': the method is already in a final class | 3 | 69 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/LmrsData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 115 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/LmrsUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 167–183 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Synchronization.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'gentleUrgency' is already in scope | 4 | 79 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getMergeDistance' is already in scope | 4 | 83 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'gentleUrgency' is already in scope | 4 | 134 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getMergeDistance' is already in scope | 4 | 138 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getMergeDistance' is already in scope | 4 | 205 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'tagAlongAcceleration' is already in scope | 4 | 245 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getFollower' is already in scope | 4 | 273 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 274 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'tagAlongAcceleration' is already in scope | 4 | 274 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'canBeAhead' is already in scope | 4 | 277 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'getFollower' is already in scope | 4 | 289 |
| SimplifiedTernary | This conditional expression can be simplified with || or && | 3 | 290 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'tagAlongAcceleration' is already in scope | 4 | 290 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'gentleUrgency' is already in scope | 4 | 298 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'tagAlongAcceleration' is already in scope | 4 | 298 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'canBeAhead' is already in scope | 4 | 304 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'requiredBufferSpace' is already in scope | 4 | 308 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'stopForEnd' is already in scope | 4 | 316 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'gentleUrgency' is already in scope | 4 | 320 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'stopForEnd' is already in scope | 4 | 325 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'requiredBufferSpace' is already in scope | 4 | 329 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'requiredBufferSpace' is already in scope | 4 | 355 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Synchronization': 'requiredBufferSpace' is already in scope | 4 | 539 |
org/opentrafficsim/road/gtu/tactical/util/lmrs/Tailgating.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'deviate' is already in scope | 4 | 72 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'socialPressure' is already in scope | 4 | 79 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'deviate' is already in scope | 4 | 81 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'deviate' is already in scope | 4 | 111 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'socialPressure' is already in scope | 4 | 121 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Tailgating': 'deviate' is already in scope | 4 | 128 |
org/opentrafficsim/road/network/Lane.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 263 |
| UselessParentheses | Useless parentheses. | 4 | 265 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 282–286 |
| UselessParentheses | Useless parentheses. | 4 | 303 |
| UselessParentheses | Useless parentheses. | 4 | 305 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 322–326 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 366 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'DETECTOR_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 377 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 515 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'OBJECT_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 525 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_ADD_EVENT' is already in scope because it is declared in an enclosing type | 4 | 677 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Lane': 'GTU_REMOVE_EVENT' is already in scope because it is declared in an enclosing type | 4 | 713 |
| UselessParentheses | Useless parentheses. | 4 | 950 |
| UselessParentheses | Useless parentheses. | 4 | 1018 |
org/opentrafficsim/road/network/RoadNetwork.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 333 |
org/opentrafficsim/road/network/conflict/Conflict.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 454–487 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 683–701 |
org/opentrafficsim/road/network/conflict/ConflictBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'ch.qos.logback.classic.Level' | 4 | 33 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 272–275 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1076–1079 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1098–1101 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1111–1114 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1168–1171 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1189–1192 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 1202–1205 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordSmall': records are implicitly static | 3 | 1317 |
| UnnecessaryModifier | Unnecessary modifier 'static' on record 'ConflictBuilderRecordBig': records are implicitly static | 3 | 1430 |
org/opentrafficsim/road/network/conflict/ConflictPriority.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPriority': the method is already in a final class | 3 | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGiveWay': the method is already in a final class | 3 | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isStop': the method is already in a final class | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isAllStop': the method is already in a final class | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isSplit': the method is already in a final class | 3 | 71 |
org/opentrafficsim/road/network/factory/LaneFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'simulator'. | 3 | 117 |
| UnusedFormalParameter | Avoid unused method parameters such as 'simulator'. | 3 | 389 |
org/opentrafficsim/road/network/object/AbstractLaneBasedObject.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 74 |
org/opentrafficsim/road/network/object/BusStop.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'name'. | 3 | 38 |
org/opentrafficsim/road/network/object/detector/LaneDetector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DEFAULT_DETECTOR_ELEVATION' is already in scope because it is declared in an enclosing type | 4 | 100 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LaneDetector': 'DETECTOR_TRIGGER_EVENT' is already in scope because it is declared in an enclosing type | 4 | 135 |
org/opentrafficsim/road/network/object/detector/TrafficLightDetector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_ENTRY_EVENT' is already in scope because it is declared in an enclosing type | 4 | 197 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficLightDetector': 'TRAFFIC_LIGHT_DETECTOR_TRIGGER_EXIT_EVENT' is already in scope because it is declared in an enclosing type | 4 | 215 |
org/opentrafficsim/road/network/object/trafficlight/TrafficLightColor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRedOrYellow': the method is already in a final class | 3 | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isRed': the method is already in a final class | 3 | 44 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isYellow': the method is already in a final class | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isGreen': the method is already in a final class | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isPreGreen': the method is already in a final class | 3 | 71 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isBlack': the method is already in a final class | 3 | 80 |
org/opentrafficsim/road/od/OdApplier.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 337 |
| UselessParentheses | Useless parentheses. | 4 | 342 |
org/opentrafficsim/road/od/SplitFraction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 176 |