Checkstyle Results
The following document contains the results of Checkstyle 10.17.0 with /config/dsol-checks.xml ruleset.
Summary
| Files |  Info |
 Warnings |
 Errors |
|---|---|---|---|
| 337 | 39 | 70 | 0 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| coding | HiddenField
|
5 | Warning |
| InnerAssignment | 2 | Warning | |
| design | HideUtilityClassConstructor | 2 | Warning |
| VisibilityModifier | 9 | Warning | |
| imports | UnusedImports | 3 | Warning |
| javadoc | JavadocMethod | 1 | Warning |
| JavadocPackage | 1 | Info | |
| misc | TodoComment | 36 | Warning |
| modifier | RedundantModifier | 7 | Warning |
| naming | StaticVariableName | 5 | Warning |
| sizes | LineLength
|
2 | Info |
| MethodLength | 6 | Info | |
| ParameterNumber | 30 | Info |
Details
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 855 |
org/opentrafficsim/road/gtu/generator/GtuSpawner.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | HiddenField | 'useDefaultGtuTemplate' hides a field. | 52 |
| Warning |
coding | HiddenField | 'stream' hides a field. | 63 |
| Warning |
coding | HiddenField | 'noLaneChangeDistance' hides a field. | 74 |
| Warning |
coding | HiddenField | 'instantaneousLaneChanges' hides a field. | 85 |
| Warning |
coding | HiddenField | 'errorHandler' hides a field. | 96 |
org/opentrafficsim/road/gtu/generator/Platoons.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 309 |
org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'eventMargin' must be private and have accessor methods. | 148 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 154 |
| Warning |
design | VisibilityModifier | Variable 'CACHING' must be private and have accessor methods. | 155 |
| Warning |
naming | StaticVariableName | Name 'CACHING' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 155 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 158 |
| Warning |
design | VisibilityModifier | Variable 'CACHED_POSITION' must be private and have accessor methods. | 159 |
| Warning |
naming | StaticVariableName | Name 'CACHED_POSITION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 159 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 162 |
| Warning |
design | VisibilityModifier | Variable 'NON_CACHED_POSITION' must be private and have accessor methods. | 163 |
| Warning |
naming | StaticVariableName | Name 'NON_CACHED_POSITION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 163 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 210 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 313 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 357 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 377 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1397 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1398 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1752 |
org/opentrafficsim/road/gtu/lane/control/DelayedActuation.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 43 |
org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
javadoc | JavadocMethod | @return tag should be present and have description. | 959 |
org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 158 |
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opentrafficsim.base.geometry.OtsLocatable. | 7 |
| Warning |
imports | UnusedImports | Unused import - org.opentrafficsim.road.network.lane.conflict.Conflict. | 16 |
org/opentrafficsim/road/gtu/lane/perception/headway/AbstractHeadwayGtu.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 103 |
org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayGtuSimple.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 54 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 115 |
org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayGtuType.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 123 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 20 |
org/opentrafficsim/road/gtu/lane/perception/mental/TaskManager.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 21 |
org/opentrafficsim/road/gtu/lane/perception/mental/sdm/Distraction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 59 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'MIN_LC_LENGTH_FACTOR' must be private and have accessor methods. | 78 |
| Warning |
naming | StaticVariableName | Name 'MIN_LC_LENGTH_FACTOR' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 78 |
| Info |
sizes | MethodLength | Method getPath length is 226 lines (max allowed is 150). | 224 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 388 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 599 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 658 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 11). | 687 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 706 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 744 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 834 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 47 |
org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCfLcTacticalPlanner.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 210 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 350 |
| Info |
sizes | MethodLength | Method suitability length is 163 lines (max allowed is 150). | 413 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 624 |
org/opentrafficsim/road/gtu/lane/tactical/directedlanechange/AbstractDirectedLaneChangeModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opentrafficsim.core.gtu.plan.operational.OperationalPlanException. | 15 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 55 |
org/opentrafficsim/road/gtu/lane/tactical/lanechangemobil/LaneChangeModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 12 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationConflicts.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 44 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationIncentive.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 47 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationNoRightOvertake.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 44 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationSpeedLimitTransition.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 31 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationTrafficLights.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 32 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveQueue.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 61 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveSpeed.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 31 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveStayRight.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | InnerAssignment | Inner assignments should be avoided. | 47 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/Lmrs.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 125 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/LmrsFactory.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 95 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 112 |
org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | MethodLength | Method generateOperationalPlan length is 173 lines (max allowed is 150). | 93 |
| Info |
sizes | MethodLength | Method getGapInfo length is 165 lines (max allowed is 150). | 280 |
org/opentrafficsim/road/gtu/lane/tactical/toledo/ToledoCfTester.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 29 |
org/opentrafficsim/road/gtu/lane/tactical/util/AnticipationInfo.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'final' modifier. | 28 |
org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
naming | StaticVariableName | Name 'CROSSSTANDING' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 108 |
| Info |
sizes | MethodLength | Method approachConflicts length is 185 lines (max allowed is 150). | 139 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 190 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 541 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 99 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/GapAcceptance.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 34 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 88 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 175 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 450 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 518 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 48 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 103 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 186 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 238 |
| Info |
sizes | MethodLength | Method synchronize length is 185 lines (max allowed is 150). | 264 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 265 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 469 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 498 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 14). | 630 |
org/opentrafficsim/road/network/LaneAccessLaw.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
org/opentrafficsim/road/network/RoadNetwork.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 174 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 355 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 524 |
org/opentrafficsim/road/network/factory/LaneFactory.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 124 |
org/opentrafficsim/road/network/factory/RoadNetworkUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 22 |
org/opentrafficsim/road/network/lane/Lane.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | InnerAssignment | Inner assignments should be avoided. | 916 |
org/opentrafficsim/road/network/lane/LaneGeometryUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 82 |
org/opentrafficsim/road/network/lane/changing/OvertakingConditions.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 266 |
org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 275 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 500 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 607 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1241 |
| Warning |
design | VisibilityModifier | Variable 'cbr' must be private and have accessor methods. | 1262 |
| Warning |
design | VisibilityModifier | Variable 'nrOfJobs' must be private and have accessor methods. | 1265 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 1318 |
| Warning |
design | VisibilityModifier | Variable 'cbr' must be private and have accessor methods. | 1339 |
| Warning |
design | VisibilityModifier | Variable 'nrOfJobs' must be private and have accessor methods. | 1342 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 1432 |
org/opentrafficsim/road/od/Category.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 130). | 114 |
org/opentrafficsim/road/od/OdApplier.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 910 |