Checkstyle Results
The following document contains the results of Checkstyle 10.17.0 with /config/dsol-checks.xml ruleset.
Summary
| Files |  Info |
 Warnings |
 Errors |
|---|---|---|---|
| 341 | 43 | 98 | 0 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| coding | HiddenField
|
8 | Warning |
| InnerAssignment | 2 | Warning | |
| design | FinalClass | 1 | Warning |
| HideUtilityClassConstructor | 2 | Warning | |
| VisibilityModifier | 18 | Warning | |
| imports | UnusedImports | 2 | Warning |
| javadoc | JavadocPackage | 1 | Info |
| JavadocStyle | 1 | Warning | |
| misc | TodoComment | 37 | Warning |
| modifier | RedundantModifier | 15 | Warning |
| naming | StaticVariableName | 12 | Warning |
| sizes | LineLength
|
2 | Info |
| MethodLength | 7 | Info | |
| ParameterNumber | 33 | Info |
Details
org/opentrafficsim/road/gtu/generator/GeneratorPositions.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 868 |
org/opentrafficsim/road/gtu/generator/GtuSpawner.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | HiddenField | 'useDefaultGtuTemplate' hides a field. | 53 |
| Warning |
coding | HiddenField | 'stream' hides a field. | 64 |
| Warning |
coding | HiddenField | 'noLaneChangeDistance' hides a field. | 75 |
| Warning |
coding | HiddenField | 'instantaneousLaneChanges' hides a field. | 86 |
| Warning |
coding | HiddenField | 'errorHandler' hides a field. | 97 |
org/opentrafficsim/road/gtu/generator/Platoons.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.util.Set. | 7 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 313 |
org/opentrafficsim/road/gtu/lane/LaneBasedGtu.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'eventMargin' must be private and have accessor methods. | 147 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 153 |
| Warning |
design | VisibilityModifier | Variable 'CACHING' must be private and have accessor methods. | 154 |
| Warning |
naming | StaticVariableName | Name 'CACHING' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 154 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 157 |
| Warning |
design | VisibilityModifier | Variable 'CACHED_POSITION' must be private and have accessor methods. | 158 |
| Warning |
naming | StaticVariableName | Name 'CACHED_POSITION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 158 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 161 |
| Warning |
design | VisibilityModifier | Variable 'NON_CACHED_POSITION' must be private and have accessor methods. | 162 |
| Warning |
naming | StaticVariableName | Name 'NON_CACHED_POSITION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 162 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 210 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 314 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 358 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 378 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1403 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1404 |
| Warning |
design | VisibilityModifier | Variable 'LANEBASED_MOVE_EVENT' must be private and have accessor methods. | 1725 |
| Warning |
naming | StaticVariableName | Name 'LANEBASED_MOVE_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1725 |
| Warning |
design | VisibilityModifier | Variable 'LANEBASED_DESTROY_EVENT' must be private and have accessor methods. | 1743 |
| Warning |
naming | StaticVariableName | Name 'LANEBASED_DESTROY_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1743 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1753 |
| Warning |
design | VisibilityModifier | Variable 'LANE_ENTER_EVENT' must be private and have accessor methods. | 1759 |
| Warning |
naming | StaticVariableName | Name 'LANE_ENTER_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1759 |
| Warning |
design | VisibilityModifier | Variable 'LANE_EXIT_EVENT' must be private and have accessor methods. | 1770 |
| Warning |
naming | StaticVariableName | Name 'LANE_EXIT_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1770 |
| Warning |
design | VisibilityModifier | Variable 'LANE_CHANGE_EVENT' must be private and have accessor methods. | 1780 |
| Warning |
naming | StaticVariableName | Name 'LANE_CHANGE_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1780 |
org/opentrafficsim/road/gtu/lane/control/DelayedActuation.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 45 |
org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 78 |
org/opentrafficsim/road/gtu/lane/perception/LaneBasedObjectIterable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 48 |
org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 74 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 108 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 133 |
| Warning |
design | VisibilityModifier | Variable 'object' must be private and have accessor methods. | 243 |
| Warning |
design | VisibilityModifier | Variable 'distance' must be private and have accessor methods. | 246 |
org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectableFiltered.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 167 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 172 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 205 |
org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'PERCEPTION' must be private and have accessor methods. | 51 |
| Warning |
naming | StaticVariableName | Name 'PERCEPTION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 51 |
| Warning |
design | VisibilityModifier | Variable 'LOOKAHEAD' must be private and have accessor methods. | 54 |
| Warning |
naming | StaticVariableName | Name 'LOOKAHEAD' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 54 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 179 |
org/opentrafficsim/road/gtu/lane/perception/headway/AbstractHeadwayGtu.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 103 |
org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayGtuSimple.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 54 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 115 |
org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayGtuType.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 123 |
org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 131). | 20 |
org/opentrafficsim/road/gtu/lane/perception/mental/TaskManager.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 21 |
org/opentrafficsim/road/gtu/lane/perception/mental/sdm/Distraction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 59 |
org/opentrafficsim/road/gtu/lane/perception/structure/LaneRecord.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | HiddenField | 'lateral' hides a field. | 149 |
org/opentrafficsim/road/gtu/lane/perception/structure/LaneStructure.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | HiddenField | 'gtu' hides a field. | 342 |
| Warning |
modifier | RedundantModifier | Redundant 'final' modifier. | 415 |
| Warning |
coding | HiddenField | 'gtu' hides a field. | 415 |
| Info |
sizes | MethodLength | Method update length is 197 lines (max allowed is 150). | 428 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 717 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 752 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 772 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 906 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'MIN_LC_LENGTH_FACTOR' must be private and have accessor methods. | 76 |
| Warning |
naming | StaticVariableName | Name 'MIN_LC_LENGTH_FACTOR' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 76 |
| Info |
sizes | MethodLength | Method getPath length is 200 lines (max allowed is 150). | 223 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 370 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 579 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 643 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 11). | 673 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 693 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 732 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 823 |
org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 50 |
org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCfLcTacticalPlanner.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 212 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 356 |
| Info |
sizes | MethodLength | Method suitability length is 163 lines (max allowed is 150). | 420 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 631 |
org/opentrafficsim/road/gtu/lane/tactical/directedlanechange/AbstractDirectedLaneChangeModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 56 |
org/opentrafficsim/road/gtu/lane/tactical/lanechangemobil/LaneChangeModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 13 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationConflicts.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 46 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationIncentive.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 49 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationNoRightOvertake.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 46 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationSpeedLimitTransition.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 32 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationTrafficLights.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 33 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveQueue.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 62 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveSpeed.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 32 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveStayRight.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | InnerAssignment | Inner assignments should be avoided. | 48 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/Lmrs.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 127 |
org/opentrafficsim/road/gtu/lane/tactical/lmrs/LmrsFactory.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 94 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 109 |
org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | MethodLength | Method generateOperationalPlan length is 187 lines (max allowed is 150). | 95 |
| Info |
sizes | MethodLength | Method getGapInfo length is 165 lines (max allowed is 150). | 296 |
org/opentrafficsim/road/gtu/lane/tactical/toledo/ToledoCfTester.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 29 |
org/opentrafficsim/road/gtu/lane/tactical/util/AnticipationInfo.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'final' modifier. | 28 |
org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
naming | StaticVariableName | Name 'CROSSSTANDING' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 108 |
| Info |
sizes | MethodLength | Method approachConflicts length is 185 lines (max allowed is 150). | 139 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 190 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 541 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 102 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/GapAcceptance.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 35 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 91 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 179 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 452 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 520 |
org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 49 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 106 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 187 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 241 |
| Info |
sizes | MethodLength | Method synchronize length is 185 lines (max allowed is 150). | 269 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 270 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 475 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 504 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 14). | 636 |
org/opentrafficsim/road/network/LaneAccessLaw.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
org/opentrafficsim/road/network/RoadNetwork.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 176 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 357 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 526 |
org/opentrafficsim/road/network/factory/LaneFactory.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 123 |
org/opentrafficsim/road/network/lane/Lane.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | InnerAssignment | Inner assignments should be avoided. | 933 |
org/opentrafficsim/road/network/lane/LaneGeometryUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | FinalClass | Class LaneGeometryUtil should be declared as final. | 32 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 167 |
org/opentrafficsim/road/network/lane/changing/OvertakingConditions.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 277 |
org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 284 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 510 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 620 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 1274 |
| Warning |
design | VisibilityModifier | Variable 'cbr' must be private and have accessor methods. | 1295 |
| Warning |
design | VisibilityModifier | Variable 'nrOfJobs' must be private and have accessor methods. | 1298 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 1352 |
| Warning |
design | VisibilityModifier | Variable 'cbr' must be private and have accessor methods. | 1373 |
| Warning |
design | VisibilityModifier | Variable 'nrOfJobs' must be private and have accessor methods. | 1376 |
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 1467 |
org/opentrafficsim/road/network/lane/object/detector/LaneDetector.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.rmi.RemoteException. | 3 |
org/opentrafficsim/road/network/lane/object/detector/LoopDetector.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | ParameterNumber | More than 7 parameters (found 9). | 393 |
org/opentrafficsim/road/od/Category.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 130). | 114 |
org/opentrafficsim/road/od/OdApplier.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'static' modifier. | 928 |