PMD Results

The following document contains the results of PMD 6.4.0.

Files

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Violation Priority Line
Useless parentheses. 4 289
Useless parentheses. 4 289
Useless parentheses. 4 290
Useless parentheses. 4 290
These nested if statements could be combined 3 358–378
These nested if statements could be combined 3 418–438

org/opentrafficsim/road/gtu/generator/CFRoomChecker.java

Violation Priority Line
Avoid empty catch blocks 3 54–57

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Violation Priority Line
Avoid empty catch blocks 3 295–298
Useless parentheses. 4 917
Avoid modifiers which are implied by the context 3 1023–1083
Avoid modifiers which are implied by the context 3 1097–1182
Useless parentheses. 4 1126

org/opentrafficsim/road/gtu/generator/od/ODApplier.java

Violation Priority Line
Useless parentheses. 4 300

org/opentrafficsim/road/gtu/generator/od/StrategicalPlannerFactorySupplierOD.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 106–118

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Violation Priority Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 1393
Avoid empty catch blocks 3 1490–1493
Avoid empty catch blocks 3 1506–1509

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedIndividualGTU.java

Violation Priority Line
Ternary operators that can be simplified with || or && 3 96

org/opentrafficsim/road/gtu/lane/VehicleModel.java

Violation Priority Line
Useless parentheses. 4 44

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Violation Priority Line
Useless qualified this usage in the same class. 3 125
Useless qualified this usage in the same class. 3 127
Useless qualified this usage in the same class. 3 128
Useless qualified this usage in the same class. 3 132
Useless qualified this usage in the same class. 3 133
Useless qualified this usage in the same class. 3 281

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Violation Priority Line
Useless parentheses. 4 99
These nested if statements could be combined 3 117–121

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 70–89
Avoid modifiers which are implied by the context 3 105–115
Avoid modifiers which are implied by the context 3 131–139

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructure.java

Violation Priority Line
Useless parentheses. 4 458
Useless parentheses. 4 1269
Useless parentheses. 4 1270
Useless parentheses. 4 1357
Useless parentheses. 4 1358
Useless parentheses. 4 1441
Useless parentheses. 4 1442
Useless parentheses. 4 1471
Useless parentheses. 4 1472

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Violation Priority Line
Useless parentheses. 4 341–342
These nested if statements could be combined 3 341–347
Useless parentheses. 4 343–344

org/opentrafficsim/road/gtu/lane/perception/UpstreamNeighborsIterable.java

Violation Priority Line
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.Break' 4 7
Useless parentheses. 4 76

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Violation Priority Line
These nested if statements could be combined 3 749–752
These nested if statements could be combined 3 883–900
Useless parentheses. 4 952
Useless parentheses. 4 952
Useless parentheses. 4 953
Useless parentheses. 4 953

org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java

Violation Priority Line
Useless parentheses. 4 412
Useless parentheses. 4 412
Useless parentheses. 4 427
Useless parentheses. 4 427
Useless parentheses. 4 440
Useless parentheses. 4 440
Useless parentheses. 4 444
Useless parentheses. 4 444
Useless parentheses. 4 455
Useless parentheses. 4 455
Useless parentheses. 4 654
Useless parentheses. 4 655

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Violation Priority Line
Avoid unused method parameters such as 'context'. 3 126

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Violation Priority Line
Useless parentheses. 4 258–259
Useless parentheses. 4 260–261

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java

Violation Priority Line
Useless parentheses. 4 211

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Violation Priority Line
Useless parentheses. 4 81

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Violation Priority Line
Overriding method merely calls super 3 35–38

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Violation Priority Line
Useless parentheses. 4 46

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Violation Priority Line
Useless parentheses. 4 88

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Violation Priority Line
Useless parentheses. 4 41

org/opentrafficsim/road/gtu/lane/perception/mental/Fuller.java

Violation Priority Line
Useless parentheses. 4 180

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Violation Priority Line
Useless parentheses. 4 56

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Violation Priority Line
Useless parentheses. 4 380

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Violation Priority Line
Useless parentheses. 4 397
Avoid unused method parameters such as 'gtu'. 3 434
Avoid unused method parameters such as 'startSpeed'. 3 470
Useless parentheses. 4 527
Useless parentheses. 4 527

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Violation Priority Line
Avoid unused local variables such as 'currentLaneFine'. 3 150

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Violation Priority Line
Useless parentheses. 4 236
These nested if statements could be combined 3 238–245
Useless parentheses. 4 266
Avoid unused method parameters such as 'lanePathInfo'. 3 508
Avoid unused method parameters such as 'perception'. 3 508
Useless parentheses. 4 629

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Violation Priority Line
These nested if statements could be combined 3 70–79

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveGetInLane.java

Violation Priority Line
Useless parentheses. 4 90

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Violation Priority Line
Useless parentheses. 4 160
Useless parentheses. 4 161–162
Avoid unused method parameters such as 'gtu'. 3 714

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Violation Priority Line
These nested if statements could be combined 3 192–204
These nested if statements could be combined 3 490–506

org/opentrafficsim/road/gtu/lane/tactical/util/Steering.java

Violation Priority Line
Avoid unused local variables such as 'speed'. 3 94
Avoid unused local variables such as 'realPlan'. 3 128

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Violation Priority Line
Useless parentheses. 4 43
Useless parentheses. 4 44
Useless parentheses. 4 79
Useless parentheses. 4 80
Avoid unused local variables such as 'b'. 3 85
Ternary operators that can be simplified with || or && 3 93
Useless parentheses. 4 124
Useless parentheses. 4 125

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Violation Priority Line
Ternary operators that can be simplified with || or && 3 110

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Violation Priority Line
These nested if statements could be combined 3 184–201
Avoid unused private methods such as 'quickIntersectionScan(Parameters,SpeedLimitInfo,CarFollowingModel,Speed,LateralDirectionality,IntersectionPerception)'. 3 520–522

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Violation Priority Line
Useless parentheses. 4 317
Ternary operators that can be simplified with || or && 3 364–365
Useless parentheses. 4 368–369
Ternary operators that can be simplified with || or && 3 381–382
Useless parentheses. 4 393
Useless parentheses. 4 677
Useless parentheses. 4 677

org/opentrafficsim/road/gtu/strategical/od/SplitFraction.java

Violation Priority Line
Useless parentheses. 4 199
Useless parentheses. 4 200

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Violation Priority Line
Useless parentheses. 4 222
Useless parentheses. 4 223
Useless parentheses. 4 238–239
Useless parentheses. 4 240–241

org/opentrafficsim/road/network/factory/LaneFactory.java

Violation Priority Line
Avoid unused method parameters such as 'simulator'. 3 356

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Violation Priority Line
Useless parentheses. 4 224
Useless parentheses. 4 224
Avoid unused constructor parameters such as 'newSimulator'. 3 267

org/opentrafficsim/road/network/lane/Lane.java

Violation Priority Line
Useless parentheses. 4 470–471
Useless parentheses. 4 472–473
These nested if statements could be combined 3 475–479
Useless parentheses. 4 510–511
Useless parentheses. 4 512–513
These nested if statements could be combined 3 515–519
Useless parentheses. 4 1447
Useless parentheses. 4 1448
Useless parentheses. 4 1475
Useless parentheses. 4 1476

org/opentrafficsim/road/network/lane/LaneType.java

Violation Priority Line
Avoid unused constructor parameters such as 'inverted'. 3 144

org/opentrafficsim/road/network/lane/NoTrafficLane.java

Violation Priority Line
Avoid unused private methods such as 'directionalityNone(RoadNetwork)'. 3 35

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Violation Priority Line
Useless parentheses. 4 157
Useless parentheses. 4 158
These nested if statements could be combined 3 707–715

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Violation Priority Line
Useless parentheses. 4 374
Useless parentheses. 4 375
Useless parentheses. 4 516
Useless parentheses. 4 516
Useless parentheses. 4 524
Useless parentheses. 4 524

org/opentrafficsim/road/network/lane/conflict/DefaultConflictRule.java

Violation Priority Line
Useless parentheses. 4 111
Useless parentheses. 4 112

org/opentrafficsim/road/network/lane/object/BusStop.java

Violation Priority Line
Avoid unused constructor parameters such as 'simulator'. 3 63

org/opentrafficsim/road/network/lane/object/Distraction.java

Violation Priority Line
Avoid unused constructor parameters such as 'simulator'. 3 41

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Violation Priority Line
Avoid unused constructor parameters such as 'simulator'. 3 62

org/opentrafficsim/road/network/lane/object/sensor/SinkSensor.java

Violation Priority Line
Avoid unused constructor parameters such as 'dummy1'. 3 52
Avoid unused constructor parameters such as 'dummy2'. 3 52