| org.opentrafficsim.road.DefaultTestParameters |
Line |
| add another else to catch any unanticipated cases? |
77 |
| Explain why this exception can/should be ignored. do not set parameter without default value |
81 |
| org.opentrafficsim.road.car.CarTest |
Line |
| check with following model as part of tactical planner assertEquals("The gtu following model should be " + gtuFollowingModel, gtuFollowingModel, referenceCar .getBehavioralCharacteristics().getGTUFollowingModel()); There is (currently) no way to retrieve the lane change model of a GTU. |
94 |
| org.opentrafficsim.road.gtu.AbstractLaneBasedGTUTest |
Line |
| Test with gfm as part of tactical planner assertEquals("GTU following model should be identical to the provided one", gfm, car .getBehavioralCharacteristics().getGTUFollowingModel()); |
138 |
| removeLane should throw an Error when the car is not on that lane (currently this is silently ignored) |
382 |
| figure out why the added lane has a non-zero position |
383 |
| org.opentrafficsim.road.gtu.LaneBasedGTUTest |
Line |
| see how we can ask the vehicle to look this far ahead |
175 |
| see how we can ask the vehicle to look this far behind |
183 |
| see how we can ask the vehicle to look 'forwardMaxDistance' ahead |
217 |
| follower = truck.headway(reverseMaxDistance); |
238 |
| org.opentrafficsim.road.gtu.LaneBasedTemplateGTUTypeTest |
Line |
| assertTrue("Passengers cars are allowed on a no trucks lane", passengerCar.isCompatible(trucksForbidden)); |
257 |
| assertFalse("Trucks are not allowed on a no trucks lane", truck.isCompatible(trucksForbidden)); |
258 |
| assertFalse("Passenger cars are not allowed on a trucks only lane", passengerCar.isCompatible(trucksOnly)); |
259 |
| assertTrue("Trucks are allowed on a trucks only lane", truck.isCompatible(trucksOnly)); |
260 |
| assertTrue("Passenger cars are allowed on an urban road", passengerCar.isCompatible(urbanRoad)); |
261 |
| assertTrue("Trucks are allowed on an urban road", truck.isCompatible(urbanRoad)); |
262 |
| assertFalse("Passenger cars are not allowed on a bicycle path", passengerCar.isCompatible(bicycleLane)); |
263 |
| assertFalse("Trucks are not allowed on an urban road", truck.isCompatible(bicycleLane)); |
264 |
| org.opentrafficsim.road.gtu.generator.AbstractGTUGeneratorOld |
Line |
| different from this.direction? |
279 |
| THIS METHOD IS ALSO IN PERCEPTION -- DON'T DUPLICATE; ALSO, THIS VERSION IS WRONG. |
340 |
| Only follow links on the Route if there is a "real" Route if (routeNavigator.getRoute() == null || routeNavigator.getRoute().size() == 0 /* XXXXX STUB dummy route */ || routeNavigator.getRoute().containsLink((Link) theLane.getParentLink())) |
363 |
| XX STUB dummy route |
364 |
| THIS METHOD IS ALSO IN PERCEPTION -- DON'T DUPLICATE; ALSO, THIS VERSION IS WRONG. |
400 |
| Only follow links on the Route if there is a "real" Route if (routeNavigator.getRoute() == null || routeNavigator.getRoute().size() == 0 /* XXXXX STUB dummy route */ || routeNavigator.getRoute().containsLink((Link) theLane.getParentLink())) |
423 |
| XX STUB dummy route |
424 |
| org.opentrafficsim.road.gtu.generator.Platoons |
Line |
| end time of platoon may be in next demand period, which makes the demand non-linear |
322 |
| org.opentrafficsim.road.gtu.generator.headway.ListHeadways |
Line |
| from URI as defined in xsd |
42 |
| org.opentrafficsim.road.gtu.generator.od.DefaultGTUCharacteristicsGeneratorOD |
Line |
| remove above constructors and use factory always |
155 |
| org.opentrafficsim.road.gtu.generator.od.ODApplier |
Line |
| sinks? white extension links? |
133 |
| clean up stream acquiring code after task OTS-315 has been completed |
143 |
| org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU |
Line |
| should be indicated with a Parameter |
158 |
| can be removed after testing period |
162 |
| can be removed after testing period |
166 |
| When requesting the position at the end of the plan, which will be on a further lane, this lane is not yet part of the lanes in the current operational plan. This can be upstream or downstream depending on the direction of travel. We might check whether getDirection(lane)=DIR_PLUS and upstream=false, or getDirection(lane)=DIR_MINUS and upstream=true, to then use LaneDirection.getNextLaneDirection(this) to obtain the next lane. This is only required if nextLanes originally had more than 1 lane, otherwise we can simply use that one lane. Problem is that the search might go on far or even eternally (on a circular network), as projection simply keeps failing because the GTU is actually towards the other longitudinal direction. Hence, the heuristic used before this method is called should change and first always search against the direction of travel, and only consider lanes in currentLanes, while the consecutive search in the direction of travel should then always find a point. We could build in a counter to prevent a hanging software. |
1108 |
| widest lane in case we are registered on more than one lane with the reference point? |
1160 |
| lane that leads to our location or not if we are registered on parallel lanes? |
1161 |
| org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU |
Line |
| Should throw a more specific Exception type |
448 |
| org.opentrafficsim.road.gtu.lane.changing.LaneChangeModelTest |
Line |
| create a LinkAnimation if the simulator is compatible with that. |
101 |
| The current LinkAnimation is too bad to use... |
102 |
| Decide what type of overtaking conditions we want in this test |
128 |
| test/prove the expected differences between Egoistic and Altruistic |
304 |
| prove that the most restrictive car in the other lane determines what happens |
305 |
| test merge into overtaking lane |
306 |
| org.opentrafficsim.road.gtu.lane.control.DelayedActuation |
Line |
| numerical implementation of tau rule |
46 |
| org.opentrafficsim.road.gtu.lane.perception.AbstractPerceptionIterable |
Line |
| this let's us ignore an object that is registered on the next lane, but who's tail may be on this lane |
259 |
| org.opentrafficsim.road.gtu.lane.perception.RollingLaneStructure |
Line |
| on complex networks, e.g. with sections connectors where lane changes are not possible, the update may fail |
205 |
| we now assume everything is on the route, but merges could be ok without route so, without a route we should be able to recognize which upstream 'nextLane' is on the other link |
1011 |
| org.opentrafficsim.road.gtu.lane.perception.RollingLaneStructureRecord |
Line |
| clear on network change, with an event listener? |
44 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DefaultSimplePerception |
Line |
| In other places in OTS LEFT is positive (and RIGHT is negative). This should be made more consistent. |
253 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectDefaultSimplePerception |
Line |
| end of lanepath |
636 |
| allow observation of other objects as well. |
842 |
| --No comment-- |
939 |
| calculate real overlaps |
955 |
| expand for other types of Headways result.add(new HeadwayGTUSimple(p.getId(), ((AbstractHeadwayGTU) p).getGtuType(), new Length(Double.NaN, LengthUnit.SI), p.getLength(), p.getSpeed(), p.getAcceleration())); |
1014 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectInfrastructurePerception |
Line |
| more than the lane speed limit and maximum vehicle speed in the speed limit prospect |
47 |
| this is not suitable if we change lane and consider e.g. dynamic speed signs, they will be forgotten |
117 |
| splits |
446 |
| splits |
457 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectIntersectionPerception |
Line |
| if conflicts span multiple lanes, this within-lane search fails |
154 |
| get from link combination (needs to be a map property on the links) |
183 |
| limit 'conflictingVisibility' to first upstream traffic light, so GTU's behind it are ignored |
200 |
| stop lines (current models happen not to use this, but should be possible) |
211 |
| --No comment-- |
239 |
| org.opentrafficsim.road.gtu.lane.perception.categories.neighbors.DirectNeighborsPerception |
Line |
| not use this check when synchronizing or cooperating |
253 |
| org.opentrafficsim.road.gtu.lane.perception.headway.HeadwayGTUReal |
Line |
| --No comment-- |
261 |
| --No comment-- |
290 |
| org.opentrafficsim.road.gtu.lane.perception.headway.HeadwayGTUType |
Line |
| create SpeedLimitInfo on the basis of this.gtuTypeAssumptions.getLaneTypeMaxSpeed(...) |
152 |
| org.opentrafficsim.road.gtu.lane.plan.operational.LaneChange |
Line |
| get rid of cast to AbstractLaneBasedGTU |
282 |
| org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder |
Line |
| driving with negative speeds (backward driving) is not yet supported. <p> Copyright (c) 2013-2019 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. <br> BSD-style license. See <a href="http://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. </p> $LastChangedDate: 2015-07-24 02:58:59 +0200 (Fri, 24 Jul 2015) $, @version $Revision: 1147 $, by $Author: averbraeck $, initial version Nov 15, 2015 <br> |
48 |
| org.opentrafficsim.road.gtu.lane.plan.operational.SimpleOperationalPlan |
Line |
| AV |
115 |
| AV |
126 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner |
Line |
| how to handle objects on this lane or another lane??? |
133 |
| these two info's are not used |
148 |
| skip if: - we are in the right lane and drive at max speed or we accelerate maximally - there are no other lanes |
153 |
| whether we drive on the right should be stored in some central place. |
159 |
| move laneIncentives to LanePerception? Figure out if the default lane incentives are OK, or override them with values that should keep this GTU on the intended route. |
235 |
| these comparisons to -10 is ridiculous. |
291 |
| move suitability to LanePerception? Return the suitability for the current lane, left adjacent lane or right adjacent lane. |
383 |
| this code assumes GTUDirectionality.DIR_PLUS on all lanes of interest |
438 |
| --No comment-- |
618 |
| this method should probably be moved into the CrossSectionLink class |
676 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingDirectedChangeTacticalPlanner |
Line |
| should it be getObjectType().isGtu() or !getObjectType().isDistanceOnly() ? |
297 |
| Object & GTU |
298 |
| should it be getObjectType().isGtu() or !getObjectType().isDistanceOnly() ? |
344 |
| GTU & Object |
345 |
| remove this hack |
513 |
| should it be getObjectType().isGtu() or !getObjectType().isDistanceOnly() ? |
560 |
| Object & GTU |
561 |
| make type of plan (Egoistic, Altruistic) parameter of the class |
571 |
| make the elasticities 2.0 and 0.1 parameters of the class |
573 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingTacticalPlanner |
Line |
| I really don't like this -- if there is a lane drop at 20 m, the GTU should stop... |
83 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedTacticalPlanner |
Line |
| private when we use java 9 |
87 |
| private when we use java 9 |
118 |
| org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil |
Line |
| Under which circumstances can getDistance() be NULL? Should that indeed result in TOODANGEROUS? |
62 |
| org.opentrafficsim.road.gtu.lane.tactical.following.FixedAccelerationModel |
Line |
| should be specified in constructor |
89 |
| org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld |
Line |
| maxDistance dV is the approach speed |
113 |
| org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld |
Line |
| maxDistance |
119 |
| org.opentrafficsim.road.gtu.lane.tactical.following.SequentialFixedAccelerationModel |
Line |
| incorporate stepSize |
157 |
| org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel |
Line |
| make this driving side dependent; i.e. implement a general way to figure out on which side of the road cars are supposed to drive |
68 |
| org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.LaneChangeModel |
Line |
| Lane change models should use the perceived nearby GTUs rather than a provided list of same lane traffic, etc. <p> Copyright (c) 2013-2019 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. <br> BSD-style license. See <a href="http://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. <p> |
15 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.AccelerationBusStop |
Line |
| this is much more complex: tail blocking other traffic? other bus in front? many people at bus stop? |
40 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.AccelerationConflicts |
Line |
| consider adjacent lanes before and during lane change |
51 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.AccelerationNoRightOvertake |
Line |
| ignore incentive if we need to change lane for the route |
50 |
| only sensible if the left leader can change right; add this info to HeadwayGTU? |
65 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.IncentiveCourtesy |
Line |
| factor -a/b as influence factor is heavy in calculation, consider v<vEgo & 1-s/x0 |
86 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.IncentiveSocioSpeed |
Line |
| keep left or right rules |
41 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.IncentiveSpeed |
Line |
| SpeedWithCourtesy now uses TrafficPerception, which embeds the courtesy part. How to do this? |
33 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo |
Line |
| vehicle not ahead and not backwards but completely adjacent |
117 |
| infinite -> some limited space, speed also one leader |
350 |
| definition of 'right most lane' does not account for ramps and weaving sections |
638 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.ToledoCarFollowing |
Line |
| speed difference with reaction time |
146 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.ToledoPerception |
Line |
| updateInfrastructureLaneChangeInfo with split number |
33 |
| org.opentrafficsim.road.gtu.lane.tactical.util.ConflictUtil |
Line |
| do not ignore vehicles upstream of conflict if they have green |
64 |
| conflict over multiple lanes (longitudinal in own direction) |
65 |
| a) yielding while having priority happens only when leaders is standing still on conflict (then its useless...) b) two vehicles can remain upstream of merge if vehicle stands on merge but leaves some space to move probably 1 is yielding, and 1 is courtesy yielding as the other stands still c) they might start moving together and collide further down (no response to negative headway on merge) |
66 |
| depending on left/right-hand traffic |
201 |
| depending on rules, we may need to stop and not just yield |
216 |
| --No comment-- |
270 |
| what to do when we happen to be in the stopping distance? Stopping might be reasonable, while car-following might give strong deceleration due to s < s0. |
280 |
| only within visibility |
437 |
| safety factor? |
487 |
| conflicting vehicle on crossing conflict, but will leave sooner then we enter, so no problem? |
582 |
| more generally, also upstream conflicting vehicles at crossings may leave the conflict before we enter |
583 |
| stopping |
773 |
| all-stop behavior |
786 |
| org.opentrafficsim.road.gtu.lane.tactical.util.Steering |
Line |
| apply math |
109 |
| how to handle a shorter (i.e. speed profile assumes more length) or longer path (i.e. impossible to get position on reference trajectory) |
136 |
| return new plan |
140 |
| implement steering control based on reference points |
157 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Cooperation |
Line |
| only cooperate if merger still quite fast or there's congestion downstream anyway (which we can better estimate than only considering the direct leader |
101 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.GapAcceptance |
Line |
| --No comment-- |
49 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Synchronization |
Line |
| replace this hack with something that properly accounts for overshoot this method also introduces very strong deceleration at low speeds, as the time step makes bMin go from 3.4 (ignored, so maybe 1.25 acceleration applied) to >10 |
75 |
| this ignores the front it seems! |
224 |
| find a better solution for this inefficient hack... when to ignore a vehicle for synchronization? |
507 |
| org.opentrafficsim.road.gtu.perception.VerifyPerceptionCategoryMethods |
Line |
| fail("Class " + c + " does not have a field '" + field + "*', nor wraps a perception category that does."); |
184 |
| fail... |
215 |
| fail... |
221 |
| org.opentrafficsim.road.gtu.strategical.LaneBasedStrategicalRoutePlannerTest |
Line |
| Gtu cannot be null anymore... LaneBasedStrategicalRoutePlanner lbsrp = new LaneBasedStrategicalRoutePlanner(params, tacticalPlanner, null); |
53 |
| org.opentrafficsim.road.gtu.strategical.od.SplitFraction |
Line |
| let interpolation interpolate itself |
175 |
| org.opentrafficsim.road.gtu.strategical.route.LaneBasedStrategicalRoutePlanner |
Line |
| Is there a reason not to iterate over csLink.getLanes()? |
232 |
| this takes the first in the set of links that connects the correct nodes; does not handle parallel links consistently |
282 |
| org.opentrafficsim.road.network.LinkLocationTest |
Line |
| distance to location on another link (not yet possible; currently ALWAYS returns null) |
74 |
| org.opentrafficsim.road.network.OTSRoadNetworkUtils |
Line |
| clone the visible objects |
97 |
| org.opentrafficsim.road.network.lane.CrossSectionLink |
Line |
| per GTUDirectionality / LongitudinalDirectionality? |
47 |
| work in a different way with lane numbers to align to standard lane numbering. |
56 |
| allow for the removal of a Lane; currently this is not possible. |
63 |
| org.opentrafficsim.road.network.lane.CurveTest |
Line |
| finish writing this test |
102 |
| org.opentrafficsim.road.network.lane.Lane |
Line |
| allow for direction-dependent speed limit |
108 |
| allow for direction-dependent sensors |
118 |
| allow for direction-dependent lane objects |
125 |
| constructor calls with this(...) |
391 |
| take the cross section slices into account... |
453 |
| take the cross section slices into account... |
469 |
| take the cross section slices into account... |
493 |
| take the cross section slices into account... |
509 |
| this is a hack for when sink sensors aren't perfectly adjacent or the GTU overshoots with nose due to curvature |
764 |
| should this change when we drive in the opposite direction? |
945 |
| AV 20190113 |
960 |
| AV 20190113 |
961 |
| only center position? Or also width? What is a good cutoff? Base on average width of the GTU type that can drive on this Lane? E.g., for a Tram or Train, a 5 cm deviation is a problem; for a Car or a Bicycle, more deviation is acceptable. |
1267 |
| this should return something immutable |
1288 |
| determine if this should synchronize on this.nextLanes |
1297 |
| And is it aligned with its next lane? |
1317 |
| And is it aligned with its next lane? |
1332 |
| this should return something immutable |
1367 |
| And is it aligned with its next lane? |
1395 |
| And is it aligned with its next lane? |
1411 |
| check that the directionality of this Lane does not conflict with that of the parent the OTSLink for (GTUType gtuType : this.directionalityMap.keySet()) { LongitudinalDirectionality directionality = this.directionalityMap.get(gtuType); if (!getParentLink().getDirectionality(gtuType).contains(directionality)) { throw new NetworkException("Lane " + toString() + " allows " + gtuType + " a directionality of " + directionality + " which is not present in the overarching link " + getParentLink().toString()); } } |
1684 |
| let HistoricalArrayList return an Immutable (WRAP) of itself |
1701 |
| org.opentrafficsim.road.network.lane.LaneTest |
Line |
| what overtaking conditions do we want to test in this unit test? |
88 |
| This test for expectedLateralCenterOffset fails |
103 |
| what overtaking conditions do we ant to test in this unit test? |
141 |
| what overtaking conditions do we ant to test in this unit test? |
155 |
| what overtaking conditions do we want to test in this unit test? |
215 |
| org.opentrafficsim.road.network.lane.SensorTest |
Line |
| this is not true anymore with OperationalPlans, Perception, etc => |
143 |
| the number of events that should be scheduled can vary per models chosen |
144 |
| assertEquals("There should be three scheduled events (trigger, leaveLane, |
145 |
| car.move, terminate)", 4, eventList.size()); The sensor should be triggered around t=38.3403 (exact value: 10 / 9 * (sqrt(3541) - 25)) System.out.println("trigger event is " + triggerEvent); / TODO not triggered in next half second. |
146 |
| assertEquals("Trigger event should be around 38.3403", 38.3403, |
150 |
| triggerEvent.getAbsoluteExecutionTime().get().getSI(), 0.0001); |
151 |
| check that the sensor is triggered at the right time. |
179 |
| org.opentrafficsim.road.network.lane.changing.OvertakingConditions |
Line |
| All these "Right/LeftSet" classes should probably use Compatibility instead of full sets. <p> Copyright (c) 2013-2019 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. BSD-style license. See <a href="http://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. </p> $LastChangedDate: 2015-07-24 02:58:59 +0200 (Fri, 24 Jul 2015) $, @version $Revision: 1147 $, by $Author: averbraeck $, initial version Sep 13, 2015 |
308 |
| org.opentrafficsim.road.network.lane.conflict.Conflict |
Line |
| why not create a getter for the gtu in the super class? <p> Copyright (c) 2013-2019 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. <br> BSD-style license. See <a href="http://opentrafficsim.org/node/13">OpenTrafficSim License</a>. <p> |
464 |
| org.opentrafficsim.road.network.lane.conflict.ConflictBuilder |
Line |
| use z-coordinate for intersections of lines |
38 |
| org.opentrafficsim.road.network.lane.object.sensor.DirectionalOccupancySensor |
Line |
| enforce clone method |
63 |
| org.opentrafficsim.road.network.lane.object.sensor.NonDirectionalOccupancySensor |
Line |
| enforce clone method |
66 |
| org.opentrafficsim.road.network.lane.object.sensor.TrafficLightSensor |
Line |
| Possibly provide the GTUTypes that trigger the sensor as an argument for the constructor |
85 |
| not handling backwards driving GTU |
329 |
| org.opentrafficsim.road.network.lane.object.sensor.TrafficLightSensorTest |
Line |
| @Test |
156 |
| THIS TEST FAILS!! assertEquals("event list should contain one event (due to creation of the GTU on the detector)", 1, this.loggedEvents.size()); |
241 |
| org.opentrafficsim.road.network.lane.object.trafficlight.FlankSensor |
Line |
| should the parent of the clone be our parent??? And should the (cloned) parent not construct its own flank sensors? |
70 |
| org.opentrafficsim.road.network.sampling.RoadSampler |
Line |
| GTUDirectionality from Lane.GTU_ADD_EVENT |
220 |
| Length from Lane.GTU_ADD_EVENT |
232 |
| GTUDirectionality from Lane.GTU_REMOVE_EVENT |
261 |
| org.opentrafficsim.road.network.speed.package-info |
Line |
| --No comment-- |
21 |
